From: Iuliana Prodan <iuliana.prodan@nxp.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Patrice CHOTARD <patrice.chotard@foss.st.com>,
Saravana Kannan <saravanak@google.com>,
Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>,
Daniel Baluta <daniel.baluta@nxp.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: reserved_mem: Add missing IORESOURCE_MEM flag on resources
Date: Thu, 21 Aug 2025 09:39:44 +0300 [thread overview]
Message-ID: <38c470ee-0961-4197-a64f-e25bbbfc08ba@nxp.com> (raw)
In-Reply-To: <20250820192805.565568-1-robh@kernel.org>
On 8/20/2025 10:28 PM, Rob Herring (Arm) wrote:
> Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse
> "memory-region"') failed to set IORESOURCE_MEM flag on the resources.
> The result is functions such as devm_ioremap_resource_wc() will fail.
> Add the missing flag.
>
> Fixes: f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
> Reported-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> Reported-by: Daniel Baluta <daniel.baluta@gmail.com>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Tested-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Thanks,
Iulia
> ---
> drivers/of/of_reserved_mem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 77016c0cc296..d3b7c4ae429c 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
> return -EINVAL;
>
> resource_set_range(res, rmem->base, rmem->size);
> + res->flags = IORESOURCE_MEM;
> res->name = rmem->name;
> return 0;
> }
prev parent reply other threads:[~2025-08-21 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 19:28 Rob Herring (Arm)
2025-08-20 20:51 ` Saravana Kannan
2025-08-21 6:39 ` Iuliana Prodan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c470ee-0961-4197-a64f-e25bbbfc08ba@nxp.com \
--to=iuliana.prodan@nxp.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®