From: Nikolay Borisov <nborisov@suse.com>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove BUG_ON used as assertions
Date: Sun, 15 Dec 2019 19:42:50 +0200 [thread overview]
Message-ID: <38c5aa97-675b-b4fa-14ab-04988a9c6a39@suse.com> (raw)
In-Reply-To: <20191215171237.27482-1-pakki001@umn.edu>
On 15.12.19 г. 19:12 ч., Aditya Pakki wrote:
> alloc_extent_state_atomic() allocates extents via GFP_ATOMIC flag
> and cannot fail. There are multiple invocations of BUG_ON on the
> return value to check for failure. The patch replaces certain
> invocations of BUG_ON by returning the error upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Have you actually audited all callers of __set_extent_bit whether they
correctly handle failures?
next prev parent reply other threads:[~2019-12-15 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 17:12 Aditya Pakki
2019-12-15 17:42 ` Nikolay Borisov [this message]
2019-12-18 16:31 ` David Sterba
2019-12-18 16:38 ` Josef Bacik
2019-12-18 16:47 ` David Sterba
2019-12-18 19:54 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c5aa97-675b-b4fa-14ab-04988a9c6a39@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kjlu@umn.edu \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®