From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A4672030A for ; Tue, 10 Mar 2026 00:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773101059; cv=none; b=G9qUZKeoTn00oMzrAIOmJt6Pxy3HM/sPZyUuODPGepRvUvuweF2ee7Uo0/0Y5amJ3ISX9V9r620RLI/HHNbffez+qfZ8XR5ig6rR30Yqkao5fCQxBtrMxx9qGTkY5nLdvLY0RZKxRIi74nWteajKrqUdGXD9UbIbaGCxgpw5yXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773101059; c=relaxed/simple; bh=U/8rTD2o4m6Tjj3AJvdNv9BQmz1U4LX+8HgzxqcG0ew=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MQgt7dg+FAXqKr5QG+raZYo6i8964kN1IdoynJpit8pii3Y60DWNjv841zT8c+M7IclJz7L/02UUz37dzDWeQJcqPgvnQEg0UNnOFNyTP3m6Q7rDcmzm8WHToBv1TajQgNWiflLDm7lXnDpdF9x3eWCJpzUuLFMYoK+yOp6x/7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UBi9llqf; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UBi9llqf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773101057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CUfLC0f2AWQrj2JXMtmVBU5gG8MnUPc2ruYf8Fml+U8=; b=UBi9llqfwMzKZ76u3AjKCwkL9wCrStT5ma2tXMguI2y6hx4wL5prVnvN+dCKhH9ajaoBZV 7lKsf4JPSxxN0MVQd2S8rSXk33hm8lmnVtnMTAzUtmcWIIfJ0Ao3AJIyjk5uUvKu4YZXBJ nxg/xsqOsnSvq4Jp9kVM20hHdY3JFlE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-vCKMX45vN-W9t60to1Wwhw-1; Mon, 09 Mar 2026 20:04:10 -0400 X-MC-Unique: vCKMX45vN-W9t60to1Wwhw-1 X-Mimecast-MFC-AGG-ID: vCKMX45vN-W9t60to1Wwhw_1773101049 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 704C11956060; Tue, 10 Mar 2026 00:04:08 +0000 (UTC) Received: from [10.22.81.138] (unknown [10.22.81.138]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D67EE1800361; Tue, 10 Mar 2026 00:04:05 +0000 (UTC) Message-ID: <38c7a9a2-a8f1-4ae2-9070-73d0ebb42f53@redhat.com> Date: Mon, 9 Mar 2026 20:04:05 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: memcg: Skp memcg_sock test if address family not supported To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , Mike Rapoport , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20260309160205.651754-1-longman@redhat.com> <4ddd3jascnb6nt7quhyjfmsgsmtfmjofwmnrgjktz57cfbfymj@6ejbdgbg4lz2> Content-Language: en-US From: Waiman Long In-Reply-To: <4ddd3jascnb6nt7quhyjfmsgsmtfmjofwmnrgjktz57cfbfymj@6ejbdgbg4lz2> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 3/9/26 2:07 PM, Michal Koutný wrote: > On Mon, Mar 09, 2026 at 12:02:05PM -0400, Waiman Long wrote: >> On systems where IPv6 isn't enabled or not configured to support >> SOCK_STREAM, the test_memcg_sock test always fails. > I think IPv6 is not substantial for the check... I mentioned it because the current code is using AF_INET6 family. > >> The purpose of the test_memcg_sock test is to verify that >> memory.stat.sock and memory.current values are close. > ... so this should work with IPv4 too. Probably, I will try that out. > >> If the socket() call fails, there is no way we can test that. I >> believe it is better to just skip the test in this case instead of >> reporting a test failure hinting that there may be something wrong >> with the memcg code. > Yes, the skip on (any) socket creation is also (independently) good. > >> @@ -1460,6 +1466,9 @@ static int test_memcg_sock(const char *root) >> free(memcg); >> >> return ret; >> +skip: >> + ret = KSFT_SKIP; >> + goto cleanup; > Maybe make this analogous with other cases where there is no specific skip-label but > > if (err == EAFNOSUPPORT) { > ret = KSFT_SKIP; > goto cleanup; > } Yes, that will work too. Will make the update in the next version. Cheers, Longman