From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7C1C433F5 for ; Tue, 8 Mar 2022 10:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345991AbiCHKuP (ORCPT ); Tue, 8 Mar 2022 05:50:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239485AbiCHKuN (ORCPT ); Tue, 8 Mar 2022 05:50:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4D42E3DA51 for ; Tue, 8 Mar 2022 02:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646736556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QBUaBHFVFzH61kttRw3vU/TxfXeStTkYl0GPKGc8WcE=; b=FBsTD/0XVrm4ydtsvWV7itkOZQcR2oASCIXTu9tk0heQJ572TU++TKPicrX+joSkcbyc5u iGnljwSkpwMBd3IDHdgVkLPn2CbrTyjDkRRMUS1Nh+TbXTIg9JZVMyuEz+uvmJOcNSHqy7 HgA7LaUrRMYQx6xlpEi+PbvaKT4xk+k= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-501-lYnjH-GAO9iYhx-CI8xZGg-1; Tue, 08 Mar 2022 05:49:13 -0500 X-MC-Unique: lYnjH-GAO9iYhx-CI8xZGg-1 Received: by mail-qk1-f198.google.com with SMTP id i189-20020a3786c6000000b00646d7b30998so13891716qkd.10 for ; Tue, 08 Mar 2022 02:49:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=QBUaBHFVFzH61kttRw3vU/TxfXeStTkYl0GPKGc8WcE=; b=Q9zwu2SMlvGyautKaVuXeswQ0eNcg8QPAJh+0w4vmTG+KLNOTWaFWyje8GP/O4/imJ XAS4UWX/ucCON2QRLw9x3nmXuUT7awria1iAutsEbiT9IgSq+NuDx1oJ0wRZ/5pH+kmV Zc9v1abCT2N988tm20AVpJb3Cd9aFNUkmUvs8ctSVwY8R2sVAA1epdDoB4l4EjDM52QP yzPYdOQUvJCyWzZq4KjtHkfsU47w+YbcctnkKDqEFbcA1P9esngMVdeEZ4x0c5Vj/I6E ex+U6S+Yv/XgcxPe+ocaybzwlZZVgIREczi24sGiFUt385EDeq/XUqlzoKgf+XF4xtRC cG0Q== X-Gm-Message-State: AOAM531Wu88xg7D+7oYPs0QNVz525cufPJZgBHYn+RwM+59KZsp4ES0j JKodcuICFD6TuB6ezhhceCdfem+djSmFhBf3QLiqr430AGRCvAxjuUUr49SKYz8G4yvjzycy2Vv iptOAQMq7+B96punog9NlC1kh X-Received: by 2002:a05:6214:2a4a:b0:435:8b63:ecfb with SMTP id jf10-20020a0562142a4a00b004358b63ecfbmr7485980qvb.44.1646736552970; Tue, 08 Mar 2022 02:49:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpx3hIh+39H8UxjxhPinjAfhfXTwNPWavYyQ9aJfYLnuOb+72k+PF5hHSRGOgfL6XqVEiAdA== X-Received: by 2002:a05:6214:2a4a:b0:435:8b63:ecfb with SMTP id jf10-20020a0562142a4a00b004358b63ecfbmr7485967qvb.44.1646736552733; Tue, 08 Mar 2022 02:49:12 -0800 (PST) Received: from gerbillo.redhat.com (146-241-232-135.dyn.eolo.it. [146.241.232.135]) by smtp.gmail.com with ESMTPSA id p16-20020a05620a22b000b0067b7b158985sm1311776qkh.128.2022.03.08.02.49.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 02:49:12 -0800 (PST) Message-ID: <38c7c77ee46ed54319b7222c2fada0039a980a2e.camel@redhat.com> Subject: Re: [PATCH] drivers: vxlan: fix returnvar.cocci warning From: Paolo Abeni To: Guo Zhengkui , "David S. Miller" , Jakub Kicinski , Roopa Prabhu , Eric Dumazet , Sebastian Andrzej Siewior , "open list:NETWORKING DRIVERS" , open list Cc: zhengkui_guo@outlook.com Date: Tue, 08 Mar 2022 11:49:08 +0100 In-Reply-To: <20220308100034.29035-1-guozhengkui@vivo.com> References: <20220308100034.29035-1-guozhengkui@vivo.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, 2022-03-08 at 18:00 +0800, Guo Zhengkui wrote: > Fix the following coccicheck warning: > > drivers/net/vxlan/vxlan_core.c:2995:5-8: > Unneeded variable: "ret". Return "0" on line 3004. > > Signed-off-by: Guo Zhengkui Please specify a target tree (likely net-next) in the patch subj. Additionally, this looks worthy a "Fixes" tag, likely: Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device") Thanks, Paolo