From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0820C4332F for ; Fri, 1 Apr 2022 07:50:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343995AbiDAHw2 (ORCPT ); Fri, 1 Apr 2022 03:52:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235432AbiDAHw1 (ORCPT ); Fri, 1 Apr 2022 03:52:27 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44BB118DABE; Fri, 1 Apr 2022 00:50:37 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 6975B1F40FA7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648799436; bh=GEf0nEJQNZXszGDptrQO3o7b80i82CTwEgPl8PZMhOA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jOwCiMnFbtrL2h5VrTaakpahFkQ9lyJBlI+5o/TInsHv9DsHVBS42/SycdxYzP8Z7 2rnV/9eeI3dLUgM+WIuGpo/jElJoqHM+bCHH9xZyitktLLhraAak+Hx5UbfxdzZ+2u 09VpPaI4M69e3oYBIfHgPPIIEbMOQt5+IyJJaGNcDFn3wLfAf3dMH0aFnpYBYFVxOb TNVaUw1dyMzcLzJx8mVvm7Kc9S9OuKR7+GFBz+/B+3SrWooUnyCE3mbRjqMjctG/aW fpqN9VDrR2AgU41yVkrpGsNR8Gt/DJKI2obowakUufYAB+yHvoP4mbVVmP0kA3PP7A CpfJT++gxUrlg== Message-ID: <38c9685e-380e-87ce-4a3a-5d274c0892fa@collabora.com> Date: Fri, 1 Apr 2022 09:50:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] media: mediatek: vcodec: fix v4l2 compliance decoder cmd test fail Content-Language: en-US To: Yunfei Dong , Alexandre Courbot , Nicolas Dufresne , Hans Verkuil , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220401030406.6437-1-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220401030406.6437-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 01/04/22 05:04, Yunfei Dong ha scritto: > Will return -EINVAL using standard framework api when test stateless > decoder with cmd VIDIOC_(TRY)DECODER_CMD. > > Using another return value to adjust v4l2 compliance test for user > driver(GStreamer/Chrome) won't use decode cmd. > > Signed-off-by: Yunfei Dong Hello Yunfei, this patch is a fix.. hence, this needs an appropriate Fixes: tag. Please add one. Thanks, Angelo > --- > drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > index 3859e4c651c6..69b0e797d342 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c > @@ -51,8 +51,7 @@ static int vidioc_try_decoder_cmd(struct file *file, void *priv, > > /* Use M2M stateless helper if relevant */ > if (ctx->dev->vdec_pdata->uses_stateless_api) > - return v4l2_m2m_ioctl_stateless_try_decoder_cmd(file, priv, > - cmd); > + return -ENOTTY; > else > return v4l2_m2m_ioctl_try_decoder_cmd(file, priv, cmd); > }