mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: dinghao.liu@zju.edu.cn
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: "Alexander Aring" <alex.aring@gmail.com>,
	"Stefan Schmidt" <stefan@datenfreihafen.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Marcel Holtmann" <marcel@holtmann.org>,
	"Harry Morris" <harrymorris12@gmail.com>,
	linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe
Date: Tue, 26 Sep 2023 20:40:40 +0800 (GMT+08:00)	[thread overview]
Message-ID: <38f11c6a.2d287.18ad18184c8.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20230926100202.011ab841@xps-13>

> Missing Cc stable, this needs to be backported.

I will cc stable (stable@vger.kernel.org) for the next version, thanks!
> > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> > index aebb19f1b3a4..b35c6f59bd1a 100644
> > --- a/drivers/net/ieee802154/ca8210.c
> > +++ b/drivers/net/ieee802154/ca8210.c
> > @@ -2759,7 +2759,6 @@ static int ca8210_register_ext_clock(struct spi_device *spi)
> >  	}
> >  	ret = of_clk_add_provider(np, of_clk_src_simple_get, priv->clk);
> >  	if (ret) {
> > -		clk_unregister(priv->clk);
> >  		dev_crit(
> >  			&spi->dev,
> >  			"Failed to register external clock as clock provider\n"
> 
> I was hoping you would simplify this function a bit more.

I understand. In the next patch version, I will just return of_clk_add_provider(). 

> 
> > @@ -2780,7 +2779,7 @@ static void ca8210_unregister_ext_clock(struct spi_device *spi)
> >  {
> >  	struct ca8210_priv *priv = spi_get_drvdata(spi);
> >  
> > -	if (!priv->clk)
> > +	if (IS_ERR_OR_NULL(priv->clk))
> >  		return
> >  
> >  	of_clk_del_provider(spi->dev.of_node);
> 
> Alex, Stefan, who handles wpan and wpan/next this release?
>
 
Is there any problem I need to handle in the next patch?

Regards,
Dinghao

      parent reply	other threads:[~2023-09-26 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26  3:22 Dinghao Liu
2023-09-26  8:02 ` Miquel Raynal
2023-09-26  8:29   ` Stefan Schmidt
2023-09-26 16:40     ` Alexander Aring
2023-09-26 12:40   ` dinghao.liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38f11c6a.2d287.18ad18184c8.Coremail.dinghao.liu@zju.edu.cn \
    --to=dinghao.liu@zju.edu.cn \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=harrymorris12@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®