From: Tuowen Zhao <ztuowen@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
AceLan Kao <acelan.kao@canonical.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc
Date: Wed, 16 Oct 2019 11:58:48 -0600 [thread overview]
Message-ID: <38f39e9e77cb4bc809a15da45d988f33cb0f7f00.camel@gmail.com> (raw)
In-Reply-To: <20191016125615.GI16384@42.do-not-panic.com>
On Wed, 2019-10-16 at 12:56 +0000, Luis Chamberlain wrote:
> Indeed, can you add that? If you are not comfortable the way to leave
> behind lazy architectures is the HAS_FOO feature and then have your
> driver require that or depend on the archs that support this. This
> allows non-lazy architecturess to move forward with life.
>
> Luis
Upon close examination, the issue seems easy to fix. Going to submit a
new set shortly.
sparc64 and hexagon don't have ioremap_uc defined. Hexagon also doesn't
have ioremap_wc but didn't report an issue before so devm_ioremap won't
have an problem.
Interestingly tho, majority of the archs include <asm-generic/io.h>,
thus having prototypes. These two archs and a few others don't. I'm
wondering if including the prototypes is actually the recommended
practice.
Tuowen
next prev parent reply other threads:[~2019-10-16 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 15:33 Tuowen Zhao
2019-10-14 15:33 ` [PATCH v4 2/2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
2019-10-14 18:46 ` [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc kbuild test robot
2019-10-14 19:15 ` Tuowen Zhao
2019-10-15 7:44 ` Andy Shevchenko
2019-10-16 12:56 ` Luis Chamberlain
2019-10-16 17:58 ` Tuowen Zhao [this message]
2019-12-04 11:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f39e9e77cb4bc809a15da45d988f33cb0f7f00.camel@gmail.com \
--to=ztuowen@gmail.com \
--cc=acelan.kao@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome