From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D1F51CBE95; Mon, 13 Jan 2025 19:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736797889; cv=none; b=of99X1xwbLmsN3Cr2MIBei5bwUn3yHNGH54IJkPBpb/VBoIqG8h86+P+7tTfKtdSmIG0V6vajW8BUsDduKMKhobYRJM30okm8Y+i1Gq934Pa3H0bFDXUCsRPdQU36F48wGHXcS6/hQ8KzTflOBnCbHHh0y2F95OryuQXAMf4bzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736797889; c=relaxed/simple; bh=SApC4GJ6aRMoZq0Qs59KKqoIswTr3Nt4qjR2jOAzTgU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f7Cubrumo4n2FkTBOJR7x3thDOp5WqEZ16nBBGRhPdm7v2PdW4tbCVAh9Xzu0eOjct8WfIv3et5fb1TVu5af9LxNbIjLMREko8L0n+Rb7qaRPlXKIkOA4qbeYRMIj6Dr1hyiqUP/8QjdTzOgq2a/pE7zp+mGZDgWSG9/j8W1c8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=QK08Vscl; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="QK08Vscl" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50DF7OBK003096; Mon, 13 Jan 2025 19:50:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=raLVaz OTH2YUlyxL7EXDEtYhqzQORGC8oK0/B3jL/r0=; b=QK08VsclLq2CSJ3yGljUqE nt2Zcd+bdQ1P/e/1DtTX2M4O3njriADKQRinqVp5zKwKhDyFb/dIqxBotxDTV1IM XWCmmfncK6SpUEelMr7zNQiPyB6JcmvJJdaV+ROwlfgzMPaj4QqSYbMjeJE5faHI YqrIu4g3j5lc3VTR66iUnKI7w1OR2Pxkjk2Cy27O1MdWCpRzLPbJuuQ7PXim0o9c RE52WlwrqdOlc88d++PiZLvI0nNGO3P6fHQBcDOVdk6cju0lP0kVNLojCFBTQfm1 9ujyM4IAAL/Jfz8MBP9RowtQ+1fy+A29VwlzN+sdCCNX+aN/dgxTcJ964aCiI6Kg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 444uaguw0s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 19:50:44 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 50DJgqZt020111; Mon, 13 Jan 2025 19:50:44 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 444uaguw0q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 19:50:43 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50DGU2DS007385; Mon, 13 Jan 2025 19:50:42 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4443ymyu32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 19:50:42 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50DJofVP32244322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2025 19:50:41 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D51735805C; Mon, 13 Jan 2025 19:50:41 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 07FBB5805A; Mon, 13 Jan 2025 19:50:39 +0000 (GMT) Received: from [9.61.105.40] (unknown [9.61.105.40]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 13 Jan 2025 19:50:38 +0000 (GMT) Message-ID: <38f9a51d-0116-4ec4-b515-26038f91659b@linux.ibm.com> Date: Mon, 13 Jan 2025 13:50:38 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/10] bindings: ipmi: Add binding for IPMB device intf To: corey@minyard.net, Rob Herring Cc: minyard@acm.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ratbert@faraday-tech.com, openipmi-developer@lists.sourceforge.net, netdev@vger.kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, devicetree@vger.kernel.org, eajames@linux.ibm.com, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20250108163640.1374680-1-ninad@linux.ibm.com> <20250108163640.1374680-3-ninad@linux.ibm.com> <20250110160713.GA2952341-robh@kernel.org> Content-Language: en-US From: Ninad Palsule In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: -e7S3whLGUPEjVKglQj4-uLg1hX1hsz0 X-Proofpoint-GUID: UTKY78W8byq0kSk5ICb8m0CyqtOykedE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 lowpriorityscore=0 clxscore=1011 impostorscore=0 bulkscore=0 spamscore=0 mlxscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130156 Hi Corey, On 1/10/25 11:53, Corey Minyard wrote: > On Fri, Jan 10, 2025 at 10:07:13AM -0600, Rob Herring wrote: >> On Wed, Jan 08, 2025 at 10:36:30AM -0600, Ninad Palsule wrote: >>> Add device tree binding document for the IPMB device interface. >>> This device is already in use in both driver and .dts files. >>> >>> Signed-off-by: Ninad Palsule >>> --- >>> .../devicetree/bindings/ipmi/ipmb-dev.yaml | 44 +++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml b/Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml >>> new file mode 100644 >>> index 000000000000..a8f46f1b883e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml >>> @@ -0,0 +1,44 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/ipmi/ipmb-dev.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: IPMB Device >>> + >>> +description: IPMB Device interface to receive request and send response > First, thank you, this does need to be documented. Thanks for the review. > >> IPMB is not defined anywhere. > Indeed. At least reference the spec, but better do that and provide a > basic description. > >> Which side of the interface does this apply to? How do I know if I have >> an ipmb-dev? >> >> This document needs to stand on its own. Bindings exist in a standalone >> tree without kernel drivers or docs. > At least to someone who knows what IPMB is, it's pretty clear that you > are saying "The i2c device this node is in is on an IPMB bus." However, > to someone who is not, this is all a foreign language. This definitely > needs better documentation. > > Why do you have a "reg" property? I don't see it referenced in the > driver. I assume that's the I2C address, but that's going to be the > same as what's in the containing I2C node. I don't think it's > necessary. > > -corey I have improved the documentation in version 4. Please check. Regards, Ninad