From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89D0C433EF for ; Mon, 16 May 2022 10:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbiEPKNM (ORCPT ); Mon, 16 May 2022 06:13:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238546AbiEPKM7 (ORCPT ); Mon, 16 May 2022 06:12:59 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FA60B7CD; Mon, 16 May 2022 03:12:57 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24G8Q3tY008866; Mon, 16 May 2022 12:12:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=T3neJSagT9ebofvQRy/yu4nxh0z8Vb5jJwQsf3DtDvI=; b=wcCx/e9nQKIJpPaVKc7kuPUiBgduptNV9M/6IdhmiIQRvsLIrW4+wWfwOQz9AOJfaToV IHQSYMg0VxUWnyXuesRM1gx9ivIHCutZMh+V6WTDxCmdYs8XJaE1uq77MMNacm9S03DS y5ZopUxnVV1ty9ms/d/OKIXcL3Tnwl0QJQy3hPcRJOdbvNDPNqtC4fW3uVYSZeu9Lmw2 BB2pSy6S5VSIhtazzbcVX0VtR3BLd5dUioNSCJlZhvEPI/73uM/PHuylWhhMr7lR4y9Y vFWicaqU9pKbnK89ioLdVmnQrO8Tl12OprlxPWstN5P7ZSmruuZtp6SWeTExvFeScW4P ug== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3g21j8j969-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 May 2022 12:12:49 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1BADE10002A; Mon, 16 May 2022 12:12:49 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1214E2138D5; Mon, 16 May 2022 12:12:49 +0200 (CEST) Received: from [10.0.2.15] (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Mon, 16 May 2022 12:12:48 +0200 Subject: Re: [PATCH 3/3] media: st-mipid02: expose 1X16 serial pixel format To: Hugues Fruchet , Mauro Carvalho Chehab , Sakari Ailus , Sylvain Petinot CC: , , Alain Volmat References: <20220516091934.263141-1-hugues.fruchet@foss.st.com> <20220516091934.263141-4-hugues.fruchet@foss.st.com> From: Benjamin Mugnier Message-ID: <39016a6e-6e8d-d263-da9d-47f3bb13988f@foss.st.com> Date: Mon, 16 May 2022 12:12:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20220516091934.263141-4-hugues.fruchet@foss.st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-16_06,2022-05-16_02,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/2022 11:19, Hugues Fruchet wrote: > Expose RGB & YUV 1X16 serial pixel format variants to comply > with CSI-2 camera sensor pixel formats. > > Signed-off-by: Hugues Fruchet Reviewed-by: Benjamin Mugnier > --- > drivers/media/i2c/st-mipid02.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c > index fe884d81b08b..16cc547976dd 100644 > --- a/drivers/media/i2c/st-mipid02.c > +++ b/drivers/media/i2c/st-mipid02.c > @@ -62,7 +62,9 @@ static const u32 mipid02_supported_fmt_codes[] = { > MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10, > MEDIA_BUS_FMT_SBGGR12_1X12, MEDIA_BUS_FMT_SGBRG12_1X12, > MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SRGGB12_1X12, > - MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_BGR888_1X24, > + MEDIA_BUS_FMT_YUYV8_1X16, MEDIA_BUS_FMT_YVYU8_1X16, > + MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_VYUY8_1X16, > + MEDIA_BUS_FMT_RGB565_1X16, MEDIA_BUS_FMT_BGR888_1X24, > MEDIA_BUS_FMT_RGB565_2X8_LE, MEDIA_BUS_FMT_RGB565_2X8_BE, > MEDIA_BUS_FMT_YUYV8_2X8, MEDIA_BUS_FMT_YVYU8_2X8, > MEDIA_BUS_FMT_UYVY8_2X8, MEDIA_BUS_FMT_VYUY8_2X8, > @@ -132,7 +134,11 @@ static int bpp_from_code(__u32 code) > case MEDIA_BUS_FMT_SGRBG12_1X12: > case MEDIA_BUS_FMT_SRGGB12_1X12: > return 12; > + case MEDIA_BUS_FMT_YUYV8_1X16: > + case MEDIA_BUS_FMT_YVYU8_1X16: > case MEDIA_BUS_FMT_UYVY8_1X16: > + case MEDIA_BUS_FMT_VYUY8_1X16: > + case MEDIA_BUS_FMT_RGB565_1X16: > case MEDIA_BUS_FMT_YUYV8_2X8: > case MEDIA_BUS_FMT_YVYU8_2X8: > case MEDIA_BUS_FMT_UYVY8_2X8: > @@ -165,7 +171,10 @@ static u8 data_type_from_code(__u32 code) > case MEDIA_BUS_FMT_SGRBG12_1X12: > case MEDIA_BUS_FMT_SRGGB12_1X12: > return 0x2c; > + case MEDIA_BUS_FMT_YUYV8_1X16: > + case MEDIA_BUS_FMT_YVYU8_1X16: > case MEDIA_BUS_FMT_UYVY8_1X16: > + case MEDIA_BUS_FMT_VYUY8_1X16: > case MEDIA_BUS_FMT_YUYV8_2X8: > case MEDIA_BUS_FMT_YVYU8_2X8: > case MEDIA_BUS_FMT_UYVY8_2X8: > @@ -173,6 +182,7 @@ static u8 data_type_from_code(__u32 code) > return 0x1e; > case MEDIA_BUS_FMT_BGR888_1X24: > return 0x24; > + case MEDIA_BUS_FMT_RGB565_1X16: > case MEDIA_BUS_FMT_RGB565_2X8_LE: > case MEDIA_BUS_FMT_RGB565_2X8_BE: > return 0x22; > @@ -207,8 +217,16 @@ static __u32 get_fmt_code(__u32 code) > > static __u32 serial_to_parallel_code(__u32 serial) > { > + if (serial == MEDIA_BUS_FMT_RGB565_1X16) > + return MEDIA_BUS_FMT_RGB565_2X8_LE; > + if (serial == MEDIA_BUS_FMT_YUYV8_1X16) > + return MEDIA_BUS_FMT_YUYV8_2X8; > + if (serial == MEDIA_BUS_FMT_YVYU8_1X16) > + return MEDIA_BUS_FMT_YVYU8_2X8; > if (serial == MEDIA_BUS_FMT_UYVY8_1X16) > return MEDIA_BUS_FMT_UYVY8_2X8; > + if (serial == MEDIA_BUS_FMT_VYUY8_1X16) > + return MEDIA_BUS_FMT_VYUY8_2X8; > if (serial == MEDIA_BUS_FMT_BGR888_1X24) > return MEDIA_BUS_FMT_BGR888_3X8; > >