From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peter Yin <peteryin.openbmc@gmail.com>,
patrick@stwcx.xyz, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] ARM: dts: aspeed: Harma: Add Facebook Harma (AST2600) BMC
Date: Sat, 9 Dec 2023 11:39:26 +0100 [thread overview]
Message-ID: <390187fb-4ab4-49e6-b382-7be1fa117f01@linaro.org> (raw)
In-Reply-To: <20231206155316.4181813-3-peteryin.openbmc@gmail.com>
On 06/12/2023 16:53, Peter Yin wrote:
> Add linux device tree entry related to
> Harma specific devices connected to BMC SoC.
>
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> ---
...
> +&mac3 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>;
> + no-hw-checksum;
> + use-ncsi;
> + ncsi-ctrl,start-redo-probe;
> + ncsi-ctrl,no-channel-monitor;
> + mlx,multi-host;
There is no such property. Please stop copying downstream code into
upstream.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-12-09 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 15:53 [PATCH v6 0/2] " Peter Yin
2023-12-06 15:53 ` [PATCH v6 1/2] dt-bindings: arm: aspeed: add Meta Harma board Peter Yin
2023-12-06 15:53 ` [PATCH v6 2/2] ARM: dts: aspeed: Harma: Add Facebook Harma (AST2600) BMC Peter Yin
2023-12-07 0:10 ` Joel Stanley
2023-12-09 10:39 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=390187fb-4ab4-49e6-b382-7be1fa117f01@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=peteryin.openbmc@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®