From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Siddharth Chintamaneni <sidchintamaneni@gmail.com>,
akpm@linux-foundation.org, hannes@cmpxchg.org
Cc: david@kernel.org, mhocko@kernel.org, qi.zheng@linux.dev,
shakeel.butt@linux.dev, ljs@kernel.org, kasong@tencent.com,
baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com,
weixugc@google.com, baoquan.he@linux.dev, yuzhao@google.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
apais@microsoft.com, rlmenge@gmail.com,
Hardik Garg <hargar@linux.microsoft.com>
Subject: Re: [PATCH v1 1/2] mm: multi-gen LRU: use mem_cgroup_lruvec() in get_lruvec()
Date: Mon, 26 Oct 2026 10:31:24 +0800 [thread overview]
Message-ID: <39026bf7-83b6-4b8c-9d82-2a647fb9711a@linux.alibaba.com> (raw)
In-Reply-To: <20261021235606.89545-1-sidchintamaneni@gmail.com>
On 10/22/26 7:56 AM, Siddharth Chintamaneni wrote:
> Andrew Morton noted that get_lruvec() has the same pattern as
> lru_gen_shrink_node(): when memcg is disabled on the command line
> (cgroup_disable=memory), it returns &pgdat->__lruvec directly instead of
> going through mem_cgroup_lruvec(), which initializes lruvec->pgdat.
>
> In practice all callers of get_lruvec() run after kswapd_init() has
> already initialized pgdat->__lruvec.pgdat on every N_MEMORY node, so
> this is not a runtime bug. Have get_lruvec() delegate to
> mem_cgroup_lruvec() directly.
>
> Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
> Signed-off-by: Hardik Garg <hargar@linux.microsoft.com>
> ---
LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
prev parent reply other threads:[~2026-10-26 2:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 23:56 Siddharth Chintamaneni
2026-10-21 23:56 ` [PATCH v1 2/2] mm: multi-gen LRU: remove get_lruvec() Siddharth Chintamaneni
2026-10-26 2:35 ` Baolin Wang
2026-10-26 10:00 ` Barry Song
2026-10-26 2:31 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39026bf7-83b6-4b8c-9d82-2a647fb9711a@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=apais@microsoft.com \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hargar@linux.microsoft.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=qi.zheng@linux.dev \
--cc=rlmenge@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=sidchintamaneni@gmail.com \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®