From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbbJTJZN (ORCPT ); Tue, 20 Oct 2015 05:25:13 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:36747 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751694AbbJTJZI convert rfc822-to-8bit (ORCPT ); Tue, 20 Oct 2015 05:25:08 -0400 X-IronPort-AV: E=Sophos;i="5.17,706,1437462000"; d="scan'208";a="78185309" From: Anup Patel To: Sudeep Holla CC: David Woodhouse , Brian Norris , "linux-mtd@lists.infradead.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Catalin Marinas" , Will Deacon , "Ray Jui" , Scott Branden , "Florian Fainelli" , Pramod Kumar , "Vikram Prakash" , Sandeep Tripathy , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , bcm-kernel-feedback-list Subject: RE: [PATCH v2 4/4] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Thread-Topic: [PATCH v2 4/4] arm64: dts: Add BRCM IPROC NAND DT node for NS2 Thread-Index: AQHRB/JhXT2W/ExJcUOoOzoyxBZ03J50koaA//+Po3A= Date: Tue, 20 Oct 2015 09:25:05 +0000 Message-ID: <39063E8F96E11742B35A201CC5D095B7AF39AD@SJEXCHMB10.corp.ad.broadcom.com> References: <1444986537-28387-1-git-send-email-anup.patel@broadcom.com> <1444986537-28387-5-git-send-email-anup.patel@broadcom.com> <562603F7.7000202@arm.com> In-Reply-To: <562603F7.7000202@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.16.203.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Sudeep Holla [mailto:sudeep.holla@arm.com] > Sent: 20 October 2015 14:36 > To: Anup Patel > Cc: David Woodhouse; Brian Norris; linux-mtd@lists.infradead.org; Sudeep > Holla; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Catalin > Marinas; Will Deacon; Ray Jui; Scott Branden; Florian Fainelli; Pramod Kumar; > Vikram Prakash; Sandeep Tripathy; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; bcm-kernel- > feedback-list > Subject: Re: [PATCH v2 4/4] arm64: dts: Add BRCM IPROC NAND DT node for > NS2 > > > > On 16/10/15 10:08, Anup Patel wrote: > > The NAND controller on NS2 SoC is compatible with existing BRCM IPROC > > NAND driver so let's enable it in NS2 DT and > > NS2 SVK DT. > > > > Signed-off-by: Anup Patel > > Reviewed-by: Ray Jui > > Reviewed-by: Scott Branden > > --- > > arch/arm64/boot/dts/broadcom/ns2-svk.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/broadcom/ns2.dtsi | 14 ++++++++++++++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > index e5950d5..a754160 100644 > > --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts > > @@ -63,5 +63,17 @@ > > uart3: serial@66130000 { > > status = "ok"; > > }; > > Better to change even the above reference, see below. > > > + > > + nand: nand@66460000 { > > In most of the cases where such static overlays are done, I have seen the labels > being used to refer back the node. Using the complete node name again is kind > of inviting trouble as even minor typo results in creation of another node. Thanks for pointing. I will use label here for both uart3 and nand. Regards, Anup