From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755037Ab3IET4m (ORCPT ); Thu, 5 Sep 2013 15:56:42 -0400 Received: from mga02.intel.com ([134.134.136.20]:3781 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752633Ab3IET4k (ORCPT ); Thu, 5 Sep 2013 15:56:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,849,1371106800"; d="scan'208";a="374074804" From: "Luck, Tony" To: Linus Torvalds CC: Heiko Carstens , Linux Kernel Mailing List Subject: RE: [PATCH] lockref: remove cpu_relax() again Thread-Topic: [PATCH] lockref: remove cpu_relax() again Thread-Index: AQHOqjponYZ6pHUzoUeo27Wv6BHm9pm3utOA//+oSZCAAH9VgP//mtyggAB9vgD//5CLAAAO9roAAA6RDoA= Date: Thu, 5 Sep 2013 19:56:39 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F31CDCDB2@ORSMSX106.amr.corp.intel.com> References: <20130905131814.GA24274@osiris> <3908561D78D1C84285E8C5FCA982C28F31CDC7F7@ORSMSX106.amr.corp.intel.com> <3908561D78D1C84285E8C5FCA982C28F31CDCC23@ORSMSX106.amr.corp.intel.com> <3908561D78D1C84285E8C5FCA982C28F31CDCCFA@ORSMSX106.amr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r85JukHD032628 > That said, another thing that strikes me is that you have 32 CPU > threads, and the stupid test-program I sent out had MAX_THREADS set to > 16. Did you change that? Becuase if not, then some of the extreme > performance profile might be about how the threads get scheduled on > your machine (HT threads vs full cores etc). I'll try to get new numbers with 32 threads[*] - but even if they look good, I'd be upset about the 16 thread case being worse with the cmpxchg/no-cpu-relax case than the original code. -Tony [*] probably not till tomorrow ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«�éÿŠ{ayºʇڙë,j­¢f£¢·hš�ï�êÿ‘êçz_è®(­éšŽŠÝ¢j"�ú¶m§ÿÿ¾«þG«�éÿ¢¸?™¨è­Ú&£ø§~�á¶iO•æ¬z·švØ^¶m§ÿÿà ÿ¶ìÿ¢¸?–I¥