From: Alan Huang <mmpgouride@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: paulmck@kernel.org, Joel Fernandes <joel@joelfernandes.org>,
corbet@lwn.net, rcu@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Docs/RCU/rculist_nulls: Specify type of the object in examples
Date: Sat, 17 Jun 2023 01:46:16 +0800 [thread overview]
Message-ID: <390935BF-9EC0-4D88-A277-7B37D68CC6C7@gmail.com> (raw)
In-Reply-To: <20230615181004.86850-2-sj@kernel.org>
> 2023年6月16日 02:10,SeongJae Park <sj@kernel.org> 写道:
>
> The type of 'obj' in example code of rculist_nulls.rst is implicit.
> Provide the specific type of it before the example code.
>
> Suggested-by: aul E. McKenney <paulmck@kernel.org>
Paul E. McKenney
> Link: https://lore.kernel.org/rcu/43943609-f80c-4b6a-9844-994eef800757@paulmck-laptop/
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
> Documentation/RCU/rculist_nulls.rst | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/RCU/rculist_nulls.rst b/Documentation/RCU/rculist_nulls.rst
> index 94a8bfe9f560..4b66e2fd2fb5 100644
> --- a/Documentation/RCU/rculist_nulls.rst
> +++ b/Documentation/RCU/rculist_nulls.rst
> @@ -18,7 +18,16 @@ to solve following problem.
>
> Without 'nulls', a typical RCU linked list managing objects which are
> allocated with SLAB_TYPESAFE_BY_RCU kmem_cache can use the following
> -algorithms:
> +algorithms. Following examples assume 'obj' is a pointer to such
> +objects, which is having below type.
> +
> +::
> +
> + struct object {
> + struct hlist_node obj_node;
> + refcount_t refcnt;
atomic_t
> + unsigned int key;
> + };
>
> 1) Lookup algorithm
> -------------------
> @@ -142,6 +151,9 @@ the beginning. If the object was moved to the same chain,
> then the reader doesn't care: It might occasionally
> scan the list again without harm.
>
> +Note that using hlist_nulls means the type of 'obj_node' field of
> +'struct object' becomes 'struct hlist_nulls_node'.
> +
>
> 1) lookup algorithm
> -------------------
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-06-16 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 18:10 [PATCH v3 0/3] Docs/RCU/rculist_nulls: Minor fixup SeongJae Park
2023-06-15 18:10 ` [PATCH v3 1/3] Docs/RCU/rculist_nulls: Specify type of the object in examples SeongJae Park
2023-06-16 17:46 ` Alan Huang [this message]
2023-06-16 18:54 ` SeongJae Park
2023-06-16 23:18 ` Paul E. McKenney
2023-06-15 18:10 ` [PATCH v3 2/3] Docs/RCU/rculist_nulls: Fix hlist_[nulls]_head field names of 'obj' SeongJae Park
2023-06-15 18:10 ` [PATCH v3 3/3] Docs/RCU/rculist_nulls: Fix text about atomic_set_release() SeongJae Park
2023-06-16 16:52 ` [PATCH v3 0/3] Docs/RCU/rculist_nulls: Minor fixup Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=390935BF-9EC0-4D88-A277-7B37D68CC6C7@gmail.com \
--to=mmpgouride@gmail.com \
--cc=corbet@lwn.net \
--cc=joel@joelfernandes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®