Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

[Jarkko Nikula <jarkko.nikula@linux.intel.com>]

On 03/20/17 13:10, Luis Oliveira wrote:
> - The functions related to I2C master mode of operation were transformed
>   in a single driver.
> - Common definitions were moved to i2c-designware-core.h
> - The i2c-designware-core is now only a library file, the functions
>   associated are in a source file called i2c-designware-common and
>   are used by both i2c-designware-master and i2c-designware-slave.
> - To decrease noise in namespace common i2c_dw_*() functions are
>   now using ops to keep them private.
> - Designware PCI driver had to be changed to match the previous ops
>   functions implementation.
>
> Almost all of the "core" source is now part of the "master" source. The
> difference is the functions used by both modes and they are in the
> "common" source file.
>
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v6-v7
> - Moved kernel doc comments from patch 4/6 to this patch. @Jarkko
> - Fix Designware I2C PCI driver error when looking for previous extern
>   functions.
>
...
>   * struct dw_i2c_dev - private i2c-designware data
> @@ -78,7 +196,11 @@
>   * @acquire_lock: function to acquire a hardware lock on the bus
>   * @release_lock: function to release a hardware lock on the bus
>   * @pm_runtime_disabled: true if pm runtime is disabled
> - *
> + * @dynamic_tar_update_enabled: true if dynamic TAR update is enabled
> + * @disable: function to disable the controller
> + * @disable_int: function to disable all interrupts
> + * @init: function to initialize the I2C hardware
> + *
>   * HCNT and LCNT parameters can be used if the platform knows more accurate
>   * values than the one computed based only on the input clock frequency.
>   * Leave them to be %0 if not used.
> @@ -126,15 +248,31 @@ struct dw_i2c_dev {
>  	int			(*acquire_lock)(struct dw_i2c_dev *dev);
>  	void			(*release_lock)(struct dw_i2c_dev *dev);
>  	bool			pm_runtime_disabled;
> +	void			(*disable)(struct dw_i2c_dev *dev);
> +	void			(*disable_int)(struct dw_i2c_dev *dev);
> +	int			(*init)(struct dw_i2c_dev *dev);
>  };
>
I take my ack back. You are adding comment for 
dynamic_tar_update_enabled which was removed by the 12688dc21f71 
("Revert "i2c: designware: detect when dynamic tar update is possible"")

-- 
Jarkko