mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Noah (Wensheng) Wang" <Noah.Wang@monolithicpower.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Luke (Lijie) Jiang" <Luke.Jiang@monolithicpower.com>,
	"pebble liang" <pebble.liang@monolithicpower.com>,
	"Eva (Ting) Ma" <Eva.Ma@monolithicpower.com>
Subject: Re: [PATCH] char: add driver for mps VR controller mp2891
Date: Tue, 14 Mar 2023 11:20:31 +0100	[thread overview]
Message-ID: <390eefe7-c7c4-47b4-88f2-dcaa8bfaf8a8@app.fastmail.com> (raw)
In-Reply-To: <08e7bd6ed16f4bde95b674db940783ec@monolithicpower.com>

On Tue, Mar 14, 2023, at 10:18, Noah (Wensheng) Wang wrote:
> Hi Arnd, Grey:
> Thanks for the review.
>
> This driver will be used by facebook. This driver provide a device node 
> for userspace to get output voltage, input voltage, input current, 
> input power, output power and temperature of mp2891 controller through 
> I2C. This driver determine what kind of value the userspace wants 
> through the mp2891_write interface and return the corresponding value 
> when the interface mp2891_read is called.
>
> Signed-off-by: Noah Wang <Noah.Wang@monolithicpower.com>

Hi Noah,

From your description, this sounds like it should be either part of the
drivers/hwmon/ framework, or drivers/iio/, but not a custom character
device.

Have you looked at those?

      Arnd

  parent reply	other threads:[~2023-03-14 10:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  9:18 Noah (Wensheng) Wang
2023-03-14  9:22 ` gregkh
2023-03-14 10:20 ` Arnd Bergmann [this message]
2023-03-14 15:36 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=390eefe7-c7c4-47b4-88f2-dcaa8bfaf8a8@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Eva.Ma@monolithicpower.com \
    --cc=Luke.Jiang@monolithicpower.com \
    --cc=Noah.Wang@monolithicpower.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebble.liang@monolithicpower.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome