mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v2 01/16] dt-bindings: clock: mediatek: add missing required #reset-cells
Date: Wed, 7 Feb 2018 11:45:38 +0100	[thread overview]
Message-ID: <391278e5-9b72-1142-0262-5d286fe17d8d@gmail.com> (raw)
In-Reply-To: <d58fcf36319254d6de4c7fe100cbdca1bbec27a5.1517910489.git.sean.wang@mediatek.com>



On 02/06/2018 10:52 AM, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> All ethsys, pciesys and ssusbsys internally include reset controller, so
> explicitly add back these missing cell definitions to related bindings
> and examples.
> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt   | 2 ++
>  Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt  | 2 ++
>  Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt
> index 7aa3fa1..8f5335b 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt
> @@ -9,6 +9,7 @@ Required Properties:
>  	- "mediatek,mt2701-ethsys", "syscon"
>  	- "mediatek,mt7622-ethsys", "syscon"
>  - #clock-cells: Must be 1
> +- #reset-cells: Must be 1
>  
>  The ethsys controller uses the common clk binding from
>  Documentation/devicetree/bindings/clock/clock-bindings.txt
> @@ -20,4 +21,5 @@ ethsys: clock-controller@1b000000 {
>  	compatible = "mediatek,mt2701-ethsys", "syscon";
>  	reg = <0 0x1b000000 0 0x1000>;
>  	#clock-cells = <1>;
> +	#reset-cells = <1>;

The example is already fixed upstream, but I forgot the binding description,
please rebase this patch.

And please don't forget to add all clock maintainers.

Regards,
Matthias

  reply	other threads:[~2018-02-07 10:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06  9:52 [PATCH v2 00/16] add dts nodes to MT7622 SoC sean.wang
2018-02-06  9:52 ` [PATCH v2 01/16] dt-bindings: clock: mediatek: add missing required #reset-cells sean.wang
2018-02-07 10:45   ` Matthias Brugger [this message]
2018-02-09  3:38     ` Sean Wang
2018-02-06  9:52 ` [PATCH v2 02/16] arm64: dts: mt7622: add clock controller device nodes sean.wang
2018-02-06  9:52 ` [PATCH v2 03/16] arm64: dts: mt7622: add power domain " sean.wang
2018-02-06  9:52 ` [PATCH v2 04/16] arm64: dts: mt7622: add pinctrl related " sean.wang
2018-02-07 11:31   ` Matthias Brugger
2018-02-09  3:41     ` Sean Wang
2018-02-06  9:52 ` [PATCH v2 05/16] arm64: dts: mt7622: add PMIC MT6380 related nodes sean.wang
2018-02-08 14:46   ` Philippe Ombredanne
2018-02-06  9:52 ` [PATCH v2 06/16] arm64: dts: mt7622: add cpufreq related device nodes sean.wang
2018-02-07  3:33   ` Viresh Kumar
2018-02-07  6:16     ` Sean Wang
2018-02-07  6:18       ` Viresh Kumar
2018-02-07  8:34         ` Sean Wang
2018-02-06  9:52 ` [PATCH v2 07/16] arm64: dts: mt7622: turn uart0 clock to real ones sean.wang
2018-02-06  9:52 ` [PATCH v2 08/16] arm64: dts: mt7622: add SoC and peripheral related device nodes sean.wang
2018-02-06  9:52 ` [PATCH v2 09/16] arm64: dts: mt7622: add flash " sean.wang
2018-02-06  9:52 ` [PATCH v2 10/16] arm64: dts: mt7622: add ethernet " sean.wang
2018-02-06  9:53 ` [PATCH v2 11/16] arm64: dts: mt7622: add PCIe " sean.wang
2018-02-06  9:53 ` [PATCH v2 12/16] arm64: dts: mt7622: add SATA " sean.wang
2018-02-06  9:53 ` [PATCH v2 13/16] arm64: dts: mt7622: add usb " sean.wang
2018-02-06  9:53 ` [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes sean.wang
2018-02-07 11:43   ` Matthias Brugger
2018-02-09  3:51     ` Sean Wang
2018-02-12 11:55       ` Matthias Brugger
2018-02-06  9:53 ` [PATCH v2 15/16] arm64: dts: mt7622: add High-Speed DMA device nodes sean.wang
2018-02-06  9:53 ` [PATCH v2 16/16] arm64: dts: mt7622: add mmc related " sean.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=391278e5-9b72-1142-0262-5d286fe17d8d@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®