From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8770F3AFCFE for ; Wed, 10 Jun 2026 08:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781081738; cv=none; b=vE352CsTfBu5fDIQWppUXu4pHoJe9hWIy6L16nXlqJqYYB1DBbD6jJsmeDK1wBGdMCvmFBr115NmN8iqIZvcF15ZVdb6OsbeRTLCRvbFOJsLWYtQ5MIoA5f1Mx1TB1EgtItb9gl3mLWhW34WrocF1Mz4YJFxwsGqLo/TG1y+7tc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781081738; c=relaxed/simple; bh=hNijcgnkYPKA/7wrNZ59fyYQzhIfXIxHB80FcnuTr9E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O3jISzxzewQeRoS6NR3hHAlAfDXtHCwCfm2Xt3IoxF/IhDoxfwgXPPLLQylb9zOHc/qL1tFE7SZCntnNiWSOnhy4D7pDzQl4bvTw40GujvdDgYmn+Oj60J6nR0nqu682rMkGwjoG16flU5LwMAhh/rCsfSjgTY9imzvNsqcXcE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SpN2yX1z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LQHRRvfV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SpN2yX1z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LQHRRvfV" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A7i02C531853 for ; Wed, 10 Jun 2026 08:55:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lyYyxpnmdWgua+0JKg4PJ65ICvAFQSBiyXY6KNTh/ro=; b=SpN2yX1z/z1L1wf6 bUOtXfSSnjkphH+T0UHY7+r4KkyO6OX0EZ/EjIzNP54WdymfFjQbhhpeGsDgTPR4 iXQEh1yVoKjUnS4ngOXQHECyh0+F1KusGKDma/B4YGdFeJCA4alS9/RpT4VeUPpX VMbRr0IZAtP4QDBxB+YZDy1Kh26xJ1iU6eX+ExRDbdQhaUnp3ceZoRxvONcUElh4 YfZGNGEZ6PtUoXquvxsRStP4zXtWt2nPyUbmz8rBDbgQ6+MGNbLnSETbeHCeak/r 2am4Ewf0wMNNe3SDXIDK3IHXhRTqXQBmacJzxuxjDzpPtMKBWPQxjLYzL4kd7Weh jGBTVQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq0m1rysn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 08:55:36 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-517bdeceb54so7989881cf.2 for ; Wed, 10 Jun 2026 01:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781081736; x=1781686536; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lyYyxpnmdWgua+0JKg4PJ65ICvAFQSBiyXY6KNTh/ro=; b=LQHRRvfVIYXsQzLoUBp5XQMc+JeD4AnFM/+afq8GwuGWvLDCuuuAj0HGdxKde9t7oR KsUTtcv1fqA681ivIlWPn3XYLKuMxxpQc9iYQCtIPvIqqJz/zSnSwtuNLIbTs84vRgxW QTXqUPKVndBoiEOUlPu+eN6E7E7HZVrmtMsB7lRtAZhNVMKG9eKFyphgaauIOVU4Ib6T B2vQRToLq3IDtfTJMwC/WbsF6TvM6OirwrTNV5rkfWMLa9oS1x9tqhdeygawgxS0J5aT 99y+glNb+je6tx4jPon3LBXfVzZn8NdKcv4ghbDW2RDDVl2N0zXpFwhRAlnLN1/5DqPM mneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781081736; x=1781686536; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lyYyxpnmdWgua+0JKg4PJ65ICvAFQSBiyXY6KNTh/ro=; b=b81ypRSoRbNuGHsbUUCpkjwmUlDYNOELA/US4eAT1TbryKpK1kPwsKmnw/Zt94JegT x71zAEmMCRmflGYj89cSTCFIBUSCT5a1xqDc9W63j9iHo7UhBuUagcM7gI6Q1sprX+dw pAG/slP94x4rBen4mRAldJhFb4xdoGMrIJN/p4n9pLJFjBQvnUw3gDpA73cE83wYeJ6i PdjL4LddGnXgOxlJ7SgUHc408vANplqBsK4FNC8rHL+wZ1qW006Y0aeaXyrzbOKfP2Th hhMaex6AyRJQu5GiN4EpE7DpKSbutY7tM5t86/ZwPFqmo/zcVaRvDUekan9Y3bt98N1a Vbwg== X-Forwarded-Encrypted: i=1; AFNElJ9MPzHexJA7CA6a7g+KtXaG4o2aziT4aGZhgGQj4PkPPNvn3dQ8YuiT6+BpM8zjSZZaWqyMKb/auvZ2RUE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0tRBp50zr96aX7eRz/RpcWTuTrOs5i0VLqyuPFZEaG+gQBi+a lxGVGqNY14Tg3ZJec2DoQjiifhnHTCBJ5oyXZ5Pr8F7mAhARdc1eHgvWHhc/aQ5CgIKaevJWm7e 7fHEIi/9h3kgD7JYL8hfy5JUt6M7aMzvMkGzb+/fGZMMYAJnDSTgwc9Qr4NMSGfALy8Q= X-Gm-Gg: Acq92OH8k2zrGoohdU80xqZ3E0/hd3g2zI3wSjy80nG3JaCGazvsHVpPfn5LvjASgES tt55kEYLMMaKxmsq2L870+20G54hUzLNm1XJVGWYR83I1VqjFPS9nnDPb5eBCNciMzjB+pogaNL 4l2S+kJmKYFMhinYxMEtKIYWEFrukgZrontaVrvh31tq120VIUFH0khvaAXi7SVCFsLN9bll5lr JioHTNkAWHcSYH/aSZdTnrHOagnQ3SoEW0Dg5ENH1PW8KoMpbPtbtMQu+vpBmOAIuBVeDzuWOwN 9wr+XVTmsqCfC2uWKQsiO+jSwJacoGZTM5JSsV22yTHX57Q1buA/OqmunJcaqCPx8dbpyStwJJr 5fAkhBtmCMIEZtwLa7AGxu/Tsmf4ka0iq7nvhYyfJtI6ZAG9DPkSlwjIG X-Received: by 2002:a05:622a:2612:b0:50f:b9a6:82ae with SMTP id d75a77b69052e-517ca3313e8mr60735251cf.2.1781081735774; Wed, 10 Jun 2026 01:55:35 -0700 (PDT) X-Received: by 2002:a05:622a:2612:b0:50f:b9a6:82ae with SMTP id d75a77b69052e-517ca3313e8mr60734891cf.2.1781081735237; Wed, 10 Jun 2026 01:55:35 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf05176e1b5sm1154737366b.8.2026.06.10.01.55.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 01:55:34 -0700 (PDT) Message-ID: <39183dc1-5fb1-4dc6-a17b-e5aa48138602@oss.qualcomm.com> Date: Wed, 10 Jun 2026 10:55:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate To: Jie Luo , Kathiravan Thirumoorthy , george.moussalem@outlook.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260521-ipq5018-cmn-pll-rate-fix-v2-1-04b28a92e0f2@outlook.com> <9ab1340d-72bb-48df-8784-a584a37b5c76@oss.qualcomm.com> <91117dd7-91e1-4c1a-934e-1b6717698377@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <91117dd7-91e1-4c1a-934e-1b6717698377@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA4MyBTYWx0ZWRfX+kx0aFpEBXLM RXvdV9FiyOnZTECdDXqlnD6y15ZJYgp0ygnTMnxvbC+SehjbbNL2dReEdBmkfi73EUMinBL0sFU 6spPe800YzLdoJyooay1zdew6LIPPZ+2rtvu0FNRSSFgKL9zNUAB7LtNQ4BQlVI3k+RBdXpeZwL pMWGj/K7fzvVc0WiiGVmKlfD03ENL7wzF0yA+A4SZP49oC8lmxxaaanz8m8RIsfZORvLni/rTDe vQfSsU5Du4A4a751tFIwiW+v0JolFHB2KDBq2e5Eg8GNJKZFeYU5R8tnQtwCIzit0Iqol4fcbHL tX+EXmRm1zmrZU+Og0di04DR0ziEKGl+1n61NdzrlcNQF3TTrEv06Ruofxj81XbBPqO5Cco/x9y fo1PG4kJFFShCXVDM1dhgyadqog9EotPynvRzCAsf4Db37YdGTwyuMK3ihGSgG4KM+rvUYrvWEm zMwzlZZ2LFI42BNoV9A== X-Proofpoint-GUID: qJ9rC3WXHZhv_nueHOLgu-oY8_SyqFOX X-Authority-Analysis: v=2.4 cv=UdJhjqSN c=1 sm=1 tr=0 ts=6a292688 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=bC-a23v3AAAA:8 a=UqCG9HQmAAAA:8 a=EUspDBNiAAAA:8 a=3wsk7ZOv9uQ9785ZvD8A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-ORIG-GUID: qJ9rC3WXHZhv_nueHOLgu-oY8_SyqFOX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100083 On 6/10/26 5:10 AM, Jie Luo wrote: > > > On 6/10/2026 12:59 AM, Kathiravan Thirumoorthy wrote: >> >> On 6/9/2026 8:42 PM, Konrad Dybcio wrote: >>> On 5/21/26 9:55 AM, George Moussalem via B4 Relay wrote: >>>> From: George Moussalem >>>> >>>> The correct CMN PLL reference clock rate for IPQ5018 is 4.8 GHz. >>>> >>>> The CMN PLL driver did not account for the ref clock divider which is 2 >>>> for IPQ5018. Therefore, the computed rate was twice the actual output. >>>> >>>> With the driver now accounting for the CMN PLL reference clock >>>> divider (commit: 88c543fff756), set the correct reference clock rate. >>>> >>>> Fixes: c006b249c544 ("arm64: dts: ipq5018: Add CMN PLL node") >>>> Signed-off-by: George Moussalem >>>> --- >>>> Changes in v2: >>>> - Removed line break in commit message between Fixes and SOB tags >>>> - Link to v1: https://patch.msgid.link/20260519-ipq5018-cmn-pll-rate- >>>> fix-v1-1-3c83a173c27f@outlook.com >>>> --- >>> I have no reference for this, but I trust you.. maybe +Kathiravan >>> could double-check >> >> Thanks Konrad. As per the HW doc and the commit 88c543fff756 ("clk: >> qcom: cmnpll: Account for reference clock divider"), default ref clock >> divider is 1 in IPQ5018. >> >> @Jie, Can you help here? >> > > Hello Konrad, Kathiravan, > As confirmed on the IPQ5018 RDP board, the ref clock divider is set to 2. Thanks Acked-by: Konrad Dybcio Konrad