mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bean Huo <beanhuo@iokpp.de>
To: Arnd Bergmann <arnd@arndb.de>,
	Jens Wiklander <jens.wiklander@linaro.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	avri.altman@sandisk.com, Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	 can.guo@oss.qualcomm.com, Bean Huo <beanhuo@micron.com>,
	 linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] scsi: ufs: core: Fix link error when CONFIG_RPMB=m
Date: Tue, 02 Dec 2025 16:57:41 +0100	[thread overview]
Message-ID: <391c97e5201d73438ec506b22c4724285d676697.camel@iokpp.de> (raw)
In-Reply-To: <a2addffc-6f7a-4313-a8a4-dbce2a18a2cb@app.fastmail.com>

On Tue, 2025-12-02 at 16:47 +0100, Arnd Bergmann wrote:
> > > Any module that links against exported RPMB symbols should have
> > > the 'depends on RPMB || !RPMB' line to enable linking correctly.
> > > The RPMB implementation in drivers/misc on the other hand has no
> > > link-time dependency I can see, and enabling it without one of
> > > the other symbols simply means that there is a module that does
> > > nothing.
> > 
> > I have added this option in my previous email, can you add which one you
> > prefer.
> 
> You suggested:
>  "1. Make RPMB not directly depend on SCSI_UFSHCD in Kconfig then,
>    Use "depends on RPMB || !RPMB" in SCSI_UFSHCD (like MMC does)"
> 
> but I think we should go a step further and remove the
> 'depends on MMC' as well for consistency. Otherwise you create
> a dependency chain that makes it impossible to have UFSHCD
> built-in if MMC is a loadable module.
> 
>     Arnd

Thanks, Just sent a new patch and CC you, please check.


Hi Martin, Bart, and Jens,

Following our discussion and Arnd's suggestion, I've submitted a new patch that
takes a different approach to fix the RPMB link error.

Martin, the new patch should handle your modular build configuration correctly
while fixing the reported link error.

Thanks for all the feedback.

Best regards,
Bean


  reply	other threads:[~2025-12-02 16:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-30 15:15 Bean Huo
2025-12-01 17:25 ` Martin K. Petersen
2025-12-01 22:42   ` Bean Huo
2025-12-02  0:53     ` Bart Van Assche
2025-12-02  9:12       ` Bean Huo
2025-12-02 11:41         ` Jens Wiklander
2025-12-02 12:17           ` Bean Huo
2025-12-02 13:17             ` Jens Wiklander
2025-12-02 13:25               ` Arnd Bergmann
2025-12-02 14:59                 ` Bean Huo
2025-12-02 15:47                   ` Arnd Bergmann
2025-12-02 15:57                     ` Bean Huo [this message]
2025-12-02 14:17               ` Bean Huo
2025-12-03  6:15 ` kernel test robot
2025-12-03 14:39   ` Arnd Bergmann
2025-12-03 16:23     ` Bean Huo
2025-12-03 20:31       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=391c97e5201d73438ec506b22c4724285d676697.camel@iokpp.de \
    --to=beanhuo@iokpp.de \
    --cc=alim.akhtar@samsung.com \
    --cc=arnd@arndb.de \
    --cc=avri.altman@sandisk.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=can.guo@oss.qualcomm.com \
    --cc=jejb@linux.ibm.com \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®