From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3897F493627 for ; Sun, 23 Aug 2026 12:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787487827; cv=none; b=sVLfxWmeNRRu8SCIWfnlqlI2+5Qz4FX+Ubf4vUWxVvjzRS7bWH/W/2xx9xLu6xtQmBValC0glxDomCPLvqkNqyHHK9IykWCpL8Jl9HgLlkfsqT5pAknwC92ZVjWiLqeGogtOtDGYbC5VC4ECvmgLzSEFwWNVMZsQskfMoNi8ZDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787487827; c=relaxed/simple; bh=w+d9w1cHPKcUEvNAsFTO0hwvEvTQddz2PQ04qaQqf34=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N6rXva/WaXsm9XDFavd9Rl1tPct46irrhvJKjTTDA+g7XBcP4wg3l4w4n6UVvdl75xNe3vqsmF2NValZZYAC6W0TT6Lk1+XXClTudB0vVDT9ASAQKjELLMI1HFbIQ/OyjjiJ+7Y0vItfdPlCvTOfz5pSA7QwxWgveTN2IOiP1jQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h1M/ExT1; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h1M/ExT1" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84faf87d19dso2529509b3a.3 for ; Sun, 23 Aug 2026 05:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787487825; x=1788092625; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YRPHlf237WPmPMbjSWkUAAAD3V69PehMi7CL3D6QNGM=; b=h1M/ExT1GBvBKaEDIyOt51itmQxTo3RaQPpKqTa43gNJqtlgH04jHi5gh5zoM1S6n1 A5SLhYrrOLvJdy5rQoRvjo8Kz9BUTVhqoEaKFXMjOny0z4jjSdnuQGrmBx22uBnwW7MU DsGHlpOND8jWBmQITXMsAZykkR5qxx1AQSHMxKcGMjNIqu3ZZTgnNXlqwVvDa+pB3giA +apv8wrM6H8Bwzp5fiZtmk10ZmfY9SRZ+/vz+MPUU0UCW4olbOoz3+7nkO9IsKUGgEQe RZOWP1QQ8tmlxi/i3oXupotIsVd8/7qZK3MrUTFA97Wp9jFeMej+4k+ApqSxhMmcMrV0 53lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787487825; x=1788092625; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YRPHlf237WPmPMbjSWkUAAAD3V69PehMi7CL3D6QNGM=; b=BVtj4axlreQOsEYZrIj+dZyiv9E57MUTg+GeuHNDKNQsij/gPmjANOPaGQzVJxfSXu TYOA/1vlRvObYNbbUrNFUFZWWhom5yQNLdaI/PArbM0AUiERdaVJuMG5ZR3o9EZhQ2uP fgCFnYu9vlSzmHadY3HtFB+YSZ/V4dtUuu9h/BqFEdT2oDHuIUHphBiUPWPHr0iIDXY1 78Zh+9RnGeqbWT3Ch8znbZ225P+TWdbWvDphW1mWRzzfdv4yN3v6xy9XdykWxha0LIPH epRmIibkS3uNXGIIDW+o/pR3xkqHzc0FTktGwJCyIt1oHn51FxHMeZda0C4X8lTeaU3d QDOg== X-Forwarded-Encrypted: i=1; AHgh+RoQIJDnM7E47bRPvPEBrhpATr5UnpUhHetJKEgi+yUnL2fxPovR3/pWbwZyQ6RLjbMZa2Bo1izb4w0ODhM=@vger.kernel.org X-Gm-Message-State: AFuF++lsHZlOL7B3Uhn08HNhHp0y8GtfeB/P+KvX9wcwu5Ah5gW8CNUT adim5GYop4+F9uCVuo+YmqC+yU5SLrE+8owrU9+9cSUyKx4MzD/sn97E X-Gm-Gg: AR+sD13MhVltMKY6bRTEdG1SKE3NS+DiV5YUsrO+UHyfpPbFzulVmzRrSOzYEaKoh1K kiWLtMNK66kFDtHKU4wmYMUqqrnQt276jb0wrOFiFaAdM1eyP/t27bVeDiZnAcjE8989FM7PPsk zHKVXYH91kBUuZyHx3ChjZ3iMkPcog8uIxY7WFL8qWENdrX7jzlfQFBghNkp3Q5FEGP/20LOsMj 1WACUCRwOa/oHcmfDan2ayfj0N8fCccU4rtyR9dh0gGtCv4jDsZdKQX+lqB+WTiaLFJxCaS73q+ /Vsre477fMUxMzAbjc1pjcfUveE1FUPz8dFoT8yucQCBrMYxOL0QLa+Kzo14ip3094GLQqaWa79 /wjbKypf0qrAgZVb5H6T2kz0VRQLJxFh6tHDE18f7cAMSJv8If5CGIqxPHk1EZwgwgd2Ui5TgT5 lVJ9VfmB6zK3CKzQCHwXTGy6NVk88xH7bjWxmHRLxiv7PBvj9Eu03pdcitSvb/7MPB8m9PKQ== X-Received: by 2002:a05:6a00:1808:b0:84f:a170:4f5b with SMTP id d2e1a72fcca58-8520b984b8dmr18042074b3a.8.1787487825439; Sun, 23 Aug 2026 05:23:45 -0700 (PDT) Received: from [192.168.90.3] ([175.235.236.90]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc199e4b2e3sm254715a12.16.2026.08.23.05.23.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Aug 2026 05:23:44 -0700 (PDT) Message-ID: <391eb22c-e893-4c0d-a4ae-d603d568b12b@gmail.com> Date: Sun, 23 Aug 2026 21:23:42 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] usb: xhci-pci: Add AMD 600 series to xhci-pci-prom21 To: Stephen Horvath , Mathias Nyman , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shyam Sundar S K References: <20260820-xhci-pci-prom21-v2-1-638e5958fbbf@stevetech.au> Content-Language: en-US From: Jihong Min In-Reply-To: <20260820-xhci-pci-prom21-v2-1-638e5958fbbf@stevetech.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 8/20/26 21:59, Stephen Horvath wrote: > It seems the xhci-pci-prom21 module only has IDs for the 800 series > chipsets. However, the 600 series chipsets also have Promontory 21 > chips, so we should add their IDs to the list as well. > > I have tested this on my X670 board featuring DID `0x43f7`. > > `1022:43f7` also appears on the PCI ID database > (https://pci-ids.ucw.cz/read/PC/1022/43f7). > Device IDs `0x43f9` (B665) & `0x43fa` (A620) were suggested by Shyam. It would be nice to update all the newly added device IDs to the kernel documentation as well. > > Cc: Shyam Sundar S K > Cc: Jihong Min > Signed-off-by: Stephen Horvath > --- > Changes in v2: > - Added Device IDs `0x43f9` & `0x43fa` > - Link to v1: https://patch.msgid.link/20260818-xhci-pci-prom21-v1-1-6584857e654d@outlook.com.au > --- > drivers/usb/host/xhci-pci-prom21.c | 3 +++ > drivers/usb/host/xhci-pci.c | 3 +++ > drivers/usb/host/xhci-pci.h | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/drivers/usb/host/xhci-pci-prom21.c b/drivers/usb/host/xhci-pci-prom21.c > index 6486f4a09345..5f088a47d79f 100644 > --- a/drivers/usb/host/xhci-pci-prom21.c > +++ b/drivers/usb/host/xhci-pci-prom21.c > @@ -111,6 +111,9 @@ static void prom21_xhci_remove(struct pci_dev *dev) > } > > static const struct pci_device_id pci_ids[] = { > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) }, > { /* end: all zeroes */ } > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index a8889081ae82..b407676808fc 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -701,6 +701,9 @@ static const struct pci_device_id pci_ids_renesas[] = { > > /* handled by xhci-pci-prom21 if enabled */ > static const struct pci_device_id pci_ids_prom21[] = { > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9) }, > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) }, > { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) }, > { /* end: all zeroes */ } > diff --git a/drivers/usb/host/xhci-pci.h b/drivers/usb/host/xhci-pci.h > index 11f435f94322..533efc7db801 100644 > --- a/drivers/usb/host/xhci-pci.h > +++ b/drivers/usb/host/xhci-pci.h > @@ -4,6 +4,9 @@ > #ifndef XHCI_PCI_H > #define XHCI_PCI_H > > +#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7 0x43f7 > +#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9 0x43f9 > +#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA 0x43fa > #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC 0x43fc > #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD 0x43fd > > > --- > base-commit: e1e6e541c5c9cf548e9fdc35fc26808c82074440 > change-id: 20260818-xhci-pci-prom21-ceb025d484a8 > > Best regards, > -- > Stephen Horvath > Sincerely, Jihong Min