mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Wensheng Wang <wenswang@yeah.net>,
	Guenter Roeck <linux@roeck-us.net>, Noah Wang <wenswang@yeah.net>,
	linux-hwmon@vger.kernel.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: re: hwmon: add MP2925 and MP2929 driver
Date: Fri, 26 Sep 2025 15:17:02 +0100	[thread overview]
Message-ID: <391ee227-54e2-475c-9811-710fa22687ef@gmail.com> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 953 bytes --]

Hi,

Static analysis on linux-next has found an issue in function 
mp2925_write_word_data with the following commit:

commit b3a4efc88601cb5fc97b4ae23c478700a60302da
Author: Wensheng Wang <wenswang@yeah.net>
Date:   Thu Sep 18 16:06:03 2025 +0800

     hwmon: add MP2925 and MP2929 driver


The issue is as follows:

         case PMBUS_VOUT_OV_FAULT_LIMIT:
         case PMBUS_VOUT_UV_FAULT_LIMIT:
                 ret = pmbus_write_word_data(client, page, reg,
                                             (ret & ~GENMASK(11, 0)) |
                                 FIELD_PREP(GENMASK(11, 0),
                                            DIV_ROUND_CLOSEST(word * 
MP2925_VOUT_OVUV_DIV,
  
MP2925_VOUT_OVUV_UINT)));
                 break;

The call to pmbus_write_word_data() is accessing variable ret via the 
mask ~GENMASK(11, 0) however at this point ret has not been initialized 
so it contains a garbage value.

Colin

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

             reply	other threads:[~2025-09-26 14:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 14:17 Colin King (gmail) [this message]
2025-09-26 16:12 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=391ee227-54e2-475c-9811-710fa22687ef@gmail.com \
    --to=colin.i.king@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wenswang@yeah.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®