From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBD023C3450 for ; Wed, 18 Mar 2026 18:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773859171; cv=none; b=QWtjKziBnpURHWzOn6jMTopX4lYZCwV2krEz6R4Nkzu9wDsCRSHeRI3QVY7jHsM+zkuOFE0e3EifH6HRpSUIB0BlFMmCae7zBKZD83I7w8q2FweuOkQcDWsRVO9t2JDSQYMr0w2dxi1zyO90LWwh3QgCXJ5F/tm6lCXZJGrX7fM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773859171; c=relaxed/simple; bh=OhK95wo/LYj7R7tzUElFwcUK2IiZRunuZ2g5LeCSFgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lBPLG7CpgnPSfLVeJFGYZOHaWVd+0a62dq4BmedIvqT6hbIKFo3MrCWZIF83EJ0vRxLU9YnHzWNmnxlqE2eCVn3XHe3ucCMJl6emTx0zF9kC1Qq9I7Eb3YVUxutlaAHDgjOQbPcS6yMzxWSu8l8PWdDN5r3YDWvaygqYW7D9cHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bVNAOC3L; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bVNAOC3L" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-126ea4e9694so482427c88.1 for ; Wed, 18 Mar 2026 11:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773859170; x=1774463970; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=15qwLCeSSBieP/miy+9XAN8j6MaIvEBFpVF+G71Ltsk=; b=bVNAOC3LMkaSUxzdQkPMaC6DqNNji7u439ThmPbwIepGZhL6MeiLrWp06HYXC9dfAf uV5X2rOL2mAwBwSlxRMWj7O3nhpBzrbaRMZWNd5PArmLRn4ZRAaih1WHptqFsKvJDtZi GjwSmJ8HHCzUzSADP2syuJgdVNLi+l1PgW+XUtRSaGF/3PCe7gm4ty5ieiPWpMG9NyFp UOiD7OZp0mucNBpPz7Q1E0x+BCyqtbxsUjpNwn9jrpnvQaiEXRWDlQLX7tonBiDBb7DH B983bP7ind2F94qIAgfCb1Fx3QtrdrYWl09H+pkKw9xaw4m8Iee7wJtgiVsw/EB2H9eB 49ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773859170; x=1774463970; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=15qwLCeSSBieP/miy+9XAN8j6MaIvEBFpVF+G71Ltsk=; b=cRBxRaapjFCqklhXsI90rlsXnw8nWMb+O6qpoIr/XXKCapB6sIKGRXcib3qc+oXN9b QcgqDGfkfteYkVh0Ta3+Tx29wMvyFCMr4agHoEZ9z+PEBMYGXBKZUAm633MiF6NsjkTF Sv26cANoT5JeMAP/xNB3wAdJm8qnA2TeVorJJysO8gKiVNkZ+E3+OKvPfy5FcRnFL1H3 dOlQo3by5URRat2fS7cDV3k768G9OPanWr3Rpa7FpnaHDchgnJMj05XOgB4vH5C5dBFb 1xdbSC5Wv6n5ow+k/YICiE0MD/VTme4+lXKZHTcwIGHgxYXr7TUmTRJS5Ti5Qsc+c7Km 2Aqg== X-Forwarded-Encrypted: i=1; AJvYcCWVQVEfZ83GMyavxObleO9ZR2YbKsTFslkSHByTjobS4T9tfQzRFb9dWh2+00fBDStByf2x2Ak0rbdxvdo=@vger.kernel.org X-Gm-Message-State: AOJu0YxWscW76KRiiDqfR1sqG8slDddOH5GJyPDsZRGuddcBPzb+87NZ VKuXAgjS09vajqvH8gmB2psy+CLWCTZKk9ZkDDPReu0xMDChNnfC3xVq X-Gm-Gg: ATEYQzyKwe9i03VyuvXkczdjlEoxJNsKKb9N3nvYU6Zb2s3MQVkswhQzQAMeRm+xPHF y/EjrS/+AsmbCNNn7bwKrozLw7/FssG1QWvMXyi2/iZ4FNc5gBuFWXigsjMQ6oakRbTioQnuGxo h90ghM95w+jhvrKbPsI+4QqJudLIcP8PIdoDxjIl6UHsnZfIYiLMj1RR/jNbFMlUpJ4uXlgA+tG 3h6tJrKuFRUaPTS7jo2qUcenm1HBp2bvXB74Ylpry+oTZz0589oIa7ObufeKnPGFNTj+U2WlsHd R6zmhw1Fi1RzUvESQ9+9D2NhEOiIglHAnA/A8lfRApl3bPwWT7hU47XdR92HUB4/t843AiS0PFF P//1TsFbQwi392V4MPad5GkbDfPvGuwvhyLZvpeV/A04fWsHYvS3tGNpymP04BKUI4k+7/ZqLmh NxJJD8D2mfPtINPWI7+ZGZx8OsVsUe/wWAqQPVTWNffb/zfytd2oYIadI9eJl0CQIx4/QWXsIPM 0moOA== X-Received: by 2002:a05:7022:2507:b0:11a:3483:4a87 with SMTP id a92af1059eb24-129a70e09ddmr2437571c88.13.1773859169868; Wed, 18 Mar 2026 11:39:29 -0700 (PDT) Received: from [192.168.68.65] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129a72562bcsm4285798c88.5.2026.03.18.11.39.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 11:39:29 -0700 (PDT) Message-ID: <39226c91-a7a7-4f9e-a10f-4c3ddafeb432@gmail.com> Date: Wed, 18 Mar 2026 11:39:28 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash To: David Heidelberg , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260306-expressatt_camera_flash-v1-0-b1996f7cdfdd@gmail.com> <20260306-expressatt_camera_flash-v1-3-b1996f7cdfdd@gmail.com> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/7/26 00:23, David Heidelberg wrote: > On 07/03/2026 01:58, Rudraksha Gupta via B4 Relay wrote: >> From: Rudraksha Gupta >> >> Add camera flash support for the Samsung Galaxy Express (expressatt). >> >> The flash IC uses a one-wire pulse-count protocol on GPIO 3, gated by >> PMIC MPP 4 which must be driven high to unlock the flash circuit. >> >> Downstream references: >> Link: >> https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/drivers/leds/Makefile#L51 >> Link: >> https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/arch/arm/mach-msm/board-apexq-camera.c#L591 >> >> Signed-off-by: Rudraksha Gupta >> --- >>   .../dts/qcom/qcom-msm8960-samsung-expressatt.dts   | 31 >> ++++++++++++++++++++++ >>   1 file changed, 31 insertions(+) >> >> diff --git >> a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts >> b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts >> index c4b98af6955d..96460775a4ec 100644 >> --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts >> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts >> @@ -1,5 +1,6 @@ >>   // SPDX-License-Identifier: GPL-2.0 >>   #include >> +#include >>   #include >>     #include "qcom-msm8960.dtsi" >> @@ -61,6 +62,20 @@ touchkey_enable: touchkey-enable { >>           regulator-boot-on; >>       }; >>   +    camera_flash: led-controller { >> +        compatible = "richtek,rt8515"; >> +        enf-gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>; >> +        unlock-gpios = <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>; >> +        pinctrl-names = "default"; >> +        pinctrl-0 = <&cam_flash_en>; >> + > > LGTM, just please order pinctrl-n before pinctrl-names :) > > Reviewed-by: David Heidelberg > > Nitpick: if you can, add phone-devel@vger.kernel.org for next time, > it's easier to distinguish the phone patches in huge linux-arm-msm > pile :) Hello David, Thanks for your comments! I have addressed them in v2 :) Rudraksha > > David >