From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D00E784B0 for ; Mon, 2 Oct 2023 10:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236548AbjJBKtC (ORCPT ); Mon, 2 Oct 2023 06:49:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236495AbjJBKtA (ORCPT ); Mon, 2 Oct 2023 06:49:00 -0400 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2120B0 for ; Mon, 2 Oct 2023 03:48:55 -0700 (PDT) Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4Rzd3h1N5yz9shG; Mon, 2 Oct 2023 12:48:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1696243728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aKQIXYEpE/9OswE+cL5Gpii4j2iJ/oBrPTa1hkC9W2Q=; b=Lu8JYA6L58FS3IbDEJ95v5ZZAHqVj2M/9SqMC880LS5F1ZHqlt6GyE1lEaOtqYnfLkhrLG cH1P1LPiqTBQcJWBIaoqINbqqaLk/6wgGu3CfSTZIrDjO7TWhLHpfuaQ7w0beJBH8NkneN GW8cD5NhEc96hCbus98+hlkwnpN8eeB1tT8K0o6BEOBtOx014gCm5j+SouRs7nc7yMfn+i ZyITZ/P+JF04AX8Ao/NdJk/fnTLhUs5Xefg2tUfOAqcQ++xcdq/1T9Qibl5KCthewHxXkv EZyUDkNDrUegtclxKvTFGUK8m2uDlRrDI74XzCSSGpUZmRtHkGeJz2ra9lg/HA== Message-ID: <39342931-1716-bf53-62d7-613b1191f60a@mailbox.org> Date: Mon, 2 Oct 2023 12:48:44 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor" Content-Language: en-CA To: Hamza Mahfooz Cc: Stylon Wang , Ivan Lipski , Leo Li , Harry Wentland , Qingqing Zhuo , "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Hung , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Aurabindo Pillai , Hersen Wu , amd-gfx@lists.freedesktop.org, Daniel Vetter , Wayne Lin , Alex Deucher , Srinivasan Shanmugam , David Airlie , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20230929204120.120795-1-hamza.mahfooz@amd.com> <2a8ebf1a-0d74-e068-6d68-de0ecae9bdf1@mailbox.org> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= In-Reply-To: <2a8ebf1a-0d74-e068-6d68-de0ecae9bdf1@mailbox.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MBO-RS-META: 4wx17h8uorgrg4ynpwwk343ayfcp7oii X-MBO-RS-ID: c5a17bc6f1869c534c6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/23 12:05, Michel Dänzer wrote: > On 9/29/23 22:41, Hamza Mahfooz wrote: >> From: Ivan Lipski >> >> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. >> >> Since, it causes the following IGT tests to fail: >> kms_cursor_legacy@cursor-vs-flip.* >> kms_cursor_legacy@flip-vs-cursor.* > > Any information about how those tests fail? Maybe they accidentally rely on the broken behaviour? I was able to reproduce, that doesn't seem to be the case. They just rely on multiple legacy cursor ioctl calls being able to complete between consecutive flips, which I suppose is broken by always pulling in non-cursor plane state with any cursor plane state changes. I'll see if I can find a better solution. Meanwhile, Acked-by: Michel Dänzer for the revert. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer