From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA591DFE16 for ; Fri, 6 Dec 2024 10:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733480987; cv=none; b=j5WPpqXwu1g6pax6niAHQUth44wEXEVH8BB4L5DRxn04ts5h0KxuO6GyYDrV81hOdOo7tBLU8JJi8g0Xb3rINIwUDT6SNmT+z52xxGl6exhQ0yGWc4PzovNZDMVM/EhOgxLvAQPjiL3ocAa/DEnim4CjSgCmPglZFo3qNr20p00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733480987; c=relaxed/simple; bh=BfxBvifZQCyX7xwNcJVjx+TU4Bcyv0z19YZBs621YVA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B2aqKhVOY9ztXj3BcOw2zEDl1PE2S/Ze/mfbE1RyPeCsKlax34ZEb1NV4M7B69Gj3rgjRfKtRWiQcbvTSxUl3itrHzfo0TYW7sn5bn3yDQS+bWG2OAv7MbGwnXBloI/8i4m90qbA9GB4Gf6oTyiheQ5DlMNnrTyURkFoCijseEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MWCPZpAl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MWCPZpAl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733480984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=crTYWyzn/Re/2TqoIVaf4Q+WwdJ5ddEgtTEzXUyKEso=; b=MWCPZpAlcyDmnAKLpzYWQInDA414WIhnhF10bbj9/wqTrOHe14am+THT0I+3G2qA4amdrd byYUssopNeH5IAtjDVLIjxbcBKyET1AOn4Cr5RecdHQIt1jnU403jJhScd6MF8jN16ueZV XBtmyy8zyukgM0pBQacoKIWaFIUGrPM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-3-rpXOaxPY-d_jDT1t0jeA-1; Fri, 06 Dec 2024 05:29:42 -0500 X-MC-Unique: 3-rpXOaxPY-d_jDT1t0jeA-1 X-Mimecast-MFC-AGG-ID: 3-rpXOaxPY-d_jDT1t0jeA Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385e49efd59so807158f8f.0 for ; Fri, 06 Dec 2024 02:29:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733480981; x=1734085781; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=crTYWyzn/Re/2TqoIVaf4Q+WwdJ5ddEgtTEzXUyKEso=; b=ZnUnDdqMwGnnbbdcwRhHEXdEcn29euGxL7e9LC662Q7NPPaRZTB7y0gIT37ZWfnSms 0Cb1aLAR2F7zbIplrTAUiXwdjWglvxd3/fU2e87pDTx82WaZ20F3iwXwW/HCNRxjgn3Y fxHtEQuCYq3AcxERx22B7Tlbvs76njo7Pit9DDhrb8OLeTBxLX5M/7x02jNnUU0dz5Nd Tx3tQYIM3xe6AdsS17EpJdctK7JWfBaHYj0nMEN48inpjlPaQU4/jIpZ4dtmoxDch+DG 0UdCw08X5QUiopMsldUfE/DkfevJ61nZIZOovz+tIZ7vlpO2Qxo2N4tBmo00B7VJD1Up 7T7Q== X-Gm-Message-State: AOJu0YwKyxGe+pg6Yu4tHlxhgfAaN51uVO07xfvrWFZAsp8CLRb/DvEU ZQIp6u1AwliwW6qf91W2+Qd37G5ZIPRuHZER/2B+SGdw21D7h5G8GWAgpJNxwBYD76mi65WoVjb KiLV6qFEKVPDImjAV+DbaLQt18IulmAk6Xn7AMMaMsO/wEjiymVkfciB40dhfIw== X-Gm-Gg: ASbGncvdnIWUM+VEetqvJaRwvaIHer2BxK1SJeN+xtwPZ4PZ8zCJc76gyMCYtXOz8iX Ai9iFYaSMD+WfAdOKfErAY8F3Pep1u0bjVPuSJLL1jYdGRAvIS8un/yVzsZIaEIQKuZzTEjlHlL qCGNAqZQgC4mzFK9pDmW5+DLL4MZ2r7k+xYL25DzpgT3jrZ0F9ec10F2pV4TQmUDC5GCxfv7z7F jZRlyDp1afULqBsFsVFoEDi5HzxRMyJqaQpvncutJAXSqZhdBIZBPXuyq+JGzOQYfBIZ1IKqp9c SR2mvb9hUvNkdrlTlizHbvAjutss0XzDJTsztn+Hia5Mhb5FlFo/Q1LYtzGpgbnj5PMc8zunN6h 4OA== X-Received: by 2002:a5d:64e7:0:b0:386:1cd3:8a09 with SMTP id ffacd0b85a97d-3862b33baa6mr1707706f8f.1.1733480981149; Fri, 06 Dec 2024 02:29:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxOqpTSxmUtQDodZFCKj1wweUhXSgZ97O5uRZxNOaG1Z6sAnCn3dDJG4gngRrYSA9cesnwGw== X-Received: by 2002:a5d:64e7:0:b0:386:1cd3:8a09 with SMTP id ffacd0b85a97d-3862b33baa6mr1707674f8f.1.1733480980787; Fri, 06 Dec 2024 02:29:40 -0800 (PST) Received: from ?IPV6:2003:cb:c71b:d000:1d1f:238e:aeaf:dbf7? (p200300cbc71bd0001d1f238eaeafdbf7.dip0.t-ipconnect.de. [2003:cb:c71b:d000:1d1f:238e:aeaf:dbf7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3861fd46cdesm4239800f8f.57.2024.12.06.02.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Dec 2024 02:29:39 -0800 (PST) Message-ID: <393a1314-79b4-421a-ae45-f33c1bb600f8@redhat.com> Date: Fri, 6 Dec 2024 11:29:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/17] mm: factor out large folio handling from folio_nr_pages() into folio_large_nr_pages() To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen References: <20240829165627.2256514-1-david@redhat.com> <20240829165627.2256514-3-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.10.24 13:18, Kirill A. Shutemov wrote: > On Thu, Aug 29, 2024 at 06:56:05PM +0200, David Hildenbrand wrote: >> Let's factor it out into a simple helper function. This helper will >> also come in handy when working with code where we know that our >> folio is large. >> >> Make use of it in internal.h and mm.h, where applicable. >> >> While at it, let's consistently return a "long" value from all these >> similar functions. Note that we cannot use "unsigned int" (even though >> _folio_nr_pages is of that type), because it would break some callers >> that do stuff like "-folio_nr_pages()". Both "int" or "unsigned long" >> would work as well. >> >> Signed-off-by: David Hildenbrand >> --- >> include/linux/mm.h | 27 ++++++++++++++------------- >> mm/internal.h | 2 +- >> 2 files changed, 15 insertions(+), 14 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 3c6270f87bdc3..fa8b6ce54235c 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -1076,6 +1076,15 @@ static inline unsigned int folio_large_order(const struct folio *folio) >> return folio->_flags_1 & 0xff; >> } >> >> +static inline long folio_large_nr_pages(const struct folio *folio) >> +{ >> +#ifdef CONFIG_64BIT >> + return folio->_folio_nr_pages; >> +#else >> + return 1L << folio_large_order(folio); >> +#endif >> +} >> + > > Maybe it would be cleaner to move #ifdef outside of the function? Yes, can do that. -- Cheers, David / dhildenb