From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Brent Lu <brent.lu@intel.com>, alsa-devel@alsa-project.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>,
ye xingchen <ye.xingchen@zte.com.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Intel: sof_ssp_amp: remove unused variable
Date: Tue, 3 Jan 2023 09:13:33 -0600 [thread overview]
Message-ID: <393a6418-0963-4859-3212-2f959be4f14f@linux.intel.com> (raw)
In-Reply-To: <20230103073704.722027-1-brent.lu@intel.com>
On 1/3/23 01:37, Brent Lu wrote:
> The variable becomes useless since we moved the snd_soc_jack
> structure from a static array to sof_hdmi_pcm structure.
>
> Signed-off-by: Brent Lu <brent.lu@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/sof_ssp_amp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/sound/soc/intel/boards/sof_ssp_amp.c b/sound/soc/intel/boards/sof_ssp_amp.c
> index 94d25aeb6e7c..f75800d9d6de 100644
> --- a/sound/soc/intel/boards/sof_ssp_amp.c
> +++ b/sound/soc/intel/boards/sof_ssp_amp.c
> @@ -105,7 +105,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
> char jack_name[NAME_SIZE];
> struct sof_hdmi_pcm *pcm;
> int err;
> - int i;
>
> if (!(sof_ssp_amp_quirk & SOF_HDMI_PLAYBACK_PRESENT))
> return 0;
> @@ -124,7 +123,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
> return hda_dsp_hdmi_build_controls(card, component);
> }
>
> - i = 0;
> list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
> component = pcm->codec_dai->component;
> snprintf(jack_name, sizeof(jack_name),
> @@ -139,8 +137,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
> &pcm->sof_hdmi);
> if (err < 0)
> return err;
> -
> - i++;
> }
>
> return hdac_hdmi_jack_port_init(component, &card->dapm);
next prev parent reply other threads:[~2023-01-03 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 7:37 Brent Lu
2023-01-03 15:13 ` Pierre-Louis Bossart [this message]
2023-01-03 19:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=393a6418-0963-4859-3212-2f959be4f14f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=ye.xingchen@zte.com.cn \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®