mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Kleen <ak@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>,
	Keith Owens <kaos@ocs.com.au>,
	dipankar@in.ibm.com,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Notifier chains are unsafe
Date: Wed, 26 Oct 2005 21:05:24 +0200 (CEST)	[thread overview]
Message-ID: <3941240.1130353524290.SLOX.WebMail.wwwrun@imap-dhs.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0510261037280.4957-100000@iolanthe.rowland.org>


>
> On 26 Oct 2005, Andi Kleen wrote:
>
> > If you add locks to the reader make sure it is only taken
> > if the list is non empty. Otherwise you will add unacceptable
> > overhead to some fast paths.
>
> I don't understand this comment. What point is there in avoiding a
> lock
> when the list is empty?
 
It doesn't add locking overhead for a common case.
 
> Did you mean that a lock should be taken only if
> the list _is_ empty?

No.

> > Better would be likely to use RCU.
>
> Note that the RCU documentation says RCU critical sections are not
> allowed
> to sleep.
 
In this case it would be ok.

 
-Andi


  reply	other threads:[~2005-10-26 19:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-24 20:48 Alan Stern
2005-10-25 16:59 ` Joe Seigh
2005-10-25 23:30 ` Chandra Seetharaman
2005-10-26 18:46   ` Alan Stern
2005-10-26 19:05     ` Andreas Kleen [this message]
2005-10-26 20:40       ` Alan Stern
2005-10-26 21:44         ` Andi Kleen
2005-10-26 23:20           ` Chandra Seetharaman
2005-10-27  1:17             ` Joe Seigh
2005-10-28  1:36               ` Chandra Seetharaman
2005-10-27 14:13           ` Alan Stern
2005-10-26 22:40     ` Chandra Seetharaman
2005-10-27 15:28       ` Alan Stern
2005-10-27 20:43         ` Chandra Seetharaman
2005-10-27 21:21           ` Alan Stern
2005-10-27 23:02             ` Chandra Seetharaman
2005-10-28  0:48               ` Keith Owens
2005-10-28  1:34                 ` Chandra Seetharaman
2005-10-28 14:23                   ` Alan Stern
2005-10-28 22:15                     ` Chandra Seetharaman
2005-10-29 14:51                       ` Alan Stern
2005-10-31 22:22                         ` Chandra Seetharaman
2005-11-01 15:24                           ` Alan Stern
2005-11-01 20:20                             ` Chandra Seetharaman
2005-11-01 21:20                               ` Alan Stern
2005-11-02  9:50                                 ` Keith Owens
2005-11-02 16:03                                   ` Alan Stern
     [not found]               ` <mailman.1130460600.30060.linux-kernel2news@redhat.com>
2005-10-28  4:35                 ` Pete Zaitcev
2005-10-25 23:43 ` Andi Kleen
2005-10-26  0:01   ` Chandra Seetharaman
2005-10-26 17:11     ` Andreas Kleen
2005-10-27  2:46       ` Herbert Xu
2005-10-29 12:25         ` Joe Seigh
2005-10-26  6:11 ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3941240.1130353524290.SLOX.WebMail.wwwrun@imap-dhs.suse.de \
    --to=ak@suse.de \
    --cc=dipankar@in.ibm.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sekharan@us.ibm.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®