mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>, Jun Li <jun.li@nxp.com>,
	Mats Karrman <mats.dev.list@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] usb: typec: Support for Alternate Modes
Date: Sun, 1 Jul 2018 14:08:53 +0200	[thread overview]
Message-ID: <3941ff88-b929-4aa6-f40a-7c1b511afdd3@redhat.com> (raw)
In-Reply-To: <20180627151953.30942-1-heikki.krogerus@linux.intel.com>

Hi,

On 27-06-18 17:19, Heikki Krogerus wrote:
> Hi,
> 
> Since we now have an implementation for an actual alternate mode (DisplayPort),
> I guess there is no reason to send another RFC. This series is the same as the
> last RFC proposal [1] with only minor changes. There were only a few comments.
> 
> [1] https://lkml.org/lkml/2018/6/8/225
> 
> I've tested these with a platform that has fusb302, and also with UCSI
> platforms. The UCSI driver will need separate support for alternate modes that
> I'm not including to this series. I'm still working on it. I've used various
> DisplayPort to Type-C adapters for testing, both DisplayPort receptacles and
> connectors.

I've tested that this series does not cause any regression wrt
PD or susperspeed host and gadget mode on a device with a fusb302 controller:

Tested-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> 
> 
> Heikki Krogerus (8):
>    usb: pd: include kernel.h
>    usb: typec: function for checking cable plug orientation
>    usb: typec: mux: Get the mux identifier from function parameter
>    usb: typec: Register a device for every mode
>    usb: typec: Bus type for alternate modes
>    usb: typec: Add driver for DisplayPort alternate mode
>    usb: typec: pi3usb30532: Start using generic state values
>    usb: typec: tcpm: Support for Alternate Modes
> 
>   Documentation/ABI/obsolete/sysfs-class-typec  |  48 ++
>   Documentation/ABI/testing/sysfs-bus-typec     |  51 ++
>   Documentation/ABI/testing/sysfs-class-typec   |  62 +-
>   .../testing/sysfs-driver-typec-displayport    |  49 ++
>   Documentation/driver-api/usb/typec_bus.rst    | 136 +++++
>   MAINTAINERS                                   |  11 +-
>   drivers/usb/typec/Kconfig                     |   2 +
>   drivers/usb/typec/Makefile                    |   3 +-
>   drivers/usb/typec/altmodes/Kconfig            |  14 +
>   drivers/usb/typec/altmodes/Makefile           |   2 +
>   drivers/usb/typec/altmodes/displayport.c      | 578 ++++++++++++++++++
>   drivers/usb/typec/bus.c                       | 401 ++++++++++++
>   drivers/usb/typec/bus.h                       |  38 ++
>   drivers/usb/typec/class.c                     | 486 ++++++++++-----
>   drivers/usb/typec/mux.c                       |   6 +-
>   drivers/usb/typec/mux/pi3usb30532.c           |  13 +-
>   drivers/usb/typec/tcpm.c                      | 188 ++++--
>   include/linux/mod_devicetable.h               |  15 +
>   include/linux/usb/pd.h                        |   1 +
>   include/linux/usb/tcpm.h                      |   9 -
>   include/linux/usb/typec.h                     |  52 +-
>   include/linux/usb/typec_altmode.h             | 160 +++++
>   include/linux/usb/typec_dp.h                  |  95 +++
>   include/linux/usb/typec_mux.h                 |   2 +-
>   scripts/mod/devicetable-offsets.c             |   4 +
>   scripts/mod/file2alias.c                      |  13 +
>   26 files changed, 2116 insertions(+), 323 deletions(-)
>   create mode 100644 Documentation/ABI/obsolete/sysfs-class-typec
>   create mode 100644 Documentation/ABI/testing/sysfs-bus-typec
>   create mode 100644 Documentation/ABI/testing/sysfs-driver-typec-displayport
>   create mode 100644 Documentation/driver-api/usb/typec_bus.rst
>   create mode 100644 drivers/usb/typec/altmodes/Kconfig
>   create mode 100644 drivers/usb/typec/altmodes/Makefile
>   create mode 100644 drivers/usb/typec/altmodes/displayport.c
>   create mode 100644 drivers/usb/typec/bus.c
>   create mode 100644 drivers/usb/typec/bus.h
>   create mode 100644 include/linux/usb/typec_altmode.h
>   create mode 100644 include/linux/usb/typec_dp.h
> 

      parent reply	other threads:[~2018-07-01 12:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 15:19 Heikki Krogerus
2018-06-27 15:19 ` [PATCH 1/8] usb: pd: include kernel.h Heikki Krogerus
2018-07-09 18:58   ` Guenter Roeck
2018-06-27 15:19 ` [PATCH 2/8] usb: typec: function for checking cable plug orientation Heikki Krogerus
2018-07-09 18:59   ` Guenter Roeck
2018-06-27 15:19 ` [PATCH 3/8] usb: typec: mux: Get the mux identifier from function parameter Heikki Krogerus
2018-06-28 10:51   ` Greg Kroah-Hartman
2018-06-28 11:34     ` Heikki Krogerus
2018-07-09 19:03       ` Guenter Roeck
2018-07-20 10:53         ` Heikki Krogerus
2018-06-27 15:19 ` [PATCH 4/8] usb: typec: Register a device for every mode Heikki Krogerus
2018-06-27 15:19 ` [PATCH 5/8] usb: typec: Bus type for alternate modes Heikki Krogerus
2018-06-27 15:19 ` [PATCH 6/8] usb: typec: Add driver for DisplayPort alternate mode Heikki Krogerus
2018-06-27 15:19 ` [PATCH 7/8] usb: typec: pi3usb30532: Start using generic state values Heikki Krogerus
2018-06-27 15:19 ` [PATCH 8/8] usb: typec: tcpm: Support for Alternate Modes Heikki Krogerus
2018-06-29 14:21 ` [PATCH 0/8] usb: typec: " Heikki Krogerus
2018-07-01 12:08 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3941ff88-b929-4aa6-f40a-7c1b511afdd3@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jun.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mats.dev.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®