From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425772AbcBRJFi (ORCPT ); Thu, 18 Feb 2016 04:05:38 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:50661 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425603AbcBRJF2 (ORCPT ); Thu, 18 Feb 2016 04:05:28 -0500 From: Arnd Bergmann To: Krzysztof Kozlowski Cc: Andi Shyti , Sangbeom Kim , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, jacob.e.keller@intel.com Subject: Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG_ON Date: Thu, 18 Feb 2016 10:05:06 +0100 Message-ID: <3948917.nk5QvvnR6C@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56C522F7.5040109@samsung.com> References: <1455755707-16844-1-git-send-email-k.kozlowski@samsung.com> <20160218014610.GJ10719@samsunx.samsung> <56C522F7.5040109@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DGzwSEmMHV9GycJfIJjg0obi0IwQCAJyYLzwC9bm2FAVMSGmVJ4 IZKHbO7JAqnKF2PhNFeEyazeaUWf0tRzXF1Y8qO4TJn0R8elM58X5rIxbl4wi2cnadCPdSF gu3UgKtMXxLinxKMNDdOpLoq8iVEOm26EAdH58JdFQitMsptY/hJLsB8Uwq/LDBv6As8szg PYYYUqPbTDrwKgrMgjZGw== X-UI-Out-Filterresults: notjunk:1;V01:K0:3YUkjwpS158=:AmN6TnoDVUnLaQuKkfqiTp CiXSZf4rvsvGHPIrnyBtMhQyX+AC8tQWsYIGFHuro6nM8FfWx97cd7J87aoz3xcvsNQ+W3WPj /cvo6Qyefdswp9lemEFON/nu8855QsfM2gwViBkF7dg84QnRILa8g8hKZjhHdGxwm2ehIlxrp 2PgWBLZyv4cD+DFlRi0Vw9Ixmph9ZSjj5VyGyQ1M4UQ4IsIQBcSTJa2PJ9x6xMs2zYFjT1xrO mzeHeGyz9N9OljWhgtw1svkcP4Q65Ur2Duad7GL7x6qXgWP5FvXNWznXmsXJBFTcxH7c1sTnu Nk/OG3Y5x4MOLuwc0KiNQGwjnADp7gbeht1im/FRrFgwIoni7APl6J+0vpnI1XqqXfVwKp4k4 yVkuVrH3tbNy46OZBQzOef43NAh9sQghsX1lewoPUqNKbJkoy4/CPhLReVKg77wKIuQ3Zv8CQ riVycSARwOfyyVMir+yHFnJ/Ler38nGFY6Z8hV6qp/m6WT4CE91561fNiHX+ROoDp88vcT72c mBENTxGsiZ+yb6uXSgqA66tpCGuviyxYzqtA8hD5FcXy50Gsop2pauRBsc2t5X5gXUPcazSTJ NpZzIFu9fKqIT2jPDSdXv7yZJkTKWTHstfk5+OKpEc+19J/pWwzDNf95Mr7NG1jcFO/c8jCCs kmfw3hTE+fFzWQLcHjOyu7SdK5iGQAC0NafZ/ZQNLZ465XvuPtR+nE+wFvOaYzzsRxrfCYPM3 6J2YQ8lrSPMsAlWi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 18 February 2016 10:48:39 Krzysztof Kozlowski wrote: > > Sure, it can be safely removed from s2mps11_info... but it won't affect > this issue and this patch. Still the local variable would be used in > probe leading to compiler optimization choices impacting BUILD_BUG_ON. A local variable probably works fine, I can test that if we think that would improve the code. Arnd