From: Felix Fietkau <nbd@nbd.name>
To: Shuah Khan <skhan@linuxfoundation.org>,
lorenzo.bianconi83@gmail.com, ryder.lee@mediatek.com,
kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org,
matthias.bgg@gmail.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mt76: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()
Date: Fri, 12 Feb 2021 06:36:26 +0100 [thread overview]
Message-ID: <3949e1fc-c050-73e0-d02f-63a25c4821ef@nbd.name> (raw)
In-Reply-To: <20210212021312.40486-1-skhan@linuxfoundation.org>
On 2021-02-12 03:13, Shuah Khan wrote:
> ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and
> the resulting pointer is only valid under RCU lock as well.
>
> Fix mt76_check_sta() to hold RCU read lock before it calls
> ieee80211_find_sta_by_ifaddr() and release it when the resulting
> pointer is no longer needed.
>
> This problem was found while reviewing code to debug RCU warn from
> ath10k_wmi_tlv_parse_peer_stats_info() and a subsequent manual audit
> of other callers of ieee80211_find_sta_by_ifaddr() that don't hold
> RCU read lock.
>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
If I'm not mistaken, this patch is unnecessary. mt76_check_sta is only
called from mt76_rx_poll_complete, which itself is only called under RCU
lock.
- Felix
next prev parent reply other threads:[~2021-02-12 5:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1613090339.git.skhan@linuxfoundation.org>
2021-02-12 2:13 ` [PATCH 1/2] ath9k: " Shuah Khan
2021-02-12 2:13 ` [PATCH] mt76: " Shuah Khan
2021-02-12 5:36 ` Felix Fietkau [this message]
2021-02-12 17:20 ` Shuah Khan
2021-02-12 2:13 ` [PATCH] rtw88: " Shuah Khan
2021-02-12 6:34 ` Felix Fietkau
2021-02-12 6:31 ` [PATCH 1/2] ath9k: " Felix Fietkau
2021-02-12 2:13 ` [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference Shuah Khan
2021-02-16 7:03 ` Kalle Valo
2021-02-16 7:53 ` Felix Fietkau
2021-02-16 15:22 ` Shuah Khan
2021-02-17 7:30 ` Kalle Valo
2021-02-17 14:56 ` Shuah Khan
2021-02-17 20:28 ` Shuah Khan
2021-02-17 21:36 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3949e1fc-c050-73e0-d02f-63a25c4821ef@nbd.name \
--to=nbd@nbd.name \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®