From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E682D394462 for ; Mon, 30 Mar 2026 06:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774852842; cv=none; b=IFU2XYvEvbJUxlVNI3jtmgwZ+Y7dKol7nnm5h7Mv6yB97wVvRx2JAHpkdcciTXOHij47Mey+STH2UzHa2nl8ygKwrxvo6uOU2RYNvryYn1TnKHuCsG9cIXkuuMf+V5iwR1C12T9vAlW8aAvRpgZ/oxdhYWlJZRlcFdR+WDnQ8UQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774852842; c=relaxed/simple; bh=phJGBGj0ZZh8P2EtcYuN9MO8WEuo/xfG5alG3IFw1w4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i5RodieRKIBXeFkO4wmZhphW4uq/xVg/Gg10bWo2IRgOvhGGKXibpNqHSmnpgbXXcgiGV/5/e9NPFpe3YqACbV84plky7+br56iCRxjXkJmYOrYlvUpNexA/5nJUeRD723eoXigWTkqEOf1Sz9+phOh5ORrDE6SPvmnBqQVHm5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CC14ka/1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OgL/uy54; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CC14ka/1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OgL/uy54" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774852839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R9tPUG93KFW9eXmcEZ52SvxSIOvXoItR764o3wit1Kc=; b=CC14ka/187pO2t6tGQrOAzQ8YU4nDqO2+StPc0LEe7+JN0cEA6812AZ1G2SaGuBhVlARUh s7pk2sWx+Sx8UEJbB+J8S+nVa1+Z9UkQEGfm0G36vCx8sQXf8bUUl9ngnQbocYOpRxLrR1 xM/aK+fzG+8BF2cPjFTHr0OmIcDBTdU= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-BwLsJeO6PjqGpW-kX13GIQ-1; Mon, 30 Mar 2026 02:40:38 -0400 X-MC-Unique: BwLsJeO6PjqGpW-kX13GIQ-1 X-Mimecast-MFC-AGG-ID: BwLsJeO6PjqGpW-kX13GIQ_1774852837 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5a12f7bb92fso2367295e87.2 for ; Sun, 29 Mar 2026 23:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774852836; x=1775457636; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R9tPUG93KFW9eXmcEZ52SvxSIOvXoItR764o3wit1Kc=; b=OgL/uy54+KXSRTIOiNrfW4iQEwfPgF9gFYXzqWFVc3DdrC4MBdV4MtlAP456jTvE3H D959NsivDBZ235PUBKYlm2nNOT4TxHaeTww1F9Pq4o+62sKpVO+w5FZCdohI+skMCpDK yzMJNw4G+914v6X8pegFiJKgZbxS2jtF8CCZG77qO6531TIz87zCZAfq12/ray/9VMt0 E6BxTaSCkaV0Dh7Z3E9N0qQgm1k8OenfiPJaQaIBwQxXJkwXlSfSGb2p1rVpIJ2n/RT5 W4Xs43IECIwQjQI46/iRGI2lbYoQXdbTKig/sGfPj5hzFkXHvmJ7dhDb5j8wGhTr0g/0 mTQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774852836; x=1775457636; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R9tPUG93KFW9eXmcEZ52SvxSIOvXoItR764o3wit1Kc=; b=FLlgkOPJ3gz80jvFZ/NjtjNohj0UiiAaaKwAtFwMwl/OGpgKUYWcRD7nHVW4hmOPZb 16kCTZhVlMczB2ibllIJvs5XA1sK48sEOjmkwhw5mF3lO0NhP2AyH+WU6abyLy/f5r/B 0CQUpZ2A59cgEfBuVezSqQE28EBG2VY6B2Is87ovpx8Dn0reBC2oVPYTY4kWaezLOk7K 0q5q4ohsZ0BGP31K8/ibQp8Ilp7bIjHk4HTWAjOPI3jRCzKPsLMR4Xbumh5eW5PGcUEv anECboBsxYCS6g+t1bq87yTMfnkb9PrdmIE7L+FdnjIDjq+9+l/HqSL1ICuZvfcD4fxQ tYDw== X-Forwarded-Encrypted: i=1; AJvYcCUHRAAFLzxpU3qd1/KsA6L3uHaSl8+F6qoCCP2pePGHFw/kKKTdNQtdU0DWi9JzhCaxHY2ZCpQee6hWRds=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8n1CbT8Vye2Sg5CcMFUvQjHA7WCViTwmslThng63sCB1shBui CEbOCaix4UVdiIqwcl434rde7PdJwRKME4AO/yCJVo/dyKIsDsl5pkSjCO80ntE0tH659HxBb/q xVoDAGyNIRet8KulTzzZ04VuFhFZuDuH3UifpX1XltOHU/h4eV9SK5NdPgRPgWKVv X-Gm-Gg: ATEYQzyO9h9iZNM9PHC+sL86d/fqaIHXejPmN3a6lYDzHdqLGFVEUQddu2LwbskyysA O8dt7lRYZl2NkoujDryOipIlLZ+xg+pRTzVLm360kVAnDaI25VYJqYevH901QWanQQBYt2dyJHb 01ZoyMX00YO5Wa0YOQzVJyC9QV4gMhdhHngeKofJpswCXElozQj+4Kv/Y6zbnLQZhHA1BJYRfnt 31IkNjNtrd9JjrR+WXU7YFKblkQVX+2C/7a5mKpqkBMyTTPyabTF4PcJnIZIbu4lJbbnJMJ+4Uf KfEsbi6zt9ylydydEuOLYVMGVrlLDMW7AtL9Toi1SStEJU/Egyf20ty91zVhuWcbbGWWPAG56vK 6KUaCgduUUOh/X6rK27EKEn2PR5dPYJUgCR2ZLfVG6BcowbM= X-Received: by 2002:a05:6512:1307:b0:5a2:792f:b836 with SMTP id 2adb3069b0e04-5a2ab92c85dmr3817447e87.30.1774852836454; Sun, 29 Mar 2026 23:40:36 -0700 (PDT) X-Received: by 2002:a05:6512:1307:b0:5a2:792f:b836 with SMTP id 2adb3069b0e04-5a2ab92c85dmr3817431e87.30.1774852835948; Sun, 29 Mar 2026 23:40:35 -0700 (PDT) Received: from [192.168.1.86] (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2b1443f46sm1508497e87.43.2026.03.29.23.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2026 23:40:35 -0700 (PDT) Message-ID: <394bec19-7313-46e2-b0b2-640492454d8a@redhat.com> Date: Mon, 30 Mar 2026 09:40:35 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/6] mm: add new testcase for the migrate on fault case To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Jason Gunthorpe , Leon Romanovsky , Alistair Popple , Balbir Singh , Zi Yan , Matthew Brost , Marco Pagani References: <20260330043017.251808-1-mpenttil@redhat.com> <20260330043017.251808-6-mpenttil@redhat.com> Content-Language: en-US From: =?UTF-8?Q?Mika_Penttil=C3=A4?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 3/30/26 09:21, Christoph Hellwig wrote: > On Mon, Mar 30, 2026 at 07:30:16AM +0300, mpenttil@redhat.com wrote: >> From: Mika Penttilä > This seems to lack a commit message. > > Also where is the real user of your changes? It seems like only this > test case consumes it currently and you actually add dead code? > The changes add the possibility to do migration initiated by hmm_range_fault() while handling faults. There are some advantages to it, like more efficient flow, and you get the VMA populated (needed for migration). Also, the current migrate_vma_setup() initiated flow is changed to use the new code, so it's not dead code. Thanks, Mika