From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5300DC43334 for ; Fri, 10 Jun 2022 03:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242254AbiFJDTv (ORCPT ); Thu, 9 Jun 2022 23:19:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbiFJDTs (ORCPT ); Thu, 9 Jun 2022 23:19:48 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C7B3137468; Thu, 9 Jun 2022 20:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=hkLBPPlvjtC3ylOP5SeJ09/0O1+6FtwXDlDt3P/zie4=; b=VDpaFaucn2HiAgAPRvAcwLUruo 9sjYMXoxBkiCQynlNPbnVLzt8p1uwPbEonyfN+wbQAOAG8kKwR3uPriQlrUREQNG8h0KPQ3HRO3yY K5NrlAjOIHU0+B8VgFZtSAPF3YRM1SaHWrHeE0Epkx3tN2qvg756Hn8oFB87n3nWETx4VJ+JD+G3p gyK3dFwhanbDwApcpN8WYPGHa4YTbKPynARLlNBGKXOKvNMFGMDflWvbP3/wLdp+/bJbFCbQ6Xl4F Xrqvc3nZCqkKFoXptDf5dqf3hKjDX0NI3vF/R0YfRf8AbW4+Zc30XV1QRyiQGRoEBJCWtzvI9CJNg 5T7ruYYA==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzVBR-00E6SY-KL; Fri, 10 Jun 2022 03:19:37 +0000 Message-ID: <395072af-3349-cead-fe07-62d3d758d635@infradead.org> Date: Thu, 9 Jun 2022 20:19:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus Content-Language: en-US To: =?UTF-8?B?6YOt5Yqb6LGq?= , krzk@kernel.org, rafael@kernel.org, Daniel Lezcano , amitk@kernel.org, rui.zhang@intel.com, robh+dt@kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "lh.kuo" , =?UTF-8?B?5ZGC6Iqz6aiwTHVXZWxscw==?= References: From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi-- On 6/9/22 18:32, 郭力豪 wrote: > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 0e5cc94..c85e668 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL > If you say yes here you get support for the FAN controlled > by the Microcontroller found on the Khadas VIM boards. > > +config SUNPLUS_THERMAL > + tristate "Sunplus thermal drivers" > + depends on SOC_SP7021 || COMPILE_TEST > + help > + This enable the Sunplus SP7021 thermal driver, which supports the primitive > + temperature sensor embedded in Sunplus SP7021 SoC. > + > + If you have a Sunplus SP7021 platform say Y here and enable this option > + to have support for thermal management End the sentence above with a period ('.'). And the indentation here is all messed up. See Documentation/process/coding-style.rst: 10) Kconfig configuration files ------------------------------- For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. > + > endif -- ~Randy