From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932267AbbJPTGw (ORCPT <rfc822;w@1wt.eu>);
	Fri, 16 Oct 2015 15:06:52 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:49524 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751922AbbJPTGu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 16 Oct 2015 15:06:50 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Jiri Slaby <jslaby@suse.cz>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Jonathan Corbet <corbet@lwn.net>,
        Sergei Zviagintsev <sergei@s15v.net>,
        Peter Hurley <peter@hurleysoftware.com>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Sebastian Reichel <sre@kernel.org>, NeilBrown <neil@brown.name>,
        Grant Likely <grant.likely@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-serial@vger.kernel.org,
        Marek Belisko <marek@goldelico.com>, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver
Date: Fri, 16 Oct 2015 21:06:14 +0200
Message-ID: <3951119.loGSTxYIZb@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <c53ab7a3ca68f8b9f802c1ea799d72e1cb04a1eb.1445018913.git.hns@goldelico.com>
References: <cover.1445018912.git.hns@goldelico.com> <c53ab7a3ca68f8b9f802c1ea799d72e1cb04a1eb.1445018913.git.hns@goldelico.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:tl8JA3aQW9J9mp6aFg9cUnlHiU8xeETzyZBNKAjj3B0pupq1IL3
 8cDRig06Uen3l5QLMTiiDucwjIKYPXyGpEdN+61KK3TUXCbWsSAKgBbaLBqE+Bbzjc7Ej6v
 eEgl0N3A0daqod4iundyQ92NC+KakeAbZP0/YQLfTwe/Ma4xAVLnv5zlghpgHlm6mrU7OJN
 ZrguIrNRQJzHerjx+fwwQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:105CDn6tqn8=:mOyz7tMgiK3SO1PKI8dt4P
 G0cPdiSU03vqspa6pDfe0zh6w1vtD6MnTZenEBHiffAmWhVd7mM/xV8u59Jub8HIbUNjWL9NK
 TqRxKfWkafDz1Cht27G66hTGhGUom0a7BWGXUn/WmIy+ugWQH1Iy+Fv5OIsOsGpLtHYHaK2DC
 cl+eSVUlOXTu3bUC7abSv1ZwSby+GvzF+GDg8kLILrMT2O3Vc0lijoeeonFosvlJ6YcYlKjST
 iox0Trwu63fT5A2kOpo6QQAv7Tu/s4OYY1G89+g+bpzS2jWqIDuKB16U9RKeAKvQ3Vtd/DQNw
 RsFJb6qvzEzqC/0QdmLw4mx0n2NZIccY+ihwM/2Fy8jwwvc+C0F8SiiCXtrTfSWhwOre7FVTg
 DOHVBSC0mAPoQEkQh7/dTKuauKclrLgkRgZTeRJQCJBHzwmyrTQtLTy4JPGNjKjjAXT5P5QK5
 xSScvATVYAJGO7MKkDJqeuwWsUBZozGQRk5zxmxXdauZrIQSbhajqkRqwRgfEYzXpfLP2vnRl
 hDfjF9XWIHEefhZcpmAfWoGfJaSxSvzvj5xfqAVi8Z7YQBpGGOP8GTI8OHH1sC7PuTEmoyiTq
 bKZx+HVzk4fqyIo8FbEhAyjYHcIm5ZZTp/ruIWWN3zYVu4V5tTJLWzO+RK9nH+SDEWvZjk65J
 iraNyQswtv92PJ4wzUs/7nB1AE2HCL+vsfg/4/bJ0Gfo4aSKLjAjtFEx5p04nqGIk5D2HEa1D
 DAbQuJ/2PCsJZRdz
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 16 October 2015 20:08:35 H. Nikolaus Schaller wrote:
> +
> +static int w2sg_data_probe(struct platform_device *pdev)
> +{
> +       struct w2sg_pdata *pdata = dev_get_platdata(&pdev->dev);
> +       struct w2sg_data *data;
> +       struct rfkill *rf_kill;
> +       int err;
> +
> +       pr_debug("%s()\n", __func__);
> +
> +       if (pdev->dev.of_node) {
> +               struct device *dev = &pdev->dev;
> +               enum of_gpio_flags flags;
> +
> +               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> +               if (!pdata)
> 

Why is this a platform_device and not a serio_device?

	Arnd