From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BD2C04E69 for ; Mon, 14 Aug 2023 08:48:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235057AbjHNIsa (ORCPT ); Mon, 14 Aug 2023 04:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235003AbjHNIry (ORCPT ); Mon, 14 Aug 2023 04:47:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D12C91 for ; Mon, 14 Aug 2023 01:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692002832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d5No2yWXOwFNofrztFyXIxBaBOAMm52WifJguXNm6mc=; b=WYyxr00HEq5a1/GGjr2OZ88FnHXVHuczQHUY5teOZTFPo3eX3Dxn4/jl0I4ySuz/wFrIc/ G+bH22HnRdN6KB/Nnfya6ZA6n1UDCVdjNRTSeBRCFJjoN2AfBun5gJSXj3XV898T21PEwH DmTr3Cn1ifv8FTDrpAuhcVQY5hyiRpI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-108-m5H72l0VOcyYGOFjWcvkTg-1; Mon, 14 Aug 2023 04:47:04 -0400 X-MC-Unique: m5H72l0VOcyYGOFjWcvkTg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 36BDA805AF6; Mon, 14 Aug 2023 08:47:04 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CF21492C13; Mon, 14 Aug 2023 08:47:01 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230811010309.20196-2-zhanghongchen@loongson.cn> References: <20230811010309.20196-2-zhanghongchen@loongson.cn> <20230811010309.20196-1-zhanghongchen@loongson.cn> To: Hongchen Zhang Cc: dhowells@redhat.com, Alexander Viro , Christian Brauner , Steve French , Jens Axboe , David Disseldorp , Luis Chamberlain , Nick Alcock , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn Subject: Re: [PATCH v5 2/2] pipe: use __pipe_{lock,unlock} instead of spinlock MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3955286.1692002820.1@warthog.procyon.org.uk> Date: Mon, 14 Aug 2023 09:47:00 +0100 Message-ID: <3955287.1692002820@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hongchen Zhang wrote: > - spin_lock_irq(&pipe->rd_wait.lock); > + __pipe_lock(pipe); This mustn't sleep. post_one_notification() needs to be callable with a spinlock held. David