From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933200AbcAKNzj (ORCPT ); Mon, 11 Jan 2016 08:55:39 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:64789 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932497AbcAKNzc (ORCPT ); Mon, 11 Jan 2016 08:55:32 -0500 From: Arnd Bergmann To: Mason Cc: Kishon Vijay Abraham I , Felipe Balbi , LKML , linux-usb Subject: Re: Correct place for USB PHY driver Date: Mon, 11 Jan 2016 14:55:27 +0100 Message-ID: <3956038.NYKA2GIJmd@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5693986B.6050204@free.fr> References: <56937EC9.4050109@free.fr> <569383BB.3030400@ti.com> <5693986B.6050204@free.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rd38I4qdwl1PynOZovhGOrc6wbA7CTAhY5QGo5RldmXrEv+UBNW i6ozUR20BGtUojzLuDahRsy59oxB8ela2S2IzzkDbnC59ZVSIQzzW7Fc01Ds0bv52HcUggi ugYwQZMp9mq447dtjRwgiM9VFR4kQzH5WG6JFqNWpojo64ayrBHe0Lg7QJM4wDQ3tTJZuUg HZ4AnlXSLk2yZ3PN4XKfg== X-UI-Out-Filterresults: notjunk:1;V01:K0:E2qFBo3KwEE=:jEQrQwnCrs4uHwEBVG4eUN 6VyjhjgpS9HpSahpdINgfSZEMiLWD+0iBh+pLzSQSVFO02PH8dZH3C+RKvGNpHg2mOqrqlwaU yDDGHtSczsAT0SutI0lIEaV/E0gAHku6FfrDCrYx5NiZr8nhIQImf8s56yz/+a0GGetmkN0CS X6t1GJE5S3UGOw9fkfpAyisM3dVxfgGv+9JOJEsOHVw50PzcbW0avO0fqKsT/CP78yPsknAKg MG6x5sHVG3n3UZeRW2qcnBBYzPd/z+7oyi5NAa1HqmCZ2czPE+KLwDBUYkG4jlCO8iD5g5Mu1 BAtVtqpokn9GtVBUwmyplukbm9MvddD1kvusPyGzD6slVoJC6j067M1gvwhety/CqTFXpdQ0J UI5K+7665VGHLY2cl51wPI2kKhe1J7avmdjAo+WMRTLukL1u4kdRn44r8i6DjUjZjiaob8vNi LC/QPoGmPrnVt+xo4EV7luYyKjFr83ZmgjlNdrlkY69W4vCVZjKyXI+GG5OLaAe7ItULqz3Ic pQWNPxozMKc5PoqsvSk9BC/3c6aPUukqSgxeGJoP4BlRIi/lqXO7K7JhGY//qe9fpBmb/lN43 Z6g3248M+tKp+cwVJOfeF6p5DsASOKbVgHioZDaNBUmQT3OGQEDja0OosjBpIpjlP8OnaTqll UBVycQ5A+e/I1yT3pRZY9tgHAiudAD2Cum0GBGXtuZy8G88cUrvPSpJE/AAVoYjlkoATkLwsX 62hXgD9KE62jzEt/IPu/NC6ktM1hnbDmVjpX0ojD1ZVb3hfz3mKQHPjUyvvjPpz1Bmn/I6pR9 rN84FDyXtgxphMOY99ZOKW+akYf3g== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 11 January 2016 12:56:27 Mason wrote: > On 11/01/2016 11:28, Kishon Vijay Abraham I wrote: > > > On Monday 11 January 2016 03:37 PM, Mason wrote: > > > >> I have a board with a Chipidea controller. > >> I use a custom PHY driver for it. > >> > >> Should the PHY driver live in drivers/phy or in drivers/usb/phy ? > > > > All new phy drivers should be in drivers/phy using the generic PHY framework. > > > >> I was playing with a modular build and hit this problem: > >> ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined! > >> > >> I'm currently using v4.1.13 and I saw that Arnd fixed something related > >> probably in a later version: > >> > >> http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561 > >> > >> Was this patch accepted upstream? > > > > I think no. > > The driver I use is in drivers/phy and my config has > > CONFIG_GENERIC_PHY=y > # CONFIG_USB_PHY is not set > > But I do hit the "of_usb_get_phy_mode undefined" error when I > set all of USB to m. > > Arnd, do you think your patch needs to be carried over to generic PHY? I think my patch is still needed, I will resubmit it if it doesn't make it into 4.5-rc1. In the meantime you can work around the problem by setting CONFIG_USB=y instead of CONFIG_USB=m. Arnd