From: David Howells <dhowells@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Anna Schumaker <anna.schumaker@netapp.com>,
Boaz Harrosh <ooo@electrozaur.com>,
Christoph Hellwig <hch@lst.de>,
ecryptfs@vger.kernel.org (open list:ECRYPT FILE SYSTEM),
"Eric W. Biederman" <ebiederm@xmission.com>,
Fabian Frederick <fabf@skynet.be>, Joe Perches <joe@perches.com>,
linux-cifs@vger.kernel.org (open list:COMMON INTERNET FILE
SYSTEM (CIFS)),
linux-ext4@vger.kernel.org (open list:EXT4 FILE SYSTEM),
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure)),
linux-nfs@vger.kernel.org (open list:NFS, SUNRPC,
AND LOCKD CLIENTS), Peng Tao <tao.peng@primarydata.com>,
Petr Vandrovec <petr@vandrovec.name>,
samba-technical@lists.samba.org (moderated list:COMMON INTERNET
FILE SYSTEM (CIFS)), Steve French <sfrench@samba.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Tom Haynes <loghyr@primarydata.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Tyler Hicks <tyhicks@canonical.com>,
Weston Andros Adamson <dros@primarydata.com>
Subject: Re: [PATCH 12/15] fs: Drop unlikely before IS_ERR(_OR_NULL)
Date: Fri, 31 Jul 2015 10:20:56 +0100 [thread overview]
Message-ID: <396.1438334456@warthog.procyon.org.uk> (raw)
In-Reply-To: <4fd8dd8ed76901a89d6cd17e50ac585ea929f1fb.1438331416.git.viresh.kumar@linaro.org>
Viresh Kumar <viresh.kumar@linaro.org> wrote:
> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> is no need to do that again from its callers. Drop it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2015-07-31 9:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 8:38 [PATCH 00/15] trivial: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 01/15] err.h: add (missing) unlikely() to IS_ERR_OR_NULL() Viresh Kumar
2015-07-31 8:38 ` [PATCH 02/15] PM / OPP: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31 8:38 ` [PATCH 03/15] drivers: devfreq: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 04/15] drivers: gpu: " Viresh Kumar
2015-07-31 15:53 ` Sinclair Yeh
2015-08-03 8:01 ` Daniel Vetter
2015-07-31 8:38 ` [PATCH 05/15] drivers: input: " Viresh Kumar
2015-07-31 16:58 ` Dmitry Torokhov
2015-08-01 11:22 ` Viresh Kumar
2015-08-01 11:44 ` Pali Rohár
2015-08-02 15:43 ` Pavel Machek
2015-08-02 15:59 ` Pali Rohár
2015-07-31 8:38 ` [PATCH 06/15] drivers: md: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 07/15] drivers: misc: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 08/15] drivers: net: " Viresh Kumar
2015-07-31 15:04 ` Murali Karicheri
2015-07-31 15:39 ` David Laight
2015-07-31 16:20 ` Viresh Kumar
2015-08-03 15:52 ` Murali Karicheri
2015-07-31 8:38 ` [PATCH 09/15] drivers: rtc: " Viresh Kumar
2015-07-31 9:31 ` [PATCH] drivers: rtc: fix ptr_ret.cocci warnings Viresh Kumar
2015-08-11 15:54 ` Alexandre Belloni
2015-07-31 10:53 ` [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-03 4:32 ` Hans Ulli Kroll
2015-08-11 15:54 ` Alexandre Belloni
2015-07-31 8:38 ` [PATCH 10/15] drivers: staging: Drop unlikely " Viresh Kumar
2015-07-31 8:38 ` [PATCH 11/15] drivers: target: " Viresh Kumar
2015-08-03 5:45 ` Nicholas A. Bellinger
2015-07-31 8:38 ` [PATCH 12/15] fs: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 13/15] blk-cgroup: " Viresh Kumar
2015-07-31 11:59 ` Tejun Heo
2015-07-31 8:38 ` [PATCH 14/15] mm: " Viresh Kumar
2015-07-31 8:56 ` Kirill A. Shutemov
2015-07-31 9:32 ` yalin wang
2015-07-31 9:34 ` Viresh Kumar
2015-07-31 10:28 ` Joe Perches
2015-07-31 11:06 ` Viresh Kumar
2015-07-31 18:00 ` Joe Perches
2015-08-01 11:18 ` Viresh Kumar
2015-07-31 8:38 ` [PATCH 15/15] net: " Viresh Kumar
2015-07-31 9:20 ` David Howells [this message]
2015-07-31 9:41 ` [PATCH 00/15] trivial: " Vlastimil Babka
2015-07-31 9:49 ` Viresh Kumar
2015-07-31 10:23 ` Kirill A. Shutemov
2015-07-31 11:02 ` [PATCH] staging: lustre: drop redundant check Viresh Kumar
2015-07-31 11:04 ` [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-03 21:38 ` Steven Rostedt
2015-08-04 2:19 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396.1438334456@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=dros@primarydata.com \
--cc=ebiederm@xmission.com \
--cc=ecryptfs@vger.kernel.org \
--cc=fabf@skynet.be \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@primarydata.com \
--cc=ooo@electrozaur.com \
--cc=petr@vandrovec.name \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=tao.peng@primarydata.com \
--cc=trond.myklebust@primarydata.com \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=viresh.kumar@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome