From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbdKUJND (ORCPT ); Tue, 21 Nov 2017 04:13:03 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34282 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbdKUJNA (ORCPT ); Tue, 21 Nov 2017 04:13:00 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DB94760730 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tirupath@codeaurora.org Subject: Re: [PATCH V6] clk: qcom: Add spmi_pmic clock divider support To: Rob Herring Cc: sboyd@codeaurora.org, mturquette@baylibre.com, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org References: <1510912127-4582-1-git-send-email-tirupath@codeaurora.org> <20171117202243.you76ej4qvk3ul3g@rob-hp-laptop> From: Tirupathi Reddy T Message-ID: <396227ab-d628-ba5e-1e63-ad51f5cae253@codeaurora.org> Date: Tue, 21 Nov 2017 14:42:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171117202243.you76ej4qvk3ul3g@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2017 1:52 AM, Rob Herring wrote: > On Fri, Nov 17, 2017 at 03:18:47PM +0530, Tirupathi Reddy wrote: >> Clkdiv module provides a clock output on the PMIC with CXO as >> the source. This clock can be routed through PMIC GPIOs. Add >> a device driver to configure this clkdiv module. >> >> Signed-off-by: Tirupathi Reddy >> Signed-off-by: Stephen Boyd > Normally your S-o-B would be last. Addressed in next patch version [7] > >> --- >> .../bindings/clock/clk-spmi-pmic-div.txt | 59 ++++ > Please split bindings to a separate patch. Addressed in next patch version [7] > > Otherwise, > > Acked-by: Rob Herring > >> drivers/clk/qcom/Kconfig | 9 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/clk-spmi-pmic-div.c | 308 +++++++++++++++++++++ >> 4 files changed, 377 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/clk-spmi-pmic-div.txt >> create mode 100644 drivers/clk/qcom/clk-spmi-pmic-div.c