From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbcAMWef (ORCPT ); Wed, 13 Jan 2016 17:34:35 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:58515 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbcAMWed (ORCPT ); Wed, 13 Jan 2016 17:34:33 -0500 From: Arnd Bergmann To: gregkh@linuxfoundation.org Cc: Masahiro Yamada , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, peter@hurleysoftware.com Subject: [PATCH] 8250: uniphier: allow modular build with 8250 console Date: Wed, 13 Jan 2016 23:33:59 +0100 Message-ID: <3965359.aMgb8o9MaG@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:38fIUAb26VYiVDMuponio1Wh5Qv+eK7Pkgt0Oohe4pGVL856f0n QGTKapzXjjvVKU+SbZyPLjr+RONwaExdYNiBq7VGjfEL7Au3/yL0ltvtugRH4JLG/Ge66uu wobBH0LJMjQZr9Ix+Gig9uJkmtbK1c1I5+KkzWnhP0UMYZlbVEjMkV5/KpaUSS0E0BQ7UiH ggSSQ3PpzibtE7uoLrPcw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Yq5VfGwUa8I=:qTHjgIeEkiXK3zBXnNjkR3 mJd7DPKPoBstdYE1ezN4gsksfTcF+A0x3DieVsODqA9eRJmMz5QZMB6/Plb7t+epmOpUYdJss 1zp45FJmr8lWQnvbG8OZPvw98BstOntR7N9u9iY7B/hifQd/J3ukStc/dwQTfLZYYVxRRfMZ6 OxSfeZCu9ccIfQhX4RIK7wdBtM+RxtVNgBtGTnSc93gU8+uToksP2ykDpFIrHWu/v7AlP8Fri x8/hi/nX8IaGHe6hRHx7fprjCneP6PzX/CnyG2MsrZ3Xrm5+Mzx0svuecRXsAw/nvLi0T4NDT 040xUYvKDUkO5gZHE95Ke7zJQRU+hTMZ6hRHF1gdwn/YjKljjqW5aAbLtBOZZ/dPUWiitjkYz SfyfsHJgyxz5PD4sT7E8ktyilIyCZgjt0GWNwsi2D65zVepu3FI6T3dHH0NVFQiF7zzkjBNbM naYaYxu6A1JGfAcLizUVEC3F3rdhMAd2FKgUriBHZEH4S13rmEI5CFQYgsUSRfqclFtfz6kA8 CwvehXPC4f30mexU2dr6v72Ne9X+weihav7yjpHWrr861ZyjDtudSbHy7cRMZo3j7HuoI0fJz XV72VWJZhzfn6OQ0p9fvMK5ZsmJJ7NyemjPmgDnfQ2ZHBUNAj4Z8/MVWE8hSXShNC9e4hhX6I Qzs+wOlnwbHKID2n3C9YZcrypbZINqEz724qNO1gL3BwEZSJgeq7icYSrWC7RTrykZKNib5bz monf1+cU7LYUZU03 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The recently added uniphier 8250 port driver supports early console probing, and it supports being built as a module, but the combination of the two fails to link: ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined! Given that earlycon support in a loadable module makes no sense, making that code conditional on 'MODULE' is a correct solution. Signed-off-by: Arnd Bergmann Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support") diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c index bab6b3ae2540..1b7bd26555b7 100644 --- a/drivers/tty/serial/8250/8250_uniphier.c +++ b/drivers/tty/serial/8250/8250_uniphier.c @@ -35,7 +35,7 @@ struct uniphier8250_priv { spinlock_t atomic_write_lock; }; -#ifdef CONFIG_SERIAL_8250_CONSOLE +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE) static int __init uniphier_early_console_setup(struct earlycon_device *device, const char *options) {