mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jmerkey@wolfmountaingroup.com
To: "Andi Kleen" <andi@firstfloor.org>
Cc: jmerkey@wolfmountaingroup.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.27-rc3 19/28] mdb: adding notify_die handler for  keyboard debugger entry
Date: Sat, 16 Aug 2008 00:33:18 -0600 (MDT)	[thread overview]
Message-ID: <39683.166.70.238.45.1218868398.squirrel@webmail.wolfmountaingroup.com> (raw)
In-Reply-To: <87pro9xyhu.fsf@basil.nowhere.org>

> jmerkey@wolfmountaingroup.com writes:
>
>> +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE)
>> +	if (down && !rep && keycode == KEY_PAUSE)
>> +        {
>> +	   if (notify_die(DIE_KERNELDEBUG, NULL, get_irq_regs(),
>> +                          0, -1, SIGINT) == NOTIFY_STOP)
>> +	      return;
>> +	}
>> +#endif
>> +
>>  #ifdef CONFIG_MAGIC_SYSRQ	       /* Handle the SysRq Hack */
>>  	if (keycode == KEY_SYSRQ && (sysrq_down || (down == 1 && sysrq_alt)))
>> {
>>  		if (!sysrq_down) {
>
> A nicer alternative to adding an hook here would be to use
> register_sysrq_key() to register a sysrq key that triggers
> the debugger.  That function is also already exported.
>
> -Andi
>

Got it.  Added to the list.  I will Instrument it.

Jeff


      reply	other threads:[~2008-08-16  6:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-16  3:41 jmerkey
2008-08-16  6:30 ` Andi Kleen
2008-08-16  6:33   ` jmerkey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39683.166.70.238.45.1218868398.squirrel@webmail.wolfmountaingroup.com \
    --to=jmerkey@wolfmountaingroup.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®