mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jmerkey@wolfmountaingroup.com
To: "Andi Kleen" <andi@firstfloor.org>
Cc: jmerkey@wolfmountaingroup.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.27-rc3 21/28] mdb: disable console warnings if the  debugger is present.
Date: Sat, 16 Aug 2008 00:35:09 -0600 (MDT)	[thread overview]
Message-ID: <39687.166.70.238.45.1218868509.squirrel@webmail.wolfmountaingroup.com> (raw)
In-Reply-To: <87ljyxxybv.fsf@basil.nowhere.org>

> jmerkey@wolfmountaingroup.com writes:
>>
>>  /* Some debug stub to catch some of the obvious races in the VT code */
>> +
>> +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE)
>> +#define WARN_CONSOLE_UNLOCKED()
>> +#else
>>  #if 1
>>  #define WARN_CONSOLE_UNLOCKED()	WARN_ON(!is_console_locked() &&
>> !oops_in_progress)
>>  #else
>>  #define WARN_CONSOLE_UNLOCKED()
>>  #endif
>> +#endif /* CONFIG_MDB */
>
> The obvious alternative would be to just set oops_in_progress
> while the debugger runs.
>
> -Andi
>

Also added to the list.  that would remove the need for this patch, which
would also benefit kdb since it also has a similar patch in this file too.

I will roll these fixes into the rc4 patch.

Jeff



      reply	other threads:[~2008-08-16  6:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-16  3:41 jmerkey
2008-08-16  6:34 ` Andi Kleen
2008-08-16  6:35   ` jmerkey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39687.166.70.238.45.1218868509.squirrel@webmail.wolfmountaingroup.com \
    --to=jmerkey@wolfmountaingroup.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®