From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934484AbbKSWFf (ORCPT ); Thu, 19 Nov 2015 17:05:35 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:52836 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbbKSWFd (ORCPT ); Thu, 19 Nov 2015 17:05:33 -0500 From: Arnd Bergmann To: "James E.J. Bottomley" , linux-scsi@vger.kernel.org Cc: Don Brace , iss_storagedev@hp.com, storagedev@pmcs.com, linux-kernel@vger.kernel.org, martin.petersen@oracle.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR Date: Thu, 19 Nov 2015 23:04:35 +0100 Message-ID: <3970646.5sOyETUiWo@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vTHo5DivbF4sXTPzQDRRdq9c919YL4dG4P0giSnMH19I6MNFh3a X6g1dTb7J9P9I755SrGmKYDqxgz4uR0bHabCHysoQwKSVVFFuEotuty0Zy0NzzeI5F2ORih A0+jhKoDPhZCHrCTOeA4RNguz0TSi33QWIvWJm8bdvNDz4ujinY1U3pe0SPGlA2jqG4BSZQ /CsVSYny4oDhlGcLN8CNA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ehyF6gSJkPc=:dVGUACDGGbiluKevTRlyhO 4gaL2PhJSJXvddgJ9JGWheH+b7Q3oqCfb2aGZE4xzGr1l1lbZTf2h7N1JlxSJcquBFRm+bqBJ C/EeFO2ZBpVM30vmHx2sgXzOlxmOsRygSzUwicBXwV16XcdhdqwlMwORd31NE6mqzai8orUTT o7RSA1eJmSCeIFnE3/C5gPk+n1/1o/mCiyMtHau7NcCiynjnrZNXnyr/xfv7iUgaKInNgPCBV +U8b8hNJBipwEzNhhMaQbB5MZT8UI3PLVjIkyR8GCEcJKf34bW/Y4wFO7/WFYwOgNQA8j1C0r IcLLUeKccgnt/16RMygA3IYuYvGF/lYi6t5MhU9F4fWTuO3s1ImFBYretZhw1XQHk7vZLmuq4 xvIk3En+NqiD/3pDNoRo8jUHJq3rSiw9sQAMvM6NPoRIeZ2xi+6VbwMnBKU5Q8jXoybvY4KNh SYylAT+Xtiu69Fk+mAMZesXHeerICnpUQANLyG3of0nSQiriX56dwUMnmV2e+hTr2Dxx3fVdt qbMhOMAeQQ+iSKBRB4G4lV2OWZjZC1zf1RwZvJKPDHCq0HyKlNUFEgvW0lGmWoJhyUcnDNZhq uwQjveIUat6Pqfe2+Euvd36es8lwltWokt+oKLR9XXYoqWIeAGp988uZJbiVb44xKaKPKcB9L E35FFIOBJHOp15+iNuMqqX2OmhyFlAgd1zC4/hOm9YNH83C04OmIDLGFj4M1GITTgHSHV1xG/ z50zu3cuTPppFTu5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The hpsa driver recently started using the sas transport class, but it does not ensure that the corresponding code is actually built, which may lead to a link error: drivers/built-in.o: In function `hpsa_free_sas_phy': (.text+0x1ce874): undefined reference to `sas_port_delete_phy' (.text+0x1ce87c): undefined reference to `sas_phy_free' drivers/built-in.o: In function `hpsa_alloc_sas_port': (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num' (.text+0x1ceba8): undefined reference to `sas_port_add' drivers/built-in.o: In function `hpsa_init': (.init.text+0x8838): undefined reference to `sas_attach_transport' (.init.text+0x8868): undefined reference to `sas_release_transport This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do for all other drivers using those functions. Signed-off-by: Arnd Bergmann Fixes: d04e62b9d63a ("hpsa: add in sas transport class") --- This showed up on the ARM randconfig builds today for the first time. diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 04a720686516..64eed87d34a8 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -364,6 +364,7 @@ config SCSI_HPSA tristate "HP Smart Array SCSI driver" depends on PCI && SCSI select CHECK_SIGNATURE + select SCSI_SAS_ATTRS help This driver supports HP Smart Array Controllers (circa 2009). It is a SCSI alternative to the cciss driver, which is a block