From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2E2A13D891 for ; Sat, 13 Jun 2026 08:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781338571; cv=none; b=bLTihePIl3nQjaax+hNAQtZeXgYdXzviQXuNYjHAFCLPcRrsoAs01pWS2lpAgJ2eQsVZk9hibu+iDoEkVMpLlPePpy+tQ29vdOmlPm1vslHe9Eu7xzQfo0kQzYybjEOu4WcjM66LZ0h5babixmdaWWcrsZFQgIMkT5f0zr+Zd84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781338571; c=relaxed/simple; bh=gxXIQs4fOYo7UxbFqDXGSyWElu5qYAeUnrJUD0vklmg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=hyvdqdz6ia9hIpZrjAx1Xy6/IEPQlbNh38bW3Qt7gO3IIefM5yxafFZsR0Simh54G4pbInsvGI1lEQy3LfojNoXP0QgkcABgqh3IEtf20FXBxDrmYj9Zy7FCpfscYn3DzdvDF4gXpFJgifsEW2ZrZidHV8u2IV6fh83nhqwwFPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T2+02RrX; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T2+02RrX" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5aa69131836so1588122e87.3 for ; Sat, 13 Jun 2026 01:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781338568; x=1781943368; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0iXLstte6ButgpYOzogymHuOexokA1uZth6v7/qqcCo=; b=T2+02RrXMtMJCfwDyutG9OtBlzhRtcAQ00UNE81YQm+J0vWjlCsAZ5fEmKaUrPHWpX w9Heg/Vl3x60KBWHMFhkMVareUkFw8OdZhhVsykUpbgjyz2WL0nxrKLziYhAiTHxLoUG wYaKf7p4+iOG6UXbjV8X+lpNkmFvNGEh+d9TiblbGWZ1cz7TMwZJCkAvXCNQbJja6g7x A+swLSGRoQPkPnf4TXaIO+Ajo4xCEI7KCgj3RHC660LeH3+WQjuLZ+UytDGOeITK6sHK 0VPtn2dDCQ6/aGyyTw+9zBrCQ8UsAX68IoLHvSrJp3mdOC/hKPJ8yv4W7YBlCHiSU/WW P61w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781338568; x=1781943368; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0iXLstte6ButgpYOzogymHuOexokA1uZth6v7/qqcCo=; b=oNGVqECiLPj3dzG6FI4O2/NRK+xr5ZCKNru5C6NPrik6Z1dzlnPDwm1iN9SC3Ago2D G3pQudSuohNvcP0Fx+B4rLnjfWaewCZTwezgddJb+CKnqlUBMUZBwIsVJCsds3WOrXJx vIIotHVogWz0996iy8BscLlNva4oA5IQtZ1sTKmaIe6g8YNEmKARHnMHImQnTzN7h/uS ktziqYKTU+LYHPvg4YA4WzMcE9+DMPouTzi44ldgfzi7SqLwqq90y19mNZ/B5WhMNSW9 Q3Wj8lKQXk4Aafwx8E49vaauo6PBCc3cuq9JzXKp0NU6D2L8GfHX3ESgYc7OhoAarLpD JjSA== X-Forwarded-Encrypted: i=1; AFNElJ8tzKLbmtWzqc/qMG0CIrBVubBVDkrDwCUoQfMFfe1ZbtLHd2ma10rRn7je83+TOacQGP1sUzgFV8iFLog=@vger.kernel.org X-Gm-Message-State: AOJu0YyS8GIvd2MBGmI1DZKiNnUC47QLeav+E/vObeqmAV1jGXiIzbZP NdW4+koy91WWRlPrSNkimAX0XDaN/5YLgAT6FFdZybslmbcyIrcRGKb2 X-Gm-Gg: Acq92OGeuFgFyMBlGs6YzU1cgEVoSoYtnYxkPddXJ6FdGoqBsfrh4fhR6MwVQN+EwWP FuwPB4I2cU5nxfkvks4DTJx7na+3Df1R6X23L/XxTcz8nBxzFzuvFQgaaclM8icoumuQKfENcXP QzplhHdrLq9aZ4w62CiZIA7/+tw4k4zTJyoyXxTvk+sJJEnL2ehEeURVpaEY6drFefaiC0sQRDz yD51R4P1nVARN5R2Jru0o58ywEb9jloCExe40iZBuWrR8JQF2Yvj+JlJBfFSmt7X8z33YbEQT32 3jNutocdb8AMV0Kp0CSCkqWTEUp5JTM3rObvXZy1/LnmJWnGBgsSKrTXnPRIcG/iDOHUz3sk1EP DAwFLB/3JOp2nKOFXZHslIyYPdxJOh1THw52GOZlkrZnVkeCdI+HuC+MVQJQF5EpGdXpASkIrUQ uaot5JAmXp4q6i5ppZ057IjFlHzI9F0eT/aYdSJ10+8tFgGu0Eq673+Rlet0nPVtKxpzWI1u344 E/Ssw== X-Received: by 2002:a05:6512:4608:b0:5aa:5a89:c80b with SMTP id 2adb3069b0e04-5ad30dc08a1mr583841e87.30.1781338567680; Sat, 13 Jun 2026 01:16:07 -0700 (PDT) Received: from ?IPV6:2a00:1fa0:856:c6e8:742c:af09:78ba:8005? ([2a00:1fa0:856:c6e8:742c:af09:78ba:8005]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e16935esm1124202e87.25.2026.06.13.01.16.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 01:16:06 -0700 (PDT) Message-ID: <39720384-28da-4157-8613-8f02ab890abf@gmail.com> Date: Sat, 13 Jun 2026 11:16:04 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next 9/9] net: ethernet: ravb: Add gPTP support for Gen4 To: =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Paul Barker , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Geert Uytterhoeven , Magnus Damm , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610102432.3538432-1-niklas.soderlund+renesas@ragnatech.se> <20260610102432.3538432-10-niklas.soderlund+renesas@ragnatech.se> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20260610102432.3538432-10-niklas.soderlund+renesas@ragnatech.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/10/26 1:24 PM, Niklas Söderlund wrote: > While driver advertise gPTP support on Gen4 platforms it is in fact Advertises. > completely broken. On R-Car Gen4 devices the RAVB module have no > internal gPTP clock as generations before it. Instead it utilizes a > system wide gPTP clock. > > This change utilizes the refactoring of the RAVB gPTP code to add > support for a system wide clock and stops the Gen4 devices trying to use System-wide? > the non-existing internal gPTP clock. > > To remain backward compatible the device tree property needed > (renesas,gptp) to get hold of the system gPTP clock is optional. If the Can't parse this statement... > property is not present, or not enabled, the RAVB driver will no longer > advertise gPTP support to user-space. > > Signed-off-by: Niklas Söderlund Reviewed-by: Sergey Shtylyov [...] > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index caad95a9c3c5..acdfb56bb135 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -249,6 +249,8 @@ enum APSR_BIT { > APSR_RDM = 0x00002000, > APSR_TDM = 0x00004000, > APSR_MIISELECT = 0x01000000, /* R-Car V4M only */ > + APSR_GPTPTIMER_SOURCE = BIT(25), /* Gen4 */ > + APSR_GPTPCLOCK = BIT(29), /* Gen4 */ Hum, the other *enum* entries don't use BIT()... [...] MBR, Sergey