From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbdLISEk (ORCPT ); Sat, 9 Dec 2017 13:04:40 -0500 Received: from mout.web.de ([212.227.15.3]:55480 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdLISEi (ORCPT ); Sat, 9 Dec 2017 13:04:38 -0500 Subject: [PATCH 1/3] serial: ioc3: Delete error messages for a failed memory allocation in ioc3uart_probe() From: SF Markus Elfring To: linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Pat Gefre Cc: LKML , kernel-janitors@vger.kernel.org References: <962f1172-3f27-c6b5-653f-c09f2e8fe431@users.sourceforge.net> Message-ID: <3975ebe3-f1fa-a545-696d-06d701e707cc@users.sourceforge.net> Date: Sat, 9 Dec 2017 19:03:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <962f1172-3f27-c6b5-653f-c09f2e8fe431@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:JPFyvC4Jd51xs3ruj1C47LOSFUFlHFV/DD5774z3BgpwlIElfrI +LuUlfSKq3ur1kEybZZME90XqhkXeCOkk08eagQXQNUYa8UMaYlFM4F3n6VtDaC/b+qncsr K/EK1VSirjJq4kK3YHrr1HfFbsjxuDFkTP2SD6I5IpxmkN1Fhl9+D/EPCzuK+c3DKN8u8oK C6XI6rdewrR2WMgbDlw6g== X-UI-Out-Filterresults: notjunk:1;V01:K0:76xDMLR+tV0=:lccYASNSVSeRAZ3xz1jaqd vYH53LadHuNlS4B/nwlQYLcMdIjrdkjFQrlJ02VbjjRxcbW6At+o4SCNVNZwXoTjYQDmS6Boa pbSgwUsj50g1zmtoaxNkJPSLtdjxmHUwBbTsDWJZyUJLruOoNj2v1jfct+RDSpPcG6Kg4z1+F xYMxLghnOr8V+izYWP6pWH7K2owdQoyPC/ezcd3PdZOJtQlCaMEM1s18Zv3eiQbK0J6XJCWTK Wbe0jvBEBqDqOHFf+lqQwsKN+Fra2N1zr5OydxTtW8CB5nLN4nHloQUOzmlLsyGnT1yzkMYV4 S9GWy0xOGTMDtMdO4wqf+8sthJ+1h4pZzBw1RHvSdwE7h504y9lE0gaqqIXkpE+HAD0tRWreY fjMi83xZLqVWzSo1w/KFYatuHROrMBT5VFNAEFz0O5EPx8ZLKgM6i7LIOW8EMuXqDkZmxJRB2 6xmcBmykv7VHRkTE51hWUT+4fAeS9oHrSVs0Gwm+H5DuuqNmINnyAjW7Po+LQMIXXgABB1Q2Q 0e/4FcBniUVSvHWf7g2J7DNLwVT2N23ak1AFba08pmOkFIMX2eT42IrLLKJfq8Qdx3HEuX31H sfwYT2sLcK9B+JqFvKCnZlv3huoC+p7t4YHMn7Wf+dqY3f5I8L3yekjaDnnz8Nkh+smZkXThr MKSG2/APjUK62AgMgDl4OuDtvm9waSPCbUbI4xwUpCe4FJ58BitV44vlTVX7ZHWks+K9yf8yJ t5dlaqRDCXZM0HzXhlIQSvq6bjB/NU1P3/l3zCnpVhVaUPRMlylmuODaNODZ2FUAH/tZh4CoQ mbk02B7L/Hysr5n/w1mo1bvUjqCirJLHNPjaTe+CKQBmDL47uM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 9 Dec 2017 18:34:36 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ioc3_serial.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/ioc3_serial.c b/drivers/tty/serial/ioc3_serial.c index d8a1cdd6a53d..0007c2d65028 100644 --- a/drivers/tty/serial/ioc3_serial.c +++ b/drivers/tty/serial/ioc3_serial.c @@ -2017,11 +2017,9 @@ ioc3uart_probe(struct ioc3_submodule *is, struct ioc3_driver_data *idd) DPRINT_CONFIG(("%s (0x%p, 0x%p)\n", __func__, is, idd)); card_ptr = kzalloc(sizeof(struct ioc3_card), GFP_KERNEL); - if (!card_ptr) { - printk(KERN_WARNING "ioc3_attach_one" - ": unable to get memory for the IOC3\n"); + if (!card_ptr) return -ENOMEM; - } + idd->data[is->id] = card_ptr; Submodule_slot = is->id; @@ -2038,8 +2036,6 @@ ioc3uart_probe(struct ioc3_submodule *is, struct ioc3_driver_data *idd) for (phys_port = 0; phys_port < PORTS_PER_CARD; phys_port++) { port = kzalloc(sizeof(struct ioc3_port), GFP_KERNEL); if (!port) { - printk(KERN_WARNING - "IOC3 serial memory not available for port\n"); ret = -ENOMEM; goto out4; } -- 2.15.1