From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B91C337754B for ; Mon, 27 Jul 2026 14:21:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785162089; cv=none; b=WAn/HKuXB6hAvWQ3GugmeUKN4EnxEQ4srCVnXUY3566epY3T+DDKUAR4MzcDRNIlmHcZnemQAnvoOZrPP8mze4hC5z60XXJRQV8j/QrJDJrN8eetWXuTs1FPNz2QkclocNBmyFvWTPtqtzF2HVkTjf98ri2VASZ08S7vjNZ9U4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785162089; c=relaxed/simple; bh=Nkd/PsFxoZAG5j0IfWZP87uyUdz6RJvzIekPjAz1gNo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UXg+1QNYh4Q7hZ4bt4/8sFtbkUkjcJf8Sd3gIo0v14aI5oh7iL6wrMaiH0K2m0vMZ6+QFKCyYFVoLoTBbqGStD0G4NC5NyNH9v8ezua7tLrYPa6xU4aHDXt0gB+NcHFuT0E+ZrVfGaOaepCIDmGhjlKhSAO76VEn5Hc4EvdXvU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EkxM9W2K; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G1BW0wDN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EkxM9W2K"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G1BW0wDN" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66RDlp2F4115543 for ; Mon, 27 Jul 2026 14:21:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wyyxi6qEfG2lpZGcEqKCVp/wYqYUgxjoyp778N46+xQ=; b=EkxM9W2KxjGpph1g Ch9gxWjv2zmSqOuwe2exh2NS3BPiM1e3GmtncHW0JzA7wB4Va1nm1nUpmeoJw54t eX6G2SavjLPdoNd9je8s8LxitPssXZdDd7rabkWAPB9fxPuk3FVkpeaGrwgr8oxC GjE9jvFyVl6cgFON5XMIErFQlTzNA191iaOCz4LKVEEL0JBxcMBf4tLPa+f8iMJh dF/QxbW6eI25oSuJ5qYj1T+9BNHxmwFRFRhAQdaR3an9vVREl84kM0cSJjQToWcq VE+sjU+rNhe9XPeDD3W9NbtEOjv8OgSkd0V7vCWQl9sko63riGt6pqytDTvIOk7H /Vkmnw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fp4mrs4mh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 14:21:25 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c12e43b98so34985101cf.1 for ; Mon, 27 Jul 2026 07:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785162085; x=1785766885; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Wyyxi6qEfG2lpZGcEqKCVp/wYqYUgxjoyp778N46+xQ=; b=G1BW0wDNqyIcTu7vp0P/Xc1EqcWxEBFvosphBBoO7A3AUpzk50/r0KDqf79bbcrWpI JQBOcV4Hb3zQ+gMiwmFg0WstuFHEAtwCbzV9PRzbITi9UNVeGMsuUVQI2Fi44U15AwvQ rOBii26dKhMOJVoHtC00myK1/Og9Mwy83x6ENK6cIGv7hQi05FDh5hTGoIpxeUycVhYW vw/925Ko0GsIaVVBf3Pf+0xAu5lFEOmko+h8Qagxpc8xz+jBqKiwB2hBNAF/JYuKDww6 F/kmQ+CGSNcAO/AZxHORgt6YRH6OPZ73OglkbtWSh5sH3Xcs6rYr31MvEXiHh93HQZOL IDRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785162085; x=1785766885; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Wyyxi6qEfG2lpZGcEqKCVp/wYqYUgxjoyp778N46+xQ=; b=NaoVbhAU63DfZSMI6u285eC9hvtTqYK+rDBt0Tl8xBVvmyK6TsvILZHMAM+0z3jFJL YzG4fY/KuoDJ0GnIAoT6tBYHStVgYVuS6lu7+pRbuzatn2BbcUuiX64cObdN3XHG4uSX 2FskAb84GBlGlUnERy9g5VCXnOmZhkkUBsFZ1XbpRfB6yN/mArfNAnk4+7uLVjmg99Ta 0Y3SRjbeYz2oorliVoLGCodsh6nCzivSePsj5kxkG8x5waSxi8/ac3UBvby02xbdE2y9 k/HtjHp1+snx1toGzXq8xC01dvN0ly82DjJ8O0f+xlwY6sCxRE2nvtDE98TSiR+q0zPR XroQ== X-Forwarded-Encrypted: i=1; AHgh+Roi6oLSsmVVQnmi0oFFNLw8iMCS23RzJ/UXItki7xRUHv92FTJBXP0OIMPKg7QaWLxgYja2x8+5vK7enq0=@vger.kernel.org X-Gm-Message-State: AOJu0YzY/RZqDqmZyIfPX0IOiNu6FXb40nbakuW4ZmDM6ij1eKH1RKiA t5BgMn26Qzbr7GBO+yWi+jRvzhdA2oInNJbwE0afbHXDdnVq3eMkoCkeBg4xQdKhK4wV/hvcxZP ObVXq469E3Zqp8lNkEj3bouyS0uACvPUXvdkrZ97urkgczOwLjpNG+MNS5aL99LuAq2g= X-Gm-Gg: AR+sD13on5QseTm2dI8y2IdXXuPCjm0cw7zF283xBL1LFy9l1ZUcNI5LA113u6UbCR/ gd2YdtBLuGHlKNBUDQJBMoVbIdVa9h7ZEv/1YRff+pe0equigCRnlNCiFDLtdUIygl7uSs4ykWL hXHHIt5q2xegwQsgAq3kW7OSgjHhliZPWbmyAYmSuf9gvORCXqjPUSNa5lL5Uc7+u7nSoYuF1Zf TxaZ9GxsuBrX+RpVOuFOKEy6zOohPKsc/YuOzPXObb+S1IrOv3Na5yA3VAPNONbpCSwqLboKAhi ebgHsVCMQ8IGzYcd/LMMTPQGNLP6352WaVfRaBeo2TjvUg/wWQq3KDZNutIiYJzEp5pM5YzMn7S 5Bh0L/zOBrHtzxx3Dq4FmUSd7LV9uU5qPzaaQzONyZc5YTA== X-Received: by 2002:a05:622a:98d:b0:51b:fe30:b8da with SMTP id d75a77b69052e-529ccb4999cmr11544991cf.33.1785162084904; Mon, 27 Jul 2026 07:21:24 -0700 (PDT) X-Received: by 2002:a05:622a:98d:b0:51b:fe30:b8da with SMTP id d75a77b69052e-529ccb4999cmr11543041cf.33.1785162082787; Mon, 27 Jul 2026 07:21:22 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496b4858cfdsm243867485e9.3.2026.07.27.07.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 07:21:21 -0700 (PDT) Message-ID: <397db9ac-5c09-4208-975f-f2d9feb71317@oss.qualcomm.com> Date: Mon, 27 Jul 2026 16:21:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal: qcom-spmi-adc-tm5: drop IIO_VAL_INT check in adc_tm5_get_temp To: Rakesh Kota , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Svyatoslav Ryhel , Hans de Goede , Jonathan Cameron Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Wadhwa , Jishnu Prakash References: <20260724-adc-tm5-drop-iio-val-int-check-v1-1-0b85a0895dd7@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260724-adc-tm5-drop-iio-val-int-check-v1-1-0b85a0895dd7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDEzNSBTYWx0ZWRfX3TSdEtvVM2Ih O+qH6ivE/uV43Sx7SQmqupoINlIguZqmhKaEMj//R1GgjxPmY10TM+AZGJueqlzXgpbUx+Dsj0+ UOTSESvMeWJKhIBramdLGFmlZlZPBAY= X-Authority-Analysis: v=2.4 cv=UYBhjqSN c=1 sm=1 tr=0 ts=6a676965 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=pOZ9Tv2q1Ie1c7YLocUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: CKfcglSZ2_TgRm4Yi_PaejCZI5jH8MHl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDEzNSBTYWx0ZWRfXzySpM9Gqd+nv CstKLwMiyHHyo5acXSMymGCd0X2wLyHlqeePPwMa4KugpeYMmaGSwbSKH0r8GrAv2jisK48UYoU Zm88xPBvt0ZhAX1uhGcpVFwsyvouOrccgYGB3dDnEtGw/JEOm+rmTIOUGez0/eF9Wv4Cm1hUJ2m np4UWpxD5p2YmCQB1GUk3tZm7nR1+Th8cMb+DfY5QfGVOxKHPew0ttzYqwAvXyi1oilsIBQD+J0 5kTLqQDfUT7YzDNmbsCvGiCkS0L5yOAS1r8SSTtf3aLqYP97J/ISGrvU6cUP/bc7asMOzgaZYNi rhn0+tlM12Cy8gK8xwzVl/OpYPtzNtdO5G/u1k+ozjuTyZc/TqM4DBS2PAeeFZe4EFepUwUdeFM ubC0GpNaRK/oxc65VEomuUPmxWvD5C8jyf/vjAQR1qz2zMtQkGLJrwOdaTDxj+AcYhzIVNxXFcj YW7HlSXglXEKap6eDHA== X-Proofpoint-ORIG-GUID: CKfcglSZ2_TgRm4Yi_PaejCZI5jH8MHl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_04,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270135 On 7/24/26 13:00, Rakesh Kota wrote: > Commit bb21ee31f575 ("iio: Fix iio_multiply_value use in > iio_read_channel_processed_scale") fixed the > iio_read_channel_processed_scale to return 0 on success instead > of IIO_VAL_INT (1). The existing check in adc_tm5_get_temp() > treated a successful return as an error because it expected > IIO_VAL_INT. Drop the redundant `ret != IIO_VAL_INT` condition > and rely solely on the negative error check. > > Fixes: bb21ee31f575 ("iio: Fix iio_multiply_value use in iio_read_channel_processed_scale") > Signed-off-by: Rakesh Kota > --- Applied, thanks