From: Hannes Reinecke <hare@suse.de>
To: John Garry <john.garry@huawei.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
Xiaofei Tan <tanxiaofei@huawei.com>
Subject: Re: [PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal abort task
Date: Tue, 6 Mar 2018 12:23:01 +0100 [thread overview]
Message-ID: <3983d075-af2e-5c69-2708-51db8a6b79cb@suse.de> (raw)
In-Reply-To: <1520261330-204596-6-git-send-email-john.garry@huawei.com>
On 03/05/2018 03:48 PM, John Garry wrote:
> From: Xiaofei Tan <tanxiaofei@huawei.com>
>
> The current 110ms expiry time is not long enough for the internal
> abort task.
>
> The reason is that the internal abort task could be blocked in HW
> if the HW is retrying to set up link. The internal abort task will
> be executed only when the retry process finished.
>
Hmm. That sounds weird.
I would have expected that a link retrain will force a device reset,
after which no tasks should be active on the target.
Consequently the succeeding abort task will be a no-op.
Care to clarify?
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-03-06 11:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 14:48 [PATCH v3 0/8] hisi_sas: support x6000 board and some misc changes John Garry
2018-03-05 14:48 ` [PATCH v3 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation John Garry
2018-03-05 14:48 ` [PATCH v3 2/8] scsi: hisi_sas: support the property of signal attenuation for v2 hw John Garry
2018-03-05 14:48 ` [PATCH v3 3/8] scsi: hisi_sas: fix the issue of link rate inconsistency John Garry
2018-03-05 14:48 ` [PATCH v3 4/8] scsi: hisi_sas: fix the issue of setting linkrate register John Garry
2018-03-05 14:48 ` [PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal abort task John Garry
2018-03-06 11:23 ` Hannes Reinecke [this message]
2018-03-06 12:30 ` John Garry
2018-03-05 14:48 ` [PATCH v3 6/8] scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req John Garry
2018-03-05 14:48 ` [PATCH v3 7/8] scsi: hisi_sas: fix return value of hisi_sas_task_prep() John Garry
2018-03-05 14:48 ` [PATCH v3 8/8] scsi: hisi_sas: Code cleanup and minor bug fixes John Garry
2018-03-06 11:34 ` Hannes Reinecke
2018-03-06 12:26 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3983d075-af2e-5c69-2708-51db8a6b79cb@suse.de \
--to=hare@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
--cc=tanxiaofei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®