From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5641FC67879 for ; Mon, 8 Oct 2018 23:41:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E12120C0A for ; Mon, 8 Oct 2018 23:41:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E12120C0A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726492AbeJIGzn (ORCPT ); Tue, 9 Oct 2018 02:55:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51834 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725759AbeJIGzn (ORCPT ); Tue, 9 Oct 2018 02:55:43 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 644A286647; Mon, 8 Oct 2018 23:41:35 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-149.rdu2.redhat.com [10.10.120.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34DCA6E500; Mon, 8 Oct 2018 23:41:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <153903891257.17944.7418193390115112585.stgit@warthog.procyon.org.uk> References: <153903891257.17944.7418193390115112585.stgit@warthog.procyon.org.uk> <153903883882.17944.17642727588248415623.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, netdev@vger.kernel.org, pabeni@redhat.com, eric.dumazet@gmail.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 10/10] rxrpc: Fix the packet reception routine MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3984.1539042093.1@warthog.procyon.org.uk> Date: Tue, 09 Oct 2018 00:41:33 +0100 Message-ID: <3985.1539042093@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 08 Oct 2018 23:41:35 +0000 (UTC) To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > struct rxrpc_call *rxrpc_new_incoming_call(struct rxrpc_local *local, > struct rxrpc_sock *rx, > - struct rxrpc_peer *peer, > - struct rxrpc_connection *conn, > struct sk_buff *skb) > { > struct rxrpc_skb_priv *sp = rxrpc_skb(skb); > + struct rxrpc_connection *conn; > + struct rxrpc_peer *peer; 'peer' needs to be initialised to NULL here to prevent an oops later if we fail to look the peer up. - struct rxrpc_peer *peer; + struct rxrpc_peer *peer = NULL; I've repushed the branch with a new tag rxrpc-fixes-20181008-b if you could pull that instead. I can repost the series if you'd prefer. David