From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83CE829431 for ; Tue, 9 Jan 2024 08:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Wx+pSBhg" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40e490c2115so8488635e9.0 for ; Tue, 09 Jan 2024 00:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704787984; x=1705392784; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+1COLRupOMO77VMV9Mt2MrHA2R7Q54lSMFZhM27v8nA=; b=Wx+pSBhgZlJuHioCpkpiWn5xDJRH2KWmD+CR5/WJ1uT2lIQvwnivKZVLpVBw8Na8ZE Yz0aG00p7jbKThfkPV1qt1y7u+ZqBTkvkNYlnP7VGpfy/dNnN+TSAp87DfXT4ygMbAMD UCqYNq46EQS/r9bK5kk+G5kFfEqg8rXf3Vu3RRQS/hEGF3sCsVHThV4hWwukgIggHIz/ 5h4Zoak3mWaHX9buFaHLtUFNQNQgS9E/T70tjNVSm+IIJTCwzsRztVky69lp8USEP1H9 /IoAHV6pOTRuRNAOc6/1yLFAbaYaPXFYpDHx4PDjAiU1C1TeCzNemaB4DcWltzoqU8GX FnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704787984; x=1705392784; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+1COLRupOMO77VMV9Mt2MrHA2R7Q54lSMFZhM27v8nA=; b=bIEd5s3GnCi/PKYFhS8XMA4p7SG4k6a+SgJIR1mSV8VIQwXH2Y2x8pO65/8ux0b2UA IRWryxwdrZaQ0IdzotBeCFZXhP7zX/aP7osaUPbVW8IaJeB2u/kFmWcp/YMwXTfbnxca AZee9kQUEGlKvVgq74s7LygiUaB7XXne6MgUI1r3JalHK9i3xIzeMKawp79xcoXqGcka NKRBwBt1Sjlu5N1w6regguQtUwJLmDkLIs6Nyg5X0HgJEedKhJzBdWGv5IPh1Xl9xjFU zmoGcWKhGP9PqdAWo+Duq18g20u3k4m4nH5dKiAh4D9jEMg96LQy9aoOE49w7V3bGnV5 qRAw== X-Gm-Message-State: AOJu0YyhkEgSLOq25iJY66nW5qE/+zr/1EL+6vpJ7F49xIcRItUdI9I5 D8PeB9L5o9FqDthOpCt7D6mPzWWItrCb/A== X-Google-Smtp-Source: AGHT+IFh4etKDv5DqxBx1VDGukffIzcMl42znwEO74QkPkL0OrCjUXOmjbqhJ31eGCDvDf9YczBJlA== X-Received: by 2002:a05:600c:1d09:b0:40e:43db:7174 with SMTP id l9-20020a05600c1d0900b0040e43db7174mr183460wms.27.1704787983804; Tue, 09 Jan 2024 00:13:03 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id t7-20020a05600c198700b0040d6b91efd9sm13811533wmq.44.2024.01.09.00.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 00:13:03 -0800 (PST) Date: Tue, 9 Jan 2024 11:12:59 +0300 From: Dan Carpenter To: Hidenori Kobayashi Cc: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , Yong Zhi , stable@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] media: staging: ipu3-imgu: Set fields before media_entity_pads_init() Message-ID: <398e06b3-351e-4a1d-b3e4-9c02893ccd83@moroto.mountain> References: <20240109080910.2859780-1-hidenorik@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109080910.2859780-1-hidenorik@chromium.org> On Tue, Jan 09, 2024 at 05:09:09PM +0900, Hidenori Kobayashi wrote: > The imgu driver fails to probe with the following message because it > does not set the pad's flags before calling media_entity_pads_init(). > > [ 14.596315] ipu3-imgu 0000:00:05.0: failed initialize subdev media entity (-22) > [ 14.596322] ipu3-imgu 0000:00:05.0: failed to register subdev0 ret (-22) > [ 14.596327] ipu3-imgu 0000:00:05.0: failed to register pipes (-22) > [ 14.596331] ipu3-imgu 0000:00:05.0: failed to create V4L2 devices (-22) > > Fix the initialization order so that the driver probe succeeds. The ops > initialization is also moved together for readability. > > Fixes: a0ca1627b450 ("media: staging/intel-ipu3: Add v4l2 driver based on media framework") > Cc: # 6.7 > Cc: Dan Carpenter > Signed-off-by: Hidenori Kobayashi > --- Thanks so much! regards, dan carpenter