From: Lucas Stach <l.stach@pengutronix.de>
To: Viraj Shah <viraj.shah@linutronix.de>,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Adam Ford <aford173@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/4] soc: imx: imx8m-blk-ctrl: Add reset bits for mipi dsi phy
Date: Mon, 02 May 2022 12:13:27 +0200 [thread overview]
Message-ID: <399244dcaab28cb7217bae65ee290821ad89afae.camel@pengutronix.de> (raw)
In-Reply-To: <20220502100233.6023-4-viraj.shah@linutronix.de>
Am Montag, dem 02.05.2022 um 12:02 +0200 schrieb Viraj Shah:
> As per reference manual page 3903, bit 16 (GPR_MIPI_S_RESETN)
> as well as 17 (GPR_MIPI_M_RESETN) are the reset masks for mipi phy reset
> mask.
Nack. The MIPI-S reset is used for the CSI receiver and is already
handled by the appropriate power domain.
Regards,
Lucas
>
> Signed-off-by: Viraj Shah <viraj.shah@linutronix.de>
> ---
> drivers/soc/imx/imx8m-blk-ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index ca63fd30e70a..d7638b7fa99d 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -502,7 +502,7 @@ static const struct imx8m_blk_ctrl_domain_data imx8mm_disp_blk_ctl_domain_data[]
> .gpc_name = "mipi-dsi",
> .rst_mask = BIT(5),
> .clk_mask = BIT(8) | BIT(9),
> - .mipi_phy_rst_mask = BIT(17),
> + .mipi_phy_rst_mask = BIT(17) | BIT(16),
> },
> [IMX8MM_DISPBLK_PD_MIPI_CSI] = {
> .name = "dispblk-mipi-csi",
next prev parent reply other threads:[~2022-05-02 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 10:02 [PATCH v1 0/4] imx8mm display controller power sequence Viraj Shah
2022-05-02 10:02 ` [PATCH v1 1/4] soc: imx8mm: gpcv2: Power sequence for DISP Viraj Shah
2022-05-02 10:11 ` Lucas Stach
2022-05-02 10:02 ` [PATCH v1 2/4] soc: imx: imx8m-blk-ctrl: Display Power ON sequence Viraj Shah
2022-05-02 10:12 ` Lucas Stach
2022-05-02 10:02 ` [PATCH v1 3/4] soc: imx: imx8m-blk-ctrl: Add reset bits for mipi dsi phy Viraj Shah
2022-05-02 10:13 ` Lucas Stach [this message]
2022-05-02 10:02 ` [PATCH v1 4/4] arm64: dts: imx8mm.dtsi: Add resets for dispmix power domain Viraj Shah
2022-05-02 10:14 ` Lucas Stach
2022-05-02 10:18 ` [PATCH v1 0/4] imx8mm display controller power sequence Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=399244dcaab28cb7217bae65ee290821ad89afae.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=aford173@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=viraj.shah@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®