From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbeDHBPz (ORCPT ); Sat, 7 Apr 2018 21:15:55 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7155 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751387AbeDHBPy (ORCPT ); Sat, 7 Apr 2018 21:15:54 -0400 Subject: Re: [PATCH] f2fs: fix to show encrypt flag in FS_IOC_GETFLAGS To: Jaegeuk Kim CC: , , References: <20180402102446.32832-1-yuchao0@huawei.com> <20180402202105.GB19195@jaegeuk-macbookpro.roam.corp.google.com> <3f76800a-8b68-b378-8b03-c14248966be4@huawei.com> <20180405034609.GA50337@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <3993ce80-7446-2fce-e8da-c677c8cf5225@huawei.com> Date: Sun, 8 Apr 2018 09:15:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180405034609.GA50337@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/4/5 11:46, Jaegeuk Kim wrote: > On 04/03, Chao Yu wrote: >> On 2018/4/3 4:21, Jaegeuk Kim wrote: >>> On 04/02, Chao Yu wrote: >>>> This patch fixes to show encrypt flag in FS_IOC_GETFLAGS like ext4 does. >>> >>> Actually, we have to show internal flags owned by f2fs, not generic ones. >>> We may need to define all of them separately? >> >> Agreed, I wrote a patch, could check that? and in that patch, do we need to >> delete flag definition f2fs don't use? > > IMO, we'd better keep the flags. I merged it and could you add encryption part Agreed. > on top of it? No problem. ;) Thanks, > > Thanks, > >> >> Thanks, >> >>> >>>> >>>> Signed-off-by: Chao Yu >>>> --- >>>> fs/f2fs/file.c | 9 +++++++-- >>>> 1 file changed, 7 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >>>> index 8068b015ece5..271fadadaa36 100644 >>>> --- a/fs/f2fs/file.c >>>> +++ b/fs/f2fs/file.c >>>> @@ -1584,8 +1584,13 @@ static int f2fs_ioc_getflags(struct file *filp, unsigned long arg) >>>> { >>>> struct inode *inode = file_inode(filp); >>>> struct f2fs_inode_info *fi = F2FS_I(inode); >>>> - unsigned int flags = fi->i_flags & >>>> - (FS_FL_USER_VISIBLE | FS_PROJINHERIT_FL); >>>> + unsigned int flags = fi->i_flags; >>>> + >>>> + if (file_is_encrypt(inode)) >>>> + flags |= FS_ENCRYPT_FL; >>>> + >>>> + flags &= FS_FL_USER_VISIBLE | FS_PROJINHERIT_FL; >>>> + >>>> return put_user(flags, (int __user *)arg); >>>> } >>>> >>>> -- >>>> 2.15.0.55.gc2ece9dc4de6 >>> >>> . >>> > > . >