From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BAB338A701 for ; Tue, 9 Jun 2026 09:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999182; cv=none; b=rYnUK/6RZijDb81tmdYKWIpPRidQs1IqIQ9YNohI16kq4C29G/LDZdmnIVh1DX8/iooaoPqSZZ/JiD1gHPt/ckPSjZQvs/pAglCOrPTnFZ2tZh8jvn6SXTdc3BO0YbTGhoP+eQrkDZToSOu6jzT+n6hJhBMmjoNizX5TNIpMjsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999182; c=relaxed/simple; bh=BnrDNf0KyblpDzK8RL0uKrkJf8wwscJiCPoMZoRQgEE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gb2LGekfDccgNuVzafsQlMBNQosiYJvj1WF39BzZc2sfQJBZTXEXcIkdXmwP4p7R/leQdaPnhOYeCnrfjMgiKmTIBVUEf73T6o0mpKrGgjJSWDqIA197KcEOSRYHJlIEkOkXu2uZ2DmNb9Umc8phO5KmeT8fslBORgVjWeJksFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N3wuP7ik; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=clowVXH5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N3wuP7ik"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="clowVXH5" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6599xaK72320656 for ; Tue, 9 Jun 2026 09:59:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mCRCXBCvtK+g4473pmA8flE8eK+i+w67FZXpAsMZxKU=; b=N3wuP7ikpeNn4yvM y0oN9DfEotLoUMt6HJ06o0iGXDd2nxVSW9XV2lyETljaSvQHNfxD1LXoxl8yrPH9 LxbygrHDj8/PF15RlitMEZ1bUu3Bhgu3g+BvhoQkWPtJ4i4AhvSXa2dsKz/IWs7Q mm8L8krl5fb1UfTQAdtgeBlR1wRIiJLJDwcUYWMgCef83GLrn6M8WCR1U9QUrenw 6YATZ5yWxMq8V2QB6zcZAnGLyIbsorNC4OITD4sy5mVC/pWzx4yb3eJlfhIi6TpZ 5l2llhF+aa0NshNZeKbRymhbkg7IeLn6EvLAW2k7rkaK/sYy7quGALY/DWjNl/yf GPg3Wg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epeearm3d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 09:59:40 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bf335549b8so82480405ad.1 for ; Tue, 09 Jun 2026 02:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780999179; x=1781603979; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mCRCXBCvtK+g4473pmA8flE8eK+i+w67FZXpAsMZxKU=; b=clowVXH57ZBdSIp0ThuvUqp5FpAZ3Yl4Ad5X9zGU5UIflU1h8/sxTGWxEI2GQHWaIl wD3yYsqU9cSJTSu2ZxwsjZ52lHYwg4Bj9oVnaa36XPJclPetFYsKom1isHljVRHlRFPt k8h8d81Ox1aQ/FRN5ftpxByVYFeIDEqxtT1lAAYKJx3GFW1FpHr8XkYhCsfaC4XclxF3 eYBSLXeqnZCjfZRuWtnZMuzGXsON8aIK1hQF8b9jiaBoldcyZ+H6wLwU10BoVDbFZrGV PEnJHuhut8a2aC3vYwb1JVHsd+mIgUc2InVNgKD85ADP4cPe2jug12RXcP+0QPVG4KKQ ANcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780999179; x=1781603979; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mCRCXBCvtK+g4473pmA8flE8eK+i+w67FZXpAsMZxKU=; b=SwwdgK2DLPQd5t1/b1XGZVIZ8V6B7hq6QKKtiCpQL93DmMUZyqYkxTvOaBOBDHR2V5 IpNxtdxf7GMltk6fedBcHoWFRLgQzPQlmwkzAFqr8T3XVhLACNYzzzUU+RkFnct6cXbd Cjgzw+b3QmyScPmkFtHwFcgj8I++fPHh/jrZq/xWz2d8Ll9Qg3oyVoY7FAzcv3jIBVsB 41ch7hZioVBMKJvOsL1xfJ0tCLTy2YF0cuAOPHlJYU59D+/UJ8rsDUtewPEBqyTIvJ+d OUh8W4WNY38PoGPMlvB3JSET6A4N0HlHjnzmlTKLf1U9d3/LYRkrvNp/FNIWUqGaVQPK OStg== X-Forwarded-Encrypted: i=1; AFNElJ86HSjcbHbD3pkXJYNtZ5nqhJAoVCpNvBpRr0cvnJT3wR1dU1ct6U7ZXteqYbGGJhrCjKGJE3VJOtZ1CQs=@vger.kernel.org X-Gm-Message-State: AOJu0YxfnF0jk6/H7Vg0rY4ClZO5eG/uoVnI/tWy6M/iEiXkcqf1ElU3 ULh3vJAl/oMT0dKOy1tKTogbcUhppgyIdu944tnX4rv+tyKM0g55k10hItIzscVhPT13sqfxeCg /ft7UW+icL1ZiQH1RSbqbrkYKbT4/ohL26MzxOJc+Ws/LDlidqkGPIJc+kMWGyMFPiV0= X-Gm-Gg: Acq92OFk+Q0WT6xlFgG7/A3UnbauiP1b3ojZ1M7fbSXptmWuDRcbArXLN28qcQbuQA3 +Vx70QlRkhdDkXl8hpLuUlB5gEtrZU1Jac6q7QUm3xb7N/Juzq3Sv88AAwGRSCcaTKBJ0Wso9pS pHRxoCcOlmc7pPVs18nm6xhLrJtfMBTiXRdSad1KaPpvNvVOP6Vnpi9hRnJVq2NlkZGBKxSPzIp s2aQ19efzyUXJiU8GTNUndTQDbt4hxAk1vgcTqNDZgllH1X5mUEk4i/Dfw9M1moA6xXnb09LFpS 9qyfxcN0kHs0vKl3trILjcsSogZzsRqnxD9pZtI8bnj3FafKe9PPlm8kg2lVFDDL+QCAXYcTYGi YF/xYhN3/urwFjLSjVSEEvP7q3Ur3fS2w4jYuxVWT2lkI3XwE0rjc0ahQr2cVoQ== X-Received: by 2002:a17:903:19e6:b0:2bf:21e6:baee with SMTP id d9443c01a7336-2c1e82324camr197066435ad.28.1780999179135; Tue, 09 Jun 2026 02:59:39 -0700 (PDT) X-Received: by 2002:a17:903:19e6:b0:2bf:21e6:baee with SMTP id d9443c01a7336-2c1e82324camr197066175ad.28.1780999178703; Tue, 09 Jun 2026 02:59:38 -0700 (PDT) Received: from [10.206.103.106] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c1663981basm205544425ad.67.2026.06.09.02.59.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 02:59:38 -0700 (PDT) Message-ID: <399bd375-235f-43a2-965e-e86e041a5a7f@oss.qualcomm.com> Date: Tue, 9 Jun 2026 15:29:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/8] media: qcom: camss: csiphy-3ph: Use odd bits for configuring C-PHY lanes To: David Heidelberg , Robert Foss , Todor Tomov , Bryan O'Donoghue , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , "Dr. Git" , Cory Keitz , Loic Poulain Cc: Frank Li , Konrad Dybcio , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260605-qcom-cphy-v7-0-426c37e9008f@ixit.cz> <20260605-qcom-cphy-v7-2-426c37e9008f@ixit.cz> Content-Language: en-US From: Nihal Kumar Gupta In-Reply-To: <20260605-qcom-cphy-v7-2-426c37e9008f@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: TOCWlQuLVhgBZJZY8TdjRu0EwJakzchO X-Authority-Analysis: v=2.4 cv=Iey3n2qa c=1 sm=1 tr=0 ts=6a27e40c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=Yq6uI0ozdmgzgeLbScEA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDA5MiBTYWx0ZWRfX1uBeSI960bC2 wEA3H77y0lOT7H6D8mAifxZqERb1t7NgexgIiRTiJFedIOU2YhG7Jjq8otmsUlhPFzj1FoMDKkj 2MtZiqVODCw4PWqqtM/bparZtsDiLEYx1Z0aVarVxX4HflfK89y1Y/taxizX3bazjw61O3I2oLd eaLdPo3j74ypmczG0lHm0z+Os9V9SR1opFR1AjJVmJpus1ZVnsELpSBP6Qh3VFnwHkzpDzu11Y3 rDB4ShrQhSMOYKhTEvD4FZ7kxD0+XERNM6yvRVrMhjbl80FkiF++HHgzWz09+om5WlRh4w5QR67 o8bsQ1/jIXBAIwAO/p2tfUvYqvnONZQJOwBJnRokcf6500RMSyrWuJ1UYbFxMMMOall6cX/jFcp UuNQZQXvgQnalJ0A4zGP+gvEUo23u1mudsBfsk/go9pDkqmFv91n+v/aKs/ZSP5HcwWgkyGkpd3 EfVykiaWj/vBf6n4ovA== X-Proofpoint-GUID: TOCWlQuLVhgBZJZY8TdjRu0EwJakzchO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090092 On 05-06-2026 18:44, David Heidelberg wrote: > + offset = 1; > + break; > + case V4L2_MBUS_CSI2_DPHY: > + lane_mask = CSIPHY_3PH_CMN_CSI_COMMON_CTRL5_CLK_ENABLE; > + break; > + default: > + break; > + } > > - for (i = 0; i < lane_cfg->num_data; i++) > - lane_mask |= 1 << lane_cfg->data[i].pos; > + for (int i = 0; i < lane_cfg->num_data; i++) > + lane_mask |= BIT(lane_cfg->data[i].pos + offset); > > return lane_mask; > } csiphy_get_lane_mask() uses pos + offset but the 3PH hardware encodes lanes at pos*2 (D-PHY) or pos*2+1 (C-PHY). Fix it as: lane_mask |= BIT((lane_cfg->data[i].pos * 2) + offset); > static bool csiphy_is_gen2(u32 version) > { > bool ret = false; > > @@ -1155,19 +1165,32 @@ static void csiphy_lanes_enable(struct csiphy_device *csiphy, > struct csiphy_lanes_cfg *c = &cfg->csi2->lane_cfg; > struct csiphy_device_regs *regs = csiphy->regs; > u8 settle_cnt; > u8 val; > int i; > > settle_cnt = csiphy_settle_cnt_calc(link_freq, csiphy->timer_clk_rate); > > - val = CSIPHY_3PH_CMN_CSI_COMMON_CTRL5_CLK_ENABLE; > - for (i = 0; i < c->num_data; i++) > - val |= BIT(c->data[i].pos * 2); > + val = 0; > + > + switch (c->phy_cfg) { > + case V4L2_MBUS_CSI2_CPHY: > + for (i = 0; i < c->num_data; i++) > + val |= BIT((c->data[i].pos * 2) + 1); > + break; > + case V4L2_MBUS_CSI2_DPHY: > + val = CSIPHY_3PH_CMN_CSI_COMMON_CTRL5_CLK_ENABLE; > + > + for (i = 0; i < c->num_data; i++) > + val |= BIT(c->data[i].pos * 2); > + break; > + default: > + WARN_ONCE(1, "Unsupported bus type %d!\n", c->phy_cfg); > + } Also, with above fix in place, lanes_enable() can reuse csiphy_get_lane_mask() instead of open-coding the same logic. --- Regards, Nihal Kumar Gupta