From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35FE73403F1; Fri, 18 Sep 2026 09:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789722560; cv=fail; b=esNnxvmdaeYTBTfH9uAdJUb8LfkcgRiu/K8ziSn/xCamFRlWACeilC8U/RR9t2VtHLg6Ix94Js50uF1mndpAM2Lm4VZgvaG06AUF7qmqIMEG4v6zVWLxL2CSeEA+BOwCDhc8lMDKZfUvOCXzpOobyMiFPu+kz7yDxP68ZKyd1Us= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789722560; c=relaxed/simple; bh=/dMfEPuWu0rxrHumph/Xzpo7bBLnfAX2lgIzssSsNRs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=QRCQzShbUg44HGWedW1OxEiIRjuZM1m0w9XwyI6x1jl5utxqKr+cWFh+Uw3S6IKV1rJM7tMEXbynCrb6vI87jFZQLygGUUDC81xDa/3t/kx80T+cL8RtcGNEU6dxMfF8j7CWL0BXXeXfv8ZIes6decIA4TLoopAgV3b4GsHUxLI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Dh4vcLli; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=aCqwJ3Kh; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Dh4vcLli"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="aCqwJ3Kh" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I74LLj3917819; Fri, 18 Sep 2026 04:09:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=0N3mLnnUVKRe/F2Yr1OmqiWgS23quWIrksUAVGjtS Uw=; b=Dh4vcLli530Q+76CoPxIpa8RXohoXpo8i8R7+5+L1HUZPhyJbGdlP2mr3 WMgbq+68L9Fidy/yI+wvdpxUdTjdGKIhfU/adpHEyOS9uLMBhJzMJmLlgBoDX1zW 1dZ/tkFi7k4rgLIP1YKicbrQwzDw7GiXXc5sRQZx/ohEHkJrObaW9Toe4yPNNMpu 03EhIBeQ6cgdFIiX11ZXdTj7mK8gA8Y9mJxV48QkizmJQslBsydRGwM46cKTudXa 0mIEcGsUkPmrQMyJbtChuEEkG8khqYTyorrufsT5MG3gK2Vp2BHpnNODdkK1GnD8 BCMiyHQZN9RXDQdjODfwqRil4PUSg== Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazon11012023.outbound.protection.outlook.com [40.93.195.23]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gs0k38mgx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Sep 2026 04:09:13 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wKuJGPTzAhHd7QOAmMVi5SeYaOugNpF5lw5jdQA0UNWjkVePLQFyufyCNbG5PxERId14JAhGh5jd28ZpluFDfalBW8EmKr2LMb8UVO0Y6KnrWK3p18tOOGrfX1u7dKMMdjg+h/2IYwRtpJXLXY3vTDKDtQxJg0MXc35ckkL97nWmZTOkJ/9jtvsBHBB/SgbJh8cRLJDlPBzcST/PXpM2c15jZ9ExRtSTjocuujh8zJBLOqQFXla2b4LsNMkF1FiRXrOGBrK26THuddU9BHRkzg5H4iQPBLM36EqUA7bIgyGwBxNSQ8UuYVMLQVVEJOA1i8ecwc3j9fO+ZkbvJHOvXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0N3mLnnUVKRe/F2Yr1OmqiWgS23quWIrksUAVGjtSUw=; b=bxD2fPxW6pqTf6if8uuJVUUDBINCRdBQoXoDJE0Lp6OMqSswLdjHwGUGN029wDDaUg2reENDfWqP0rKXkYwFNas45pbZKDsxLIGjEddqLSIVTQAWPs/gp5BN2g9mNUP4yDk0VAVIvX4860VKorv5kAQiGzWF8LtJguyOYUNV8T5Ci51S9NbAVLrDlB4Aglj3kh9Dwf2/KTrkJUrTG1Y/u9nhKjSlG1c6SNUgT5P3hha5axO8lQT87QR2GBY0atBrDBo2Sob2iv9gZUjQ+oeya4vjyRwdZVsvK61JCEWAJ02eALcIjzp3IF9Ra4nBY/pFhBa7GNx4AU4GlCqi8bCQdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0N3mLnnUVKRe/F2Yr1OmqiWgS23quWIrksUAVGjtSUw=; b=aCqwJ3KhcKX2rkLEY8iTH2N+YYJo+g5AFS+D6wVJeUjNPaKPqX5nGATAAyTtC9sRNGrIAfAqiV/KsSuBpEw+PiJkNIH5qpqMWy/OeSzcVUlda6+7q7ANQGXwoSp+uTR8yTslgVgaMXpiKC+Js22QW1S/t8Ty6VcQL3pZMqSFdD0= Received: from DS1P223CA0027.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:44e::18) by DS0PR10MB6199.namprd10.prod.outlook.com (2603:10b6:8:c1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.13; Fri, 18 Sep 2026 09:09:11 +0000 Received: from BN1PEPF00005FFC.namprd05.prod.outlook.com (2603:10b6:8:44e:cafe::2e) by DS1P223CA0027.outlook.office365.com (2603:10b6:8:44e::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.13 via Frontend Transport; Fri, 18 Sep 2026 09:09:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by BN1PEPF00005FFC.mail.protection.outlook.com (10.167.243.228) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.8 via Frontend Transport; Fri, 18 Sep 2026 09:09:07 +0000 Received: from DFLE203.ent.ti.com (10.64.6.61) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 04:08:22 -0500 Received: from DFLE214.ent.ti.com (10.64.6.72) by DFLE203.ent.ti.com (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Fri, 18 Sep 2026 04:08:22 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE214.ent.ti.com (10.64.6.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Fri, 18 Sep 2026 04:08:22 -0500 Received: from [10.24.51.87] (devarsh-precision-tower-3620.dhcp.ti.com [10.24.51.87]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68I98JOQ500344; Fri, 18 Sep 2026 04:08:20 -0500 Message-ID: <39a03dcb-bebd-4794-a2bf-ff1b56cb632b@ti.com> Date: Fri, 18 Sep 2026 14:38:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] media: imagination: e5010: Properly Release m2m_dev if probe fails To: Brandon Brnich , , , , , , CC: References: <20260831213231.2125544-1-b-brnich@ti.com> <20260831213231.2125544-2-b-brnich@ti.com> Content-Language: en-US From: Devarsh Thakkar In-Reply-To: <20260831213231.2125544-2-b-brnich@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00005FFC:EE_|DS0PR10MB6199:EE_ X-MS-Office365-Filtering-Correlation-Id: 456470b9-96eb-4eec-bda0-08df15647ed3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700016|23010399003|376014|56012099006|10067099003|6133799003|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: RmFLcKB6qVcwjlex5G1Mtdk3CzCXaOA5p38HnuOdHiURI9jUuTuGO0x6X6y4eAcOt9CH8ywySLPFhVeAKjxn5o7R7783FKYvcaJMjjq1TRAI5jB22FAAMpjO6UkbIw8KjKxV7DYqqWyPB2YVTb3PTQSNZOzNodscduCe/GJ07p8Rm0jUwZLqgRH3UfjAV65s/Ap4sRpEuTF8JAJbtZvV5rypUs3h1ohXSWt50xCgRI+35P5KrYGS/r9vFMNwI7P3Rwcm6FsW9xMKCCe9GPcTRaXUN1hKDtlEFTTZBAB3kgkQm/OMXQO0Dsk/rnw7e4jmapQYh3GRTaP7AGhcxAQkj5mAPnblOplIKuQJ0eY+AeNftfEduW+JolEFyJGGfxlLOiskNagCa92Sy7/fT5+KQSKhSNniwt2h44yVpWic86z1AxmFoQ564ZGAkVexi8Fgboaegu5fSMa72eRrwcipBwUqL7UrqRhoEBjrv2xqKZ1P6Yam4ocR1/ljtJn9MLPTifSX0jd0sBzwk/8a/nbAzCw6eMRNSlZsLMNFDQxr6hebDDWwQcfhNM27gcUSu+YRJgksIfAnuB6f6/YOiJRAepcr8gHf0k4otphQ8VqsiJcjKiOdfpfwatMe3J97ci6qSyH9LpYXAzau6kfKiGg0jQpKf5C5iBhibVTouIl7jNijh3nSmeMUyms+FIPEycL6UnogNlnlRb8HYvM4kuxorw== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700016)(23010399003)(376014)(56012099006)(10067099003)(6133799003)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ca4aVFKE4r8y88TOwQn1Pvs5CJd1vYTdRsi/yQ4sa2sFY70eXYRjRXVjvJjrLttVLrZRKfXY4KXDNvg0OvJmaAy7QR7/wInRP5oyp4ZGP5oVqZCtb2mruI0J1UoIetb2cNwmYLlmnJ9hnCF2y3PfdpVwv4UteyC4t5qk3TM/EuxWOsPGl7j5qOfcGtHuuoyc3OGG9Rmu6mZ5S/XHdrq1OwfiK91KUvUL9o1XeKF4J7pRmBtgfO4zZ4Eit9IESs6A5KvGpO4v3pB9ds0HviZAmBzQRRF6Z2hhIIeJWM3w6sg5CbqJcrwXSytfkkLhn2D18tEvmEk5l+i/gy3NuAMDcMTX8fC6L05hLCG+yr0Okenx7td/GiAg7upWtD08i+EH2ZYoOytIO6DezcNbivrtT6VR7FPagbd1cAYmyERjUCdTodSjVPGRiPxNDfHbVBMi X-Exchange-RoutingPolicyChecked: rVwKulmDiz3YzM1pHE1RqRmjMzSS9BG/060wO/UxLArVBDVPhLRldIGpWgMD8Qsn/ER53PAZccKOidI0sbP5wEQouRmYV8wqBmc7fBAci6eZrGDtKA3//Abt/ioTBMBJRFY9zegkIGSYzWMJI8BY46VQLnvPV/x346ybmr43LJIz5IHh2prheUPF2oXEGSLItuY41aV28V+d+mM+JosWoG+6cox6t3jczf6VdM7pfa8uExdEoobH0M5nTJxGnGULc9kxO5XJ11Rd62f5rMsyVRTrjGbYxxhlwuWFjFKxghJ8Wc+jU0jDuVBXa6l4Uh7S2i61r/t5llKjzJjEZW1dOA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2026 09:09:07.7514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 456470b9-96eb-4eec-bda0-08df15647ed3 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00005FFC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6199 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDEyNSBTYWx0ZWRfX6EA3cmVxbrPU gFDsaZH9LCp84vxl6R1DOr2J4co17SYcaXOztTukPzfNOM516otPGhmq/y88XDH2ck19wvJFkzj CwbUQbbFbhfm51RvgKi81xzeZUg5Xqo= X-Authority-Analysis: v=2.4 cv=K6S3jCWI c=1 sm=1 tr=0 ts=6aacffb9 cx=c_pps a=CfFGriBY15yWSKnMtEY+og==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=VwQbUJbxAAAA:8 a=sozttTNsAAAA:8 a=iSXspe6crHLR8TXTscMA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDEyNSBTYWx0ZWRfX+iW5Tgv4immT 6EEco6eHTLjH5/QtCDpwBdLD4422AasJe+CMq6IZJwXT8+dhaLtVlbscWoPgsUNBt4HR+3/P67B Y6p+LCqd5W8xutavAtKVgjTJM9f4OEcrDQt2UcnFp3NEeEY+S1d+CaNI4qT5BeDpvf2VcUjjAd/ oDvR/SdtvyjfIbHbE+383JR59QWDwxj4NdVf7Lw1s8Wvyf5L53+yPTdZWn3I5LjySUXEBJ4Dkmq jXUs342L6TyxCeCdjfkjioZ3tCdL6H0AIBHjgPoiAEzD/wLxZHY9YZ/oQVUaVGR4TPEhaRzSMPF XzzMr5FZMFQSkT8C67YDCQ02X0cuuMb3/RbWcYqtb2YS8vRzHHeChg4SVb3yncFV83D9medR0O5 zaseC+df2oMYHxFHa46p1V+zJf7RHy9QCTstzRPWTJcx6svhev7mMPeeptyFbwn3Rpu2AUmfmpz e0LBod+0q5ipF/18jfw== X-Proofpoint-GUID: 3xxmSqOCaIkZ9CfcHk74zs4dVElmGKx6 X-Proofpoint-ORIG-GUID: 3xxmSqOCaIkZ9CfcHk74zs4dVElmGKx6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_02,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1011 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180125 Hi Brandon, Thanks for the patch. On 01/09/26 03:02, Brandon Brnich wrote: > After the call to v4l2_m2m_init() is successful, the following > initialization functions should go to fail_after_video_register_device. > > Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver") > Cc: stable@vger.kernel.org > Signed-off-by: Brandon Brnich > --- > drivers/media/platform/imagination/e5010-jpeg-enc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c > index 42ad9ee3993b4..d3c11337c815d 100644 > --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c > +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c > @@ -1072,14 +1072,14 @@ static int e5010_probe(struct platform_device *pdev) > if (IS_ERR(e5010->core_base)) { > ret = PTR_ERR(e5010->core_base); > dev_err_probe(dev, ret, "Missing 'core' resources area\n"); > - goto fail_after_v4l2_register; > + goto fail_after_video_register_device; The label naming looks incorrect semantically since video_register_device happens after all this at last actually. Please change it to fail_after_v4l2_m2m_init instead. > } > > e5010->mmu_base = devm_platform_ioremap_resource_byname(pdev, "mmu"); > if (IS_ERR(e5010->mmu_base)) { > ret = PTR_ERR(e5010->mmu_base); > dev_err_probe(dev, ret, "Missing 'mmu' resources area\n"); > - goto fail_after_v4l2_register; > + goto fail_after_video_register_device; > } > goto fail_after_v4l2_m2m_init > e5010->last_context_run = NULL; > @@ -1089,14 +1089,14 @@ static int e5010_probe(struct platform_device *pdev) > E5010_MODULE_NAME, e5010); > if (ret) { > dev_err_probe(dev, ret, "failed to register IRQ %d\n", irq); > - goto fail_after_v4l2_register; > + goto fail_after_video_register_device; > } goto fail_after_v4l2_m2m_init > > e5010->clk = devm_clk_get(dev, NULL); > if (IS_ERR(e5010->clk)) { > ret = PTR_ERR(e5010->clk); > dev_err_probe(dev, ret, "failed to get clock\n"); > - goto fail_after_v4l2_register; > + goto fail_after_video_register_device; > } goto fail_after_v4l2_m2m_init > > pm_runtime_enable(dev); Regards Devarsh